fix(importers): return ImportResult from handle_error

Implement handle_error() in all importers so errors return a concrete ImportResult (success=false, error_message set) instead of None, preventing NoneType.success crashes.

Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

src/basic_memory/importers/chatgpt_importer.py

@@ -15,6 +15,19 @@
 class ChatGPTImporter(Importer[ChatImportResult]):
     """Service for importing ChatGPT conversations."""
 
+    def handle_error(
+        self, message: str, error: Optional[Exception] = None
+    ) -> ChatImportResult:
+        """Return a failed ChatImportResult with an error message."""
+        error_msg = f"{message}: {error}" if error else message
+        return ChatImportResult(
+            import_count={},
+            success=False,
+            error_message=error_msg,
+            conversations=0,
+            messages=0,
+        )
+
     async def import_data(
         self, source_data, destination_folder: str, **kwargs: Any
     ) -> ChatImportResult:
@@ -67,7 +80,7 @@ async def import_data(
 
         except Exception as e:  # pragma: no cover
             logger.exception("Failed to import ChatGPT conversations")
-            return self.handle_error("Failed to import ChatGPT conversations", e)  # pyright: ignore [reportReturnType]
+            return self.handle_error("Failed to import ChatGPT conversations", e)
 
     def _format_chat_content(
         self, folder: str, conversation: Dict[str, Any]

src/basic_memory/importers/claude_conversations_importer.py

@@ -2,7 +2,7 @@
 
 import logging
 from datetime import datetime
-from typing import Any, Dict, List
+from typing import Any, Dict, List, Optional
 
 from basic_memory.markdown.schemas import EntityFrontmatter, EntityMarkdown
 from basic_memory.importers.base import Importer
@@ -15,6 +15,19 @@
 class ClaudeConversationsImporter(Importer[ChatImportResult]):
     """Service for importing Claude conversations."""
 
+    def handle_error(
+        self, message: str, error: Optional[Exception] = None
+    ) -> ChatImportResult:
+        """Return a failed ChatImportResult with an error message."""
+        error_msg = f"{message}: {error}" if error else message
+        return ChatImportResult(
+            import_count={},
+            success=False,
+            error_message=error_msg,
+            conversations=0,
+            messages=0,
+        )
+
     async def import_data(
         self, source_data, destination_folder: str, **kwargs: Any
     ) -> ChatImportResult:
@@ -67,7 +80,7 @@ async def import_data(
 
         except Exception as e:  # pragma: no cover
             logger.exception("Failed to import Claude conversations")
-            return self.handle_error("Failed to import Claude conversations", e)  # pyright: ignore [reportReturnType]
+            return self.handle_error("Failed to import Claude conversations", e)
 
     def _format_chat_content(
         self,

src/basic_memory/importers/claude_projects_importer.py

@@ -14,6 +14,19 @@
 class ClaudeProjectsImporter(Importer[ProjectImportResult]):
     """Service for importing Claude projects."""
 
+    def handle_error(
+        self, message: str, error: Optional[Exception] = None
+    ) -> ProjectImportResult:
+        """Return a failed ProjectImportResult with an error message."""
+        error_msg = f"{message}: {error}" if error else message
+        return ProjectImportResult(
+            import_count={},
+            success=False,
+            error_message=error_msg,
+            documents=0,
+            prompts=0,
+        )
+
     async def import_data(
         self, source_data, destination_folder: str, **kwargs: Any
     ) -> ProjectImportResult:
@@ -73,7 +86,7 @@ async def import_data(
 
         except Exception as e:  # pragma: no cover
             logger.exception("Failed to import Claude projects")
-            return self.handle_error("Failed to import Claude projects", e)  # pyright: ignore [reportReturnType]
+            return self.handle_error("Failed to import Claude projects", e)
 
     def _format_project_markdown(
         self, project: Dict[str, Any], doc: Dict[str, Any], destination_folder: str = ""

src/basic_memory/importers/memory_json_importer.py

@@ -1,7 +1,7 @@
 """Memory JSON import service for Basic Memory."""
 
 import logging
-from typing import Any, Dict, List
+from typing import Any, Dict, List, Optional
 
 from basic_memory.markdown.schemas import EntityFrontmatter, EntityMarkdown, Observation, Relation
 from basic_memory.importers.base import Importer
@@ -13,6 +13,20 @@
 class MemoryJsonImporter(Importer[EntityImportResult]):
     """Service for importing memory.json format data."""
 
+    def handle_error(
+        self, message: str, error: Optional[Exception] = None
+    ) -> EntityImportResult:
+        """Return a failed EntityImportResult with an error message."""
+        error_msg = f"{message}: {error}" if error else message
+        return EntityImportResult(
+            import_count={},
+            success=False,
+            error_message=error_msg,
+            entities=0,
+            relations=0,
+            skipped_entities=0,
+        )
+
     async def import_data(
         self, source_data, destination_folder: str = "", **kwargs: Any
     ) -> EntityImportResult:
@@ -113,4 +127,4 @@ async def import_data(
 
         except Exception as e:  # pragma: no cover
             logger.exception("Failed to import memory.json")
-            return self.handle_error("Failed to import memory.json", e)  # pyright: ignore [reportReturnType]
+            return self.handle_error("Failed to import memory.json", e)