fix(test): make setup_logging config-dir regression test Windows-safe

``test_setup_logging_honors_basic_memory_config_dir`` was monkeypatching
``utils.os.name`` to ``"posix"`` to force ``setup_logging`` onto the
shared-log-filename branch, which let the test assert on the exact
path. That globally redirected ``os.name``, and on Windows CI that
broke ``Path(str)`` dispatch inside ``resolve_data_dir``:

    pathlib.UnsupportedOperation: cannot instantiate 'PosixPath' on
    your system

The regression guard only cares that the log file lives under the
redirected ``BASIC_MEMORY_CONFIG_DIR`` — not at ``Path.home()``. It
does not care whether the filename is the shared ``basic-memory.log``
(POSIX) or the per-process ``basic-memory-<pid>.log`` (Windows).

Drop the ``os.name`` patch, assert on ``log_path.parent`` equalling
the custom dir, and sanity-check the filename pattern without pinning
the pid suffix. Same intent, portable.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Drew Cain <groksrc@gmail.com>

Author: groksrc

tests/utils/test_setup_logging.py

@@ -2,6 +2,7 @@
 
 import os
 import sys
+from pathlib import Path
 
 from basic_memory import utils
 
@@ -91,13 +92,20 @@ def test_setup_logging_honors_basic_memory_config_dir(monkeypatch, tmp_path) ->
     Prior to #742 the log path was hardcoded to ``~/.basic-memory/``, which
     split state across instances when users set BASIC_MEMORY_CONFIG_DIR to
     isolate config and the database elsewhere.
+
+    Asserts on the log *directory* rather than the exact filename because
+    Windows uses a per-process ``basic-memory-<pid>.log`` while POSIX
+    shares a single ``basic-memory.log``. The thing this regression guard
+    cares about is that the log lives under the redirected config dir,
+    not at ``Path.home() / ".basic-memory"``. Patching ``utils.os.name``
+    to force one branch would break ``Path(str)`` dispatch on the other
+    platform, so we stay platform-agnostic.
     """
     added_sinks: list[str] = []
 
     custom_dir = tmp_path / "instance-x" / "state"
     monkeypatch.setenv("BASIC_MEMORY_ENV", "dev")
     monkeypatch.setenv("BASIC_MEMORY_CONFIG_DIR", str(custom_dir))
-    monkeypatch.setattr(utils.os, "name", "posix")
     monkeypatch.setattr(utils.logger, "remove", lambda *args, **kwargs: None)
     monkeypatch.setattr(
         utils.logger,
@@ -109,7 +117,11 @@ def test_setup_logging_honors_basic_memory_config_dir(monkeypatch, tmp_path) ->
 
     utils.setup_logging(log_to_file=True)
 
-    assert added_sinks == [str(custom_dir / "basic-memory.log")]
+    assert len(added_sinks) == 1
+    log_path = Path(added_sinks[0])
+    assert log_path.parent == custom_dir
+    assert log_path.name.startswith("basic-memory")
+    assert log_path.suffix == ".log"
 
 
 def test_setup_logging_test_env_uses_stderr_only(monkeypatch) -> None: