diff --git a/infra/examples/junos-commit-check/checks.yaml b/infra/examples/junos-commit-check/checks.yaml index 2f9447a..ad035c4 100644 --- a/infra/examples/junos-commit-check/checks.yaml +++ b/infra/examples/junos-commit-check/checks.yaml @@ -84,13 +84,15 @@ checks: - type: commit_check_rejects node: dut config_lines: - - "set policy-options condition TEST if-route-exists 192.168.1.111/24 table inet.0" + - "set policy-options condition TEST if-route-exists 192.168.1.111/24" + - "set policy-options condition TEST if-route-exists table inet.0" description: "condition if-route-exists with host bits set" - type: commit_check_accepts node: dut config_lines: - - "set policy-options condition TEST if-route-exists 192.168.1.0/24 table inet.0" + - "set policy-options condition TEST if-route-exists 192.168.1.0/24" + - "set policy-options condition TEST if-route-exists table inet.0" description: "condition if-route-exists with valid prefix" # --- Contexts where Junos ACCEPTS host bits --- diff --git a/snapshots/junos_commit_check/configs/rejects-condition/show_configuration_|_display_set.txt b/snapshots/junos_commit_check/configs/rejects-condition/show_configuration_|_display_set.txt index c738594..bdbd604 100644 --- a/snapshots/junos_commit_check/configs/rejects-condition/show_configuration_|_display_set.txt +++ b/snapshots/junos_commit_check/configs/rejects-condition/show_configuration_|_display_set.txt @@ -1,2 +1,3 @@ set system host-name rejects-condition -set policy-options condition TEST if-route-exists 192.168.1.111/24 table inet.0 +set policy-options condition TEST if-route-exists 192.168.1.111/24 +set policy-options condition TEST if-route-exists table inet.0 diff --git a/snapshots/junos_commit_check/validation/sickbay.yaml b/snapshots/junos_commit_check/validation/sickbay.yaml index 0471b15..521b0d0 100644 --- a/snapshots/junos_commit_check/validation/sickbay.yaml +++ b/snapshots/junos_commit_check/validation/sickbay.yaml @@ -26,32 +26,3 @@ entries: skip: skip_type: dont_run reason: "commit check lab: configs are parse-warning test fixtures, not full devices" - # parse_warnings: Batfish does not yet flag unnormalized prefixes in these contexts - - hostname: rejects-static - test_name: test_parse_warnings - skip: - reason: "Batfish does not yet flag unnormalized static route prefixes (batfish/batfish#9928)" - - hostname: rejects-aggregate - test_name: test_parse_warnings - skip: - reason: "Batfish does not yet flag unnormalized aggregate route prefixes (batfish/batfish#9928)" - - hostname: rejects-generate - test_name: test_parse_warnings - skip: - reason: "Batfish does not yet flag unnormalized generate route prefixes (batfish/batfish#9928)" - - hostname: rejects-ospf-area-range - test_name: test_parse_warnings - skip: - reason: "Batfish does not yet flag unnormalized OSPF area-range prefixes (batfish/batfish#9928)" - - hostname: rejects-firewall-address - test_name: test_parse_warnings - skip: - reason: "Batfish does not yet flag unnormalized firewall address prefixes (batfish/batfish#9928)" - - hostname: rejects-firewall-next-ip - test_name: test_parse_warnings - skip: - reason: "Batfish does not yet flag unnormalized firewall next-ip prefixes (batfish/batfish#9928)" - - hostname: rejects-condition - test_name: test_parse_warnings - skip: - reason: "Batfish does not yet flag unnormalized condition if-route-exists prefixes (batfish/batfish#9928)"