Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .prompts/upgrade-from-citypaul-dotfiles.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ The `/setup` command generates the hook with only the branches relevant to the d

**What they have:** A systematic CI/CD failure diagnosis skill with hypothesis-first approach, environment delta analysis, and anti-patterns (no blind retries).

**Why it matters:** CI failures are a common pain point. We have a devops-sre-engineer agent but no specific skill for diagnosing CI failures methodically. This would prevent the common anti-pattern of "just re-run it."
**Why it matters:** CI failures are a common pain point. We have a ops-engineer agent but no specific skill for diagnosing CI failures methodically. This would prevent the common anti-pattern of "just re-run it."

**Action:** Create `skills/ci-debugging.md` covering:
- Hypothesis-first diagnosis
Expand All @@ -145,7 +145,7 @@ The `/setup` command generates the hook with only the branches relevant to the d
- Network and filesystem differences
- Local reproduction steps
- Anti-patterns: blind retries, adding retries to "flaky" tests, speculative fix pushes
- Integration with devops-sre-engineer agent
- Integration with ops-engineer agent

### 9. Add a `test-design-reviewer` skill

Expand Down
4 changes: 2 additions & 2 deletions GETTING-STARTED.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Bug fixes typically need only the Software Engineer. The QA Engineer loads after
/architect Review the current service topology for scalability concerns
```

The Architect may pull in the Security Engineer or DevOps/SRE Engineer for cross-cutting concerns.
The Architect may pull in the Security Engineer or Ops Engineer for cross-cutting concerns.

### API Design

Expand All @@ -87,7 +87,7 @@ The Architect may pull in the Security Engineer or DevOps/SRE Engineer for cross
### Pipeline and Deployment

```
/devops-sre-engineer Design the CI/CD pipeline for the new microservice
/ops-engineer Design the CI/CD pipeline for the new microservice
```

## Available Agents and Skills
Expand Down
18 changes: 15 additions & 3 deletions docs/agent_info.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Each team agent file in `agents/` specifies a role's persona, behavior, collabor
| Product Manager | [`product-manager.md`](../plugins/agentic-dev-team/agents/product-manager.md) | Requirements clarification, prioritization, stakeholder alignment |
| Technical Writer | [`tech-writer.md`](../plugins/agentic-dev-team/agents/tech-writer.md) | Documentation, terminology consistency, style enforcement |
| Security Engineer | [`security-engineer.md`](../plugins/agentic-dev-team/agents/security-engineer.md) | Security analysis, threat modeling, compliance |
| DevOps/SRE Engineer | [`devops-sre-engineer.md`](../plugins/agentic-dev-team/agents/devops-sre-engineer.md) | Pipeline, deployment, reliability, observability |
| Ops Engineer | [`ops-engineer.md`](../plugins/agentic-dev-team/agents/ops-engineer.md) | Pipeline, deployment, reliability, observability |
| ADR Author | [`adr.md`](../plugins/agentic-dev-team/agents/adr.md) | Creates and manages Architecture Decision Records |

## Review Agents
Expand Down Expand Up @@ -48,9 +48,21 @@ Review agents run as sub-agents during Phase 3 inline checkpoints and full `/cod

To add a new review agent, use `/agent-add`. See [Add a Review Agent](#add-a-review-agent) below.

## Plan Review Personas
## Prompt Templates

Plan review personas are subagent prompt templates that critically challenge implementation plans during Phase 2, before the human gate. They run **in parallel** and return structured verdicts. Unlike review agents (which check code), these check the plan itself.
Prompt templates in `prompts/` are subagent dispatches used by the Orchestrator at various pipeline phases. They are never invoked directly by the user.

### Implementation & Review Dispatch

| Template | File | Purpose |
| --- | --- | --- |
| Implementer | [`implementer.md`](../plugins/agentic-dev-team/prompts/implementer.md) | Phase 3 implementation dispatch with TDD and status protocol |
| Spec Reviewer | [`spec-reviewer.md`](../plugins/agentic-dev-team/prompts/spec-reviewer.md) | Stage 1 spec compliance review with status protocol |
| Quality Reviewer | [`quality-reviewer.md`](../plugins/agentic-dev-team/prompts/quality-reviewer.md) | Stage 2 dispatcher that selects review agents by what changed |

### Plan Review Personas

Plan review personas critically challenge implementation plans during Phase 2, before the human gate. They run **in parallel** and return structured verdicts. Unlike review agents (which check code), these check the plan itself.

| Persona | File | Focus |
| --- | --- | --- |
Expand Down
22 changes: 15 additions & 7 deletions docs/diagrams/team-agents.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 5 additions & 2 deletions docs/skills.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Used by all agents to ensure output correctness:
| --- | --- | --- |
| Quality Gate Pipeline | [`quality-gate-pipeline.md`](../plugins/agentic-dev-team/skills/quality-gate-pipeline/SKILL.md) | Unified quality gate: self-validation, verification evidence, review-correction loops |
| Governance & Compliance | [`governance-compliance.md`](../plugins/agentic-dev-team/skills/governance-compliance/SKILL.md) | Audit trail, quality assurance layers, ethics principles |
| Static Analysis Integration | [`static-analysis-integration/SKILL.md`](../plugins/agentic-dev-team/skills/static-analysis-integration/SKILL.md) | Pre-pass stage for /code-review that runs available static analysis tools before dispatching AI agents |

### Development Discipline Skills

Expand All @@ -44,6 +45,7 @@ Enforce rigorous development practices:
| Test Design Reviewer | [`test-design-reviewer.md`](../plugins/agentic-dev-team/skills/test-design-reviewer/SKILL.md) | Test quality patterns and anti-patterns |
| Browser Testing | [`browser-testing.md`](../plugins/agentic-dev-team/skills/browser-testing/SKILL.md) | Playwright-based browser QA for visual verification |
| Feature File Validation | [`feature-file-validation.md`](../plugins/agentic-dev-team/skills/feature-file-validation/SKILL.md) | Gherkin quality, determinism, implementation independence, test automation coverage |
| Receiving Code Review | [`receiving-code-review/SKILL.md`](../plugins/agentic-dev-team/skills/receiving-code-review/SKILL.md) | Behavioral constraints for review reception: verification gates, YAGNI check, anti-performative-agreement |

### Research & Design Skills

Expand All @@ -54,6 +56,7 @@ Used during the Research phase to explore alternatives and stress-test designs:
| Competitive Analysis | [`competitive-analysis.md`](../plugins/agentic-dev-team/skills/competitive-analysis/SKILL.md) | Gap analysis against external tools, plugins, or feature sets |
| Design Interrogation | [`design-interrogation.md`](../plugins/agentic-dev-team/skills/design-interrogation/SKILL.md) | Stress-test design decisions before planning |
| Design It Twice | [`design-it-twice.md`](../plugins/agentic-dev-team/skills/design-it-twice/SKILL.md) | Generate parallel alternative interfaces via sub-agents |
| Domain Analysis | [`domain-analysis/SKILL.md`](../plugins/agentic-dev-team/skills/domain-analysis/SKILL.md) | Strategic DDD health assessment: bounded contexts, event flows, value stream, friction report |

### Technical Skills

Expand All @@ -70,6 +73,7 @@ Domain knowledge for implementation work:
| Docker Image Create | [`docker-image-create/SKILL.md`](../plugins/agentic-dev-team/skills/docker-image-create/SKILL.md) | Generate production Dockerfiles with multi-stage builds, slim/distroless bases |
| Docker Image Audit | [`docker-image-audit/SKILL.md`](../plugins/agentic-dev-team/skills/docker-image-audit/SKILL.md) | Audit Dockerfiles and images with hadolint, Trivy, Grype; structured severity report |
| Performance Benchmark | [`performance-benchmark/SKILL.md`](../plugins/agentic-dev-team/skills/performance-benchmark/SKILL.md) | Runtime performance measurement: Core Web Vitals, resource sizes, baseline comparison, performance budgets, trend tracking |
| JS Project Init | [`js-project-init/README.md`](../plugins/agentic-dev-team/skills/js-project-init/README.md) | Initialize JS project with ES modules, prettier, eslint, vitest, editorconfig |

### Subagent Prompt Templates

Expand All @@ -79,8 +83,7 @@ Concrete templates in `prompts/` for reproducible subagent dispatch:
| --- | --- | --- |
| Implementer | [`implementer.md`](../plugins/agentic-dev-team/prompts/implementer.md) | Phase 3 implementation dispatch with TDD enforcement |
| Spec Reviewer | [`spec-reviewer.md`](../plugins/agentic-dev-team/prompts/spec-reviewer.md) | Two-stage review gate 1: does code match spec? |
| Quality Reviewer | [`quality-reviewer.md`](../plugins/agentic-dev-team/prompts/quality-reviewer.md) | Two-stage review gate 2: is code high quality? |
| Plan Reviewer | [`plan-reviewer.md`](../plugins/agentic-dev-team/prompts/plan-reviewer.md) | Phase 2 automated pre-check before human review |
| Quality Reviewer | [`quality-reviewer.md`](../plugins/agentic-dev-team/prompts/quality-reviewer.md) | Stage 2 dispatcher: selects and runs specialized review agents based on what changed |
| Plan Review — Acceptance | [`plan-review-acceptance.md`](../plugins/agentic-dev-team/prompts/plan-review-acceptance.md) | Criteria verifiability, scenario completeness, error paths, TDD traceability |
| Plan Review — Design | [`plan-review-design.md`](../plugins/agentic-dev-team/prompts/plan-review-design.md) | Coupling, abstraction quality, structural risks, pattern consistency |
| Plan Review — UX | [`plan-review-ux.md`](../plugins/agentic-dev-team/prompts/plan-review-ux.md) | User journey, error experience, cognitive load, accessibility |
Expand Down
Loading