Fixed prop binding issue with direct-autoprop optimization interference

bfiete · bfiete · commit 59d4e258d5dd · 2021-02-21T06:25:27.000-08:00
diff --git a/IDEHelper/Compiler/BfExprEvaluator.cpp b/IDEHelper/Compiler/BfExprEvaluator.cpp
@@ -4635,6 +4635,8 @@ BfTypedValue BfExprEvaluator::LookupField(BfAstNode* targetSrc, BfTypedValue tar
 
 				bool doAccessCheck = true;
 
+				if ((flags & BfLookupFieldFlag_BindOnly) != 0)
+					doAccessCheck = false;
 				if ((mModule->mAttributeState != NULL) && (mModule->mAttributeState->mCustomAttributes != NULL) && (mModule->mAttributeState->mCustomAttributes->Contains(mModule->mCompiler->mDisableObjectAccessChecksAttributeTypeDef)))
 					doAccessCheck = false;
 
@@ -4861,7 +4863,7 @@ BfTypedValue BfExprEvaluator::LookupField(BfAstNode* targetSrc, BfTypedValue tar
 					}
 
 					// Check for direct auto-property access
-					if (startCheckType == mModule->mCurTypeInstance)
+					if ((startCheckType == mModule->mCurTypeInstance) && ((flags & BfLookupFieldFlag_BindOnly) == 0))
 					{
 						if (auto propertyDeclaration = BfNodeDynCast<BfPropertyDeclaration>(mPropDef->mFieldDeclaration))
 						{

Original file line number	Diff line number	Diff line change
`@@ -4635,6 +4635,8 @@ BfTypedValue BfExprEvaluator::LookupField(BfAstNode* targetSrc, BfTypedValue tar`
`4635`	`4635`
`4636`	`4636`	`bool doAccessCheck = true;`
`4637`	`4637`
	`4638`	`+ if ((flags & BfLookupFieldFlag_BindOnly) != 0)`
	`4639`	`+ doAccessCheck = false;`
`4638`	`4640`	`if ((mModule->mAttributeState != NULL) && (mModule->mAttributeState->mCustomAttributes != NULL) && (mModule->mAttributeState->mCustomAttributes->Contains(mModule->mCompiler->mDisableObjectAccessChecksAttributeTypeDef)))`
`4639`	`4641`	`doAccessCheck = false;`
`4640`	`4642`
`@@ -4861,7 +4863,7 @@ BfTypedValue BfExprEvaluator::LookupField(BfAstNode* targetSrc, BfTypedValue tar`
`4861`	`4863`	`}`
`4862`	`4864`
`4863`	`4865`	`// Check for direct auto-property access`
`4864`		`- if (startCheckType == mModule->mCurTypeInstance)`
	`4866`	`+ if ((startCheckType == mModule->mCurTypeInstance) && ((flags & BfLookupFieldFlag_BindOnly) == 0))`
`4865`	`4867`	`{`
`4866`	`4868`	`if (auto propertyDeclaration = BfNodeDynCast<BfPropertyDeclaration>(mPropDef->mFieldDeclaration))`
`4867`	`4869`	`{`