`FeathersNumberInput` doesn't work when spawned in the `Update` schedule

[nic96]

Bevy version and features

• 0.19.0-rc.1
• features bevy_feathers

What you did

Spawned FeathersNumberInput in Update schedule.

fn spawn_number_input(mut commands: Commands, mut is_spawned: Local<bool>) {
    if *is_spawned { return; }
    *is_spawned = true;
    commands.spawn_scene(bsn! { :FeathersNumberInput Node { width: px(200) } });
}

What went wrong

If I run the system in First it works properly but if I run it in PreUpdate, Update, or PostUpdate it doesn't work. The ValueChange events are firing when I type in the input but no text ever gets rendered in the input.

[amtep]

I've made some small amount of progress in debugging this.

I added some logs to update_editable_text_layout.

        if layout_changed || hinting.is_changed() {
            let layout = driver.layout();
            info!("layout {:?}", layout.get(0).unwrap().text_range());

This prints the range covered by the glyphs of the first line in the field (which should be the only line).

With the field spawned in First: text range starts at 0..1, then 0..1 after the first digit typed, then 0..2, 0..3, etc.

With the field spawned in Update: text range starts at 0..0, then 1..1 after the first digit typed, then 2..2, 3..3 etc.

I'm digging deeper but I figured I'd share this.

[ickshonpe]

This breaks all the text inputs. The problem is that when FontSource resolution fails because an asset isn't yet loaded, it doesn't attempt to resolve the FontSource again the next frame.

update_editable_text_styles needs to either flag the inputs that fail and try again next time, or reresolve all the fontsources on changes to the font assets.