Skip to content

Commit 302e0b4

Browse files
dimasno1Dzmitry Paplauski
dimasno1
and
Dzmitry Paplauski
authored
add missing banner methods implementations, set bridge methods private modifier (#12)
Co-authored-by: Dzmitry Paplauski <dzmitry@MacBook-Pro-Dzmitry.local>
1 parent 542d442 commit 302e0b4

6 files changed

Lines changed: 43 additions & 25 deletions

File tree

‎Assets/BidMachine/Platforms/IOS/ADs/Banner/BannerRequestiOSUnityBridge.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@ namespace BidMachineAds.Unity.iOS {
99
public class BannerRequestiOSUnityBridge : MonoBehaviour, IiOSAdRequestBridge
1010
{
1111
[DllImport("__Internal")]
12-
public static extern IntPtr BidMachineBannerGetAuctionResultUnmanagedPointer();
12+
private static extern IntPtr BidMachineBannerGetAuctionResultUnmanagedPointer();
1313

1414
[DllImport("__Internal")]
15-
public static extern bool BidMachineBannerIsExpired();
15+
private static extern bool BidMachineBannerIsExpired();
1616

1717
[DllImport("__Internal")]
18-
public static extern bool BidMachineBannerIsDestroyed();
18+
private static extern bool BidMachineBannerIsDestroyed();
1919

2020
[DllImport("__Internal")]
21-
public static extern int BidMachineBannerGetSize();
21+
private static extern int BidMachineBannerGetSize();
2222

2323
public string GetAuctionResult()
2424
{

‎Assets/BidMachine/Platforms/IOS/ADs/Interstitial/InterstitialRequestiOSUnityBridge.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ namespace BidMachineAds.Unity.iOS {
77
public class InterstitialRequestiOSUnityBridge : MonoBehaviour, IiOSAdRequestBridge
88
{
99
[DllImport("__Internal")]
10-
public static extern IntPtr BidMachineInterstitialGetAuctionResultUnmanagedPointer();
10+
private static extern IntPtr BidMachineInterstitialGetAuctionResultUnmanagedPointer();
1111

1212
[DllImport("__Internal")]
13-
public static extern bool BidMachineInterstitialIsExpired();
13+
private static extern bool BidMachineInterstitialIsExpired();
1414

1515
[DllImport("__Internal")]
16-
public static extern bool BidMachineInterstitialIsDestroyed();
16+
private static extern bool BidMachineInterstitialIsDestroyed();
1717

1818
public string GetAuctionResult()
1919
{

‎Assets/BidMachine/Platforms/IOS/ADs/Rewarded/RewardedRequestiOSUnityBridge.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ namespace BidMachineAds.Unity.iOS {
77
public class RewardedRequestiOSUnityBridge : MonoBehaviour, IiOSAdRequestBridge
88
{
99
[DllImport("__Internal")]
10-
public static extern IntPtr BidMachineRewardedGetAuctionResultUnmanagedPointer();
10+
private static extern IntPtr BidMachineRewardedGetAuctionResultUnmanagedPointer();
1111

1212
[DllImport("__Internal")]
13-
public static extern bool BidMachineRewardedIsExpired();
13+
private static extern bool BidMachineRewardedIsExpired();
1414

1515
[DllImport("__Internal")]
16-
public static extern bool BidMachineRewardedIsDestroyed();
16+
private static extern bool BidMachineRewardedIsDestroyed();
1717

1818
public string GetAuctionResult()
1919
{

‎Assets/BidMachine/Platforms/IOS/BidMachineiOSUnityBridge.cs‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,40 +5,40 @@
55
public class BidMachineiOSUnityBridge : MonoBehaviour
66
{
77
[DllImport("__Internal")]
8-
public static extern void BidMachineInitialize(string sellerId);
8+
private static extern void BidMachineInitialize(string sellerId);
99

1010
[DllImport("__Internal")]
11-
public static extern bool BidMachineIsInitialized();
11+
private static extern bool BidMachineIsInitialized();
1212

1313
[DllImport("__Internal")]
14-
public static extern void BidMachineSetEndpoint(string url);
14+
private static extern void BidMachineSetEndpoint(string url);
1515

1616
[DllImport("__Internal")]
17-
public static extern void BidMachineSetLoggingEnabled(bool logging);
17+
private static extern void BidMachineSetLoggingEnabled(bool logging);
1818

1919
[DllImport("__Internal")]
20-
public static extern void BidMachineSetTestEnabled(bool test);
20+
private static extern void BidMachineSetTestEnabled(bool test);
2121

2222
[DllImport("__Internal")]
23-
public static extern void BidMachineSetTargetingParams(string jsonString);
23+
private static extern void BidMachineSetTargetingParams(string jsonString);
2424

2525
[DllImport("__Internal")]
26-
public static extern void BidMachineSetConsentConfig(string consentConfig, bool consent);
26+
private static extern void BidMachineSetConsentConfig(string consentConfig, bool consent);
2727

2828
[DllImport("__Internal")]
29-
public static extern void BidMachineSetSubjectToGDPR(bool flag);
29+
private static extern void BidMachineSetSubjectToGDPR(bool flag);
3030

3131
[DllImport("__Internal")]
32-
public static extern void BidMachineSetCoppa(bool coppa);
32+
private static extern void BidMachineSetCoppa(bool coppa);
3333

3434
[DllImport("__Internal")]
35-
public static extern void BidMachineSetUSPrivacyString(string usPrivacyString);
35+
private static extern void BidMachineSetUSPrivacyString(string usPrivacyString);
3636

3737
[DllImport("__Internal")]
38-
public static extern void BidMachineSetGPP(string gppString, int[] gppIds, int length);
38+
private static extern void BidMachineSetGPP(string gppString, int[] gppIds, int length);
3939

4040
[DllImport("__Internal")]
41-
public static extern void BidMachineSetPublisher(string jsonString);
41+
private static extern void BidMachineSetPublisher(string jsonString);
4242

4343
public void Initialize(string sellerId)
4444
{

‎Assets/BidMachine/Platforms/IOS/Error/iOSErrorBridge.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ namespace BidMachineAds.Unity.iOS
77
public class iOSErrorBridge
88
{
99
[DllImport("__Internal")]
10-
public static extern int BidMachineGetErrorCode(IntPtr error);
10+
private static extern int BidMachineGetErrorCode(IntPtr error);
1111

1212
[DllImport("__Internal")]
13-
public static extern IntPtr BidMachineGetErrorMessageUnmanagedPointer(IntPtr error);
13+
private static extern IntPtr BidMachineGetErrorMessageUnmanagedPointer(IntPtr error);
1414

1515
[DllImport("__Internal")]
16-
public static extern IntPtr BidMachineGetErrorBriefUnmanagedPointer(IntPtr error);
16+
private static extern IntPtr BidMachineGetErrorBriefUnmanagedPointer(IntPtr error);
1717

1818
public static int GetErrorCode(IntPtr error)
1919
{

‎Assets/Plugins/iOS/Ads/Banner/BidMachine+BannerAPI.swift‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,24 @@ public func setBannerRequestCallbacks(
165165
)
166166
}
167167

168+
// MARK: - Request
169+
170+
@_cdecl("BidMachineBannerIsDestroyed")
171+
public func bannerIsDestroyed() -> Bool {
172+
iOSUnityBridge.bannerBridge.isDestroyed
173+
}
174+
175+
@_cdecl("BidMachineBannerIsExpired")
176+
public func bannerIsExpired() -> Bool {
177+
iOSUnityBridge.bannerBridge.isExpired
178+
}
179+
180+
@_cdecl("BidMachineBannerGetAuctionResultUnmanagedPointer")
181+
public func bannerAuctionResult() -> UnsafeMutablePointer<CChar>? {
182+
let result = iOSUnityBridge.bannerBridge.auctionResult ?? "unknown"
183+
return result.utf8UnmanagedPtrCopy
184+
}
185+
168186
private extension BannerAdBridge.BannerSize {
169187
var placementFormat: PlacementFormat {
170188
switch self {

0 commit comments

Comments
 (0)