Get out of subject_prefix business

Author: Neeraj Singh

README.md

@@ -7,15 +7,13 @@ non-production environment. However it also provides ability to not
 intercept certain emails so that testing of emails is easier in
 development/staging environment.
 
-If `subject_prefix` is supplied then that is added to every single email
-in both production and non-production environment.
-
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'mail_interceptor'
+# There is no need to include this gem for production or for test environment
+gem 'mail_interceptor', group: [:development, :staging]
 ```
 
 ## Usage
@@ -24,8 +22,7 @@ gem 'mail_interceptor'
 # config/initializer/mail_interceptor.rb
 
 options = { forward_emails_to: 'intercepted_emails@domain.com',
-            deliver_emails_to: ["@wheel.com"],
-            subject_prefix: 'WHEEL' }
+            deliver_emails_to: ["@wheel.com"] }
 
 interceptor = MailInterceptor::Interceptor.new(options)
 unless Rails.env.test?
@@ -64,17 +61,6 @@ will be intercepted and forwarded.
 The regular expression is matched without case sensitive. So you can mix lowercase
 and uppercase and it won't matter.
 
-### subject_prefix
-
-__subject_prefix__ is optional. If it is supplied then it is added to
-the front of the subject. In non-production environment the environment
-name is also added.
-
-```
-[WHEEL] Forgot password
-[WHEEL STAGING] Forgot password
-```
-
 ### forward_emails_to
 
 This is a required field.

lib/mail_interceptor.rb

@@ -4,19 +4,17 @@
 
 module MailInterceptor
   class Interceptor
-    attr_accessor :deliver_emails_to, :forward_emails_to, :subject_prefix, :env
+    attr_accessor :deliver_emails_to, :forward_emails_to, :env
 
     def initialize options = {}
       @deliver_emails_to = Array.wrap options[:deliver_emails_to]
-      @subject_prefix    = options[:subject_prefix] || ''
       @forward_emails_to = options.fetch :forward_emails_to
       @env               = options.fetch :env, InterceptorEnv.new
 
       sanitize_forward_emails_to
     end
 
     def delivering_email message
-      add_subject_prefix message
       message.to = normalize_recipients(message.to).flatten.uniq
     end
 
@@ -36,13 +34,6 @@ def normalize_recipients recipients
       end
     end
 
-    def add_subject_prefix message
-      return if subject_prefix.blank?
-
-      modified_subject_prefix = add_env_info_to_subject_prefix
-      message.subject = "#{modified_subject_prefix} #{message.subject}"
-    end
-
     def sanitize_forward_emails_to
       self.forward_emails_to = Array.wrap forward_emails_to
 
@@ -51,10 +42,6 @@ def sanitize_forward_emails_to
       end
     end
 
-    def add_env_info_to_subject_prefix
-      "[#{subject_prefix} #{env.name}]"
-    end
-
     def forward_emails_to_empty?
       Array.wrap(forward_emails_to).reject(&:blank?).empty?
     end

test/mail_interceptor_test.rb

@@ -36,53 +36,26 @@ def test_invocation_of_regular_expression
     assert_equal ["a@wheel.com", "b@wheel.com", "c@pump.com", "test@example.com", "john@gmail.com"], @message.to
   end
 
-  def test_no_subject_prefix_in_test
-    interceptor = ::MailInterceptor::Interceptor.new env: env,
-                                                     forward_emails_to: 'test@example.com',
-                                                     subject_prefix: nil
-    @message.subject = 'Forgot password'
-
-    interceptor.delivering_email @message
-    assert_equal "Forgot password", @message.subject
-  end
-
-  def test_subject_prefix_in_test
-    interceptor = ::MailInterceptor::Interceptor.new env: env,
-                                                     forward_emails_to: 'test@example.com',
-                                                     subject_prefix: 'wheel'
-    @message.subject = 'Forgot password'
-
-    interceptor.delivering_email @message
-    assert_equal "[wheel TEST] Forgot password", @message.subject
-
-    @message.subject = 'Another Forgot password'
-    interceptor.delivering_email @message
-    assert_equal "[wheel TEST] Another Forgot password", @message.subject
-  end
-
   def test_error_if_forward_emails_to_is_empty
     message = "forward_emails_to should not be empty"
 
     exception = assert_raises(RuntimeError) do
       ::MailInterceptor::Interceptor.new env: env,
-                                         forward_emails_to: '',
-                                         subject_prefix: 'wheel'
+                                         forward_emails_to: ''
     end
 
     assert_equal message, exception.message
 
     exception =  assert_raises(RuntimeError) do
       ::MailInterceptor::Interceptor.new env: env,
-                                         forward_emails_to: [],
-                                         subject_prefix: 'wheel'
+                                         forward_emails_to: []
     end
 
     assert_equal message, exception.message
 
     exception =  assert_raises(RuntimeError) do
       ::MailInterceptor::Interceptor.new env: env,
-                                         forward_emails_to: [''],
-                                         subject_prefix: 'wheel'
+                                         forward_emails_to: ['']
     end
 
     assert_equal message, exception.message