braces around all if statements. removed unnecessary isset checks

Author: bc-bfenton

src/Bigcommerce/Api/Client.php

@@ -226,7 +226,9 @@ public static function getCount($path)
     {
         $response = self::connection()->get(self::$api_path . $path);
 
-        if ($response == false || is_string($response)) return $response;
+        if ($response == false || is_string($response)) {
+            return $response;
+        }
 
         return $response->count;
     }
@@ -240,7 +242,9 @@ public static function getCount($path)
      */
     public static function createResource($path, $object)
     {
-        if (is_array($object)) $object = (object)$object;
+        if (is_array($object)) {
+            $object = (object)$object;
+        }
 
         return self::connection()->post(self::$api_path . $path, $object);
     }
@@ -254,7 +258,9 @@ public static function createResource($path, $object)
      */
     public static function updateResource($path, $object)
     {
-        if (is_array($object)) $object = (object)$object;
+        if (is_array($object)) {
+            $object = (object)$object;
+        }
 
         return self::connection()->put(self::$api_path . $path, $object);
     }
@@ -279,7 +285,9 @@ public static function deleteResource($path)
      */
     private static function mapCollection($resource, $object)
     {
-        if ($object == false || is_string($object)) return $object;
+        if ($object == false || is_string($object)) {
+            return $object;
+        }
 
         $baseResource = __NAMESPACE__ . '\\' . $resource;
         self::$resource = (class_exists($baseResource)) ? $baseResource : 'Bigcommerce\\Api\\Resources\\' . $resource;
@@ -309,7 +317,9 @@ private static function mapCollectionObject($object)
      */
     private static function mapResource($resource, $object)
     {
-        if ($object == false || is_string($object)) return $object;
+        if ($object == false || is_string($object)) {
+            return $object;
+        }
 
         $baseResource = __NAMESPACE__ . '\\' . $resource;
         $class = (class_exists($baseResource)) ? $baseResource : 'Bigcommerce\\Api\\Resources\\' . $resource;
@@ -325,7 +335,9 @@ private static function mapResource($resource, $object)
      */
     private static function mapCount($object)
     {
-        if ($object == false || is_string($object)) return $object;
+        if ($object == false || is_string($object)) {
+            return $object;
+        }
 
         return $object->count;
     }
@@ -339,7 +351,9 @@ public static function getTime()
     {
         $response = self::connection()->get(self::$api_path . '/time');
 
-        if ($response == false || is_string($response)) return $response;
+        if ($response == false || is_string($response)) {
+            return $response;
+        }
 
         return new \DateTime("@{$response->time}");
     }
@@ -1152,7 +1166,9 @@ public static function getRequestsRemaining()
         if (!$limit) {
             $result = self::getTime();
 
-            if (!$result) return false;
+            if (!$result) {
+                return false;
+            }
 
             $limit = self::connection()->getHeader('X-BC-ApiLimit-Remaining');
         }

src/Bigcommerce/Api/Connection.php

@@ -270,9 +270,7 @@ private function followRedirectPath()
         $this->redirectsFollowed++;
 
         if ($this->getStatus() == 301 || $this->getStatus() == 302) {
-
             if ($this->redirectsFollowed < $this->maxRedirects) {
-
                 $location = $this->getHeader('Location');
                 $forwardTo = parse_url($location);
 

src/Bigcommerce/Api/NetworkError.php

@@ -7,5 +7,4 @@
  */
 class NetworkError extends Error
 {
-
-}
+}

src/Bigcommerce/Api/Resource.php

@@ -71,7 +71,7 @@ public function getCreateFields()
         $resource = $this->fields;
 
         foreach ($this->ignoreOnCreate as $field) {
-            if (isset($resource->$field)) unset($resource->$field);
+            unset($resource->$field);
         }
 
         return $resource;
@@ -82,23 +82,31 @@ public function getUpdateFields()
         $resource = $this->fields;
 
         foreach ($this->ignoreOnUpdate as $field) {
-            if (isset($resource->$field)) unset($resource->$field);
+            unset($resource->$field);
         }
 
         foreach ($resource as $field => $value) {
-            if ($this->isIgnoredField($field, $value)) unset($resource->$field);
+            if ($this->isIgnoredField($field, $value)) {
+                unset($resource->$field);
+            }
         }
 
         return $resource;
     }
 
     private function isIgnoredField($field, $value)
     {
-        if ($value === null) return true;
+        if ($value === null) {
+            return true;
+        }
 
-        if ((strpos($field, "date") !== FALSE) && $value === "") return true;
+        if (strpos($field, "date") !== false && $value === "") {
+            return true;
+        }
 
-        if (in_array($field, $this->ignoreIfZero) && $value === 0) return true;
+        if (in_array($field, $this->ignoreIfZero, true) && $value === 0) {
+            return true;
+        }
 
         return false;
     }

src/Bigcommerce/Api/ServerError.php

@@ -7,5 +7,4 @@
  */
 class ServerError extends Error
 {
-
-}
+}