Skip to content

Commit 8481f52

Browse files
committed
🐛 fix: fix: remove duplicate pacman in command args and normalize CSS across DEs
Fix duplicate pacman invocation in home_page.py and mesa_page.py. BaseManager._run_pacman_command() already prepends "pacman" to the command, but four call sites also included "pacman" in the args list, resulting in "pkexec pacman pacman -S ..." which would fail. Remove the redundant "pacman" from args in: - home_page.py: recommended packages install (batch and single) - mesa_page.py: GPU package install and remove Also normalize CSS opacities and card backgrounds for consistent appearance across KDE Plasma and GNOME. The semi-transparent card backgrounds (alpha 0.60–0.85) allowed the desktop color to bleed through on Plasma, producing overly saturated tints compared to GNOME. CSS changes: - Card base background now uses opaque @card_bg_color - Kernel group and purpose card gradients end with solid @card_bg_color - Reduced accent color tint alphas in gradients and borders (~30-40%) - Lowered box-shadow intensities for softer appearance - Badge pill backgrounds reduced from 0.18 to 0.12
1 parent e591bfa commit 8481f52

6 files changed

Lines changed: 82 additions & 68 deletions

File tree

usr/share/big-driver-manager/assets/css/style.css

Lines changed: 78 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ searchentry:focus-visible, expander:focus-visible {
1212
.card {
1313
border-radius: 12px;
1414
border: 1px solid alpha(@borders, 0.18);
15-
background-color: alpha(@card_bg_color, 0.60);
15+
background-color: @card_bg_color;
1616
box-shadow: 0 1px 3px alpha(black, 0.04);
1717
transition: box-shadow 200ms ease;
1818
}
@@ -27,40 +27,40 @@ searchentry:focus-visible, expander:focus-visible {
2727
.intro-kernel {
2828
background-image: linear-gradient(
2929
to bottom right,
30-
alpha(#3584e4, 0.14),
31-
alpha(#1c71d8, 0.04)
30+
alpha(#3584e4, 0.08),
31+
alpha(#1c71d8, 0.02)
3232
);
33-
border: 1.5px solid alpha(#3584e4, 0.20);
33+
border: 1.5px solid alpha(#3584e4, 0.15);
3434
box-shadow:
35-
0 0 0 1px alpha(#3584e4, 0.06),
36-
0 4px 16px alpha(#3584e4, 0.12),
37-
0 1px 3px alpha(black, 0.06);
35+
0 0 0 1px alpha(#3584e4, 0.04),
36+
0 4px 16px alpha(#3584e4, 0.08),
37+
0 1px 3px alpha(black, 0.04);
3838
}
3939
.intro-kernel:hover {
40-
border-color: alpha(#3584e4, 0.35);
40+
border-color: alpha(#3584e4, 0.28);
4141
box-shadow:
42-
0 0 0 1px alpha(#3584e4, 0.10),
43-
0 8px 28px alpha(#3584e4, 0.18),
44-
0 2px 6px alpha(black, 0.08);
42+
0 0 0 1px alpha(#3584e4, 0.07),
43+
0 8px 28px alpha(#3584e4, 0.12),
44+
0 2px 6px alpha(black, 0.06);
4545
}
4646
.intro-drivers {
4747
background-image: linear-gradient(
4848
to bottom right,
49-
alpha(#26a269, 0.14),
50-
alpha(#1a8a55, 0.04)
49+
alpha(#26a269, 0.08),
50+
alpha(#1a8a55, 0.02)
5151
);
52-
border: 1.5px solid alpha(#26a269, 0.20);
52+
border: 1.5px solid alpha(#26a269, 0.15);
5353
box-shadow:
54-
0 0 0 1px alpha(#26a269, 0.06),
55-
0 4px 16px alpha(#26a269, 0.12),
56-
0 1px 3px alpha(black, 0.06);
54+
0 0 0 1px alpha(#26a269, 0.04),
55+
0 4px 16px alpha(#26a269, 0.08),
56+
0 1px 3px alpha(black, 0.04);
5757
}
5858
.intro-drivers:hover {
59-
border-color: alpha(#26a269, 0.35);
59+
border-color: alpha(#26a269, 0.28);
6060
box-shadow:
61-
0 0 0 1px alpha(#26a269, 0.10),
62-
0 8px 28px alpha(#26a269, 0.18),
63-
0 2px 6px alpha(black, 0.08);
61+
0 0 0 1px alpha(#26a269, 0.07),
62+
0 8px 28px alpha(#26a269, 0.12),
63+
0 2px 6px alpha(black, 0.06);
6464
}
6565
/* Separator accent line */
6666
.intro-sep { border-radius: 2px; }
@@ -89,11 +89,25 @@ searchentry:focus-visible, expander:focus-visible {
8989
border-radius: 4px;
9090
padding: 2px 8px;
9191
}
92-
.badge-box.success { background: alpha(@success_color, 0.18); }
93-
.badge-box.warning { background: alpha(@warning_color, 0.18); }
94-
.badge-box.accent { background: alpha(@accent_color, 0.18); }
95-
.badge-box.purple { background: alpha(#9141ac, 0.22); }
96-
.badge-box.danger { background: alpha(@error_color, 0.18); }
92+
.badge-box.success {
93+
background: alpha(@success_color, 0.12);
94+
}
95+
96+
.badge-box.warning {
97+
background: alpha(@warning_color, 0.12);
98+
}
99+
100+
.badge-box.accent {
101+
background: alpha(@accent_color, 0.12);
102+
}
103+
104+
.badge-box.purple {
105+
background: alpha(#9141ac, 0.14);
106+
}
107+
108+
.badge-box.danger {
109+
background: alpha(@error_color, 0.12);
110+
}
97111

98112
.badge {
99113
font-size: 0.8em;
@@ -121,24 +135,24 @@ searchentry:focus-visible, expander:focus-visible {
121135

122136
/* --- Purpose section cards ---------------------------------------- */
123137
.purpose-card-gaming {
124-
background: linear-gradient(160deg, alpha(@accent_color, 0.06), @card_bg_color);
125-
border-left: 3px solid alpha(@accent_color, 0.40);
138+
background: linear-gradient(160deg, alpha(@accent_color, 0.04), @card_bg_color);
139+
border-left: 3px solid alpha(@accent_color, 0.30);
126140
}
127141
.purpose-card-video {
128-
background: linear-gradient(160deg, alpha(@success_color, 0.06), @card_bg_color);
129-
border-left: 3px solid alpha(@success_color, 0.40);
142+
background: linear-gradient(160deg, alpha(@success_color, 0.04), @card_bg_color);
143+
border-left: 3px solid alpha(@success_color, 0.30);
130144
}
131145
.purpose-card-compute {
132-
background: linear-gradient(160deg, alpha(@warning_color, 0.06), @card_bg_color);
133-
border-left: 3px solid alpha(@warning_color, 0.40);
146+
background: linear-gradient(160deg, alpha(@warning_color, 0.04), @card_bg_color);
147+
border-left: 3px solid alpha(@warning_color, 0.30);
134148
}
135149
.purpose-card-nvidia {
136-
background: linear-gradient(160deg, alpha(#76b900, 0.06), @card_bg_color);
137-
border-left: 3px solid alpha(#76b900, 0.40);
150+
background: linear-gradient(160deg, alpha(#76b900, 0.04), @card_bg_color);
151+
border-left: 3px solid alpha(#76b900, 0.30);
138152
}
139153
.purpose-card-mesa {
140-
background: linear-gradient(160deg, alpha(@accent_color, 0.04), @card_bg_color);
141-
border-left: 3px solid alpha(@accent_color, 0.30);
154+
background: linear-gradient(160deg, alpha(@accent_color, 0.03), @card_bg_color);
155+
border-left: 3px solid alpha(@accent_color, 0.22);
142156
}
143157

144158
/* Package row inside purpose card */
@@ -147,21 +161,21 @@ searchentry:focus-visible, expander:focus-visible {
147161
margin-top: 4px;
148162
margin-bottom: 8px;
149163
border-radius: 8px;
150-
background: alpha(@window_fg_color, 0.05);
151-
border: 1px solid alpha(@borders, 0.08);
164+
background: alpha(@window_fg_color, 0.03);
165+
border: 1px solid alpha(@borders, 0.06);
152166
}
153167

154168
/* --- Recommendations card ----------------------------------------- */
155169
.purpose-card-recommend {
156170
padding: 0;
157-
background: linear-gradient(160deg, alpha(@accent_color, 0.06), alpha(@warning_color, 0.03), @card_bg_color);
158-
border-left: 3px solid alpha(@accent_color, 0.40);
171+
background: linear-gradient(160deg, alpha(@accent_color, 0.04), alpha(@warning_color, 0.02), @card_bg_color);
172+
border-left: 3px solid alpha(@accent_color, 0.30);
159173
}
160174

161175
.purpose-card-suggest {
162176
padding: 0;
163-
background: linear-gradient(160deg, alpha(@accent_color, 0.04), @card_bg_color);
164-
border-left: 3px solid alpha(@accent_color, 0.25);
177+
background: linear-gradient(160deg, alpha(@accent_color, 0.03), @card_bg_color);
178+
border-left: 3px solid alpha(@accent_color, 0.20);
165179
}
166180

167181
/* --- Kernel page -------------------------------------------------- */
@@ -172,30 +186,30 @@ searchentry:focus-visible, expander:focus-visible {
172186
border-radius: 16px;
173187
background-image: linear-gradient(
174188
to bottom right,
175-
alpha(#3584e4, 0.12),
176-
alpha(#1c71d8, 0.03)
189+
alpha(#3584e4, 0.07),
190+
alpha(#1c71d8, 0.02)
177191
);
178-
border: 1.5px solid alpha(#3584e4, 0.18);
192+
border: 1.5px solid alpha(#3584e4, 0.14);
179193
box-shadow:
180-
0 0 0 1px alpha(#3584e4, 0.05),
181-
0 4px 14px alpha(#3584e4, 0.10),
182-
0 1px 3px alpha(black, 0.05);
194+
0 0 0 1px alpha(#3584e4, 0.04),
195+
0 4px 14px alpha(#3584e4, 0.07),
196+
0 1px 3px alpha(black, 0.04);
183197
transition: box-shadow 250ms ease-in-out, border-color 250ms ease-in-out;
184198
}
185199
.kernel-running-card:hover {
186-
border-color: alpha(#3584e4, 0.30);
200+
border-color: alpha(#3584e4, 0.24);
187201
box-shadow:
188-
0 0 0 1px alpha(#3584e4, 0.08),
189-
0 6px 22px alpha(#3584e4, 0.14),
190-
0 2px 6px alpha(black, 0.06);
202+
0 0 0 1px alpha(#3584e4, 0.06),
203+
0 6px 22px alpha(#3584e4, 0.10),
204+
0 2px 6px alpha(black, 0.05);
191205
}
192206

193207
/* In-use pill badge */
194208
.in-use-pill {
195209
padding: 3px 12px;
196210
border-radius: 99px;
197-
background: linear-gradient(135deg, alpha(@success_color, 0.22), alpha(@success_color, 0.10));
198-
border: 1px solid alpha(@success_color, 0.25);
211+
background: linear-gradient(135deg, alpha(@success_color, 0.14), alpha(@success_color, 0.06));
212+
border: 1px solid alpha(@success_color, 0.18);
199213
color: @success_color;
200214
font-weight: 700;
201215
font-size: 0.85em;
@@ -205,34 +219,34 @@ searchentry:focus-visible, expander:focus-visible {
205219
.kernel-installed-card {
206220
padding: 0;
207221
border-radius: 14px;
208-
background: linear-gradient(160deg, alpha(@success_color, 0.04), alpha(@card_bg_color, 0.85));
209-
border-left: 3px solid alpha(@success_color, 0.28);
222+
background: linear-gradient(160deg, alpha(@success_color, 0.03), @card_bg_color);
223+
border-left: 3px solid alpha(@success_color, 0.22);
210224
}
211225

212226
/* Available group cards — by type */
213227
.kernel-group-lts {
214228
padding: 0;
215229
border-radius: 14px;
216-
background: linear-gradient(160deg, alpha(@success_color, 0.03), alpha(@card_bg_color, 0.85));
217-
border-left: 3px solid alpha(@success_color, 0.25);
230+
background: linear-gradient(160deg, alpha(@success_color, 0.02), @card_bg_color);
231+
border-left: 3px solid alpha(@success_color, 0.20);
218232
}
219233
.kernel-group-standard {
220234
padding: 0;
221235
border-radius: 14px;
222-
background: linear-gradient(160deg, alpha(@accent_color, 0.03), alpha(@card_bg_color, 0.85));
223-
border-left: 3px solid alpha(@accent_color, 0.22);
236+
background: linear-gradient(160deg, alpha(@accent_color, 0.02), @card_bg_color);
237+
border-left: 3px solid alpha(@accent_color, 0.18);
224238
}
225239
.kernel-group-xanmod {
226240
padding: 0;
227241
border-radius: 14px;
228-
background: linear-gradient(160deg, alpha(#9141ac, 0.04), alpha(@card_bg_color, 0.85));
229-
border-left: 3px solid alpha(#9141ac, 0.30);
242+
background: linear-gradient(160deg, alpha(#9141ac, 0.03), @card_bg_color);
243+
border-left: 3px solid alpha(#9141ac, 0.22);
230244
}
231245
.kernel-group-rt {
232246
padding: 0;
233247
border-radius: 14px;
234-
background: linear-gradient(160deg, alpha(@warning_color, 0.04), alpha(@card_bg_color, 0.85));
235-
border-left: 3px solid alpha(@warning_color, 0.30);
248+
background: linear-gradient(160deg, alpha(@warning_color, 0.03), @card_bg_color);
249+
border-left: 3px solid alpha(@warning_color, 0.22);
236250
}
237251

238252
/* Group header inside kernel group cards */
Binary file not shown.
Binary file not shown.
Binary file not shown.

usr/share/big-driver-manager/ui/home_page.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ def _on_rec_install_confirm(
645645
cancel_callback=self._mhwd_manager.cancel_operation,
646646
)
647647
self._mhwd_manager._run_pacman_command(
648-
["pacman", "-S", "--noconfirm", "--needed", *names],
648+
["-S", "--noconfirm", "--needed", *names],
649649
progress_callback=self._on_progress_update,
650650
output_callback=self._on_terminal_output,
651651
complete_callback=lambda success: GLib.idle_add(
@@ -715,7 +715,7 @@ def _on_single_install_confirm(
715715
cancel_callback=self._mhwd_manager.cancel_operation,
716716
)
717717
self._mhwd_manager._run_pacman_command(
718-
["pacman", "-S", "--noconfirm", "--needed", pkg_name],
718+
["-S", "--noconfirm", "--needed", pkg_name],
719719
progress_callback=self._on_progress_update,
720720
output_callback=self._on_terminal_output,
721721
complete_callback=lambda success: GLib.idle_add(

usr/share/big-driver-manager/ui/mesa_page.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1372,7 +1372,7 @@ def _on_gpu_pkg_install_confirm(
13721372
cancel_callback=self.mhwd_manager.cancel_operation,
13731373
)
13741374
self.mhwd_manager._run_pacman_command(
1375-
["pacman", "-S", "--noconfirm", name],
1375+
["-S", "--noconfirm", name],
13761376
progress_callback=self._on_progress_update,
13771377
output_callback=self._on_terminal_output,
13781378
complete_callback=lambda success: GLib.idle_add(
@@ -1410,7 +1410,7 @@ def _on_gpu_pkg_remove_confirm(
14101410
cancel_callback=self.mhwd_manager.cancel_operation,
14111411
)
14121412
self.mhwd_manager._run_pacman_command(
1413-
["pacman", "-Rns", "--noconfirm", name],
1413+
["-Rns", "--noconfirm", name],
14141414
progress_callback=self._on_progress_update,
14151415
output_callback=self._on_terminal_output,
14161416
complete_callback=lambda success: GLib.idle_add(

0 commit comments

Comments
 (0)