development for OUT parameter

Modify the create and call behavior of the function, if the function has
the out parameter.

If the function has the out parameter, the return
datatype of the function can be any datatype, and the function return
datatype has no relationship with out pararmeter datatype.

If the function return datatype is not VOID, must specify the RETURN
statement in the function body.

When calling a function in plisql, must specify a variable to receive
the out parameter value.

If turn the guc ivorysql.allow_out_parameter_const off, call a function
in SQL will report an error if the constant or NULL is passed for the out
parameter.
If turn the guc ivorysql.allow_out_parameter_const on, call a function a
SQL, you can pass constant or NULL for the out parameter.

Add a new grammer for anonymous_block,
DO [LANGUAGE lang_name] code [USING IN|OUT|INOUT|IN OUT, ...]

Libpq supports binding parameters by position and name when calling a
function. Some interface functions similar to OCI are implemented.

Author: bigplaice

GNUmakefile.in

@@ -95,7 +95,7 @@ GNUmakefile: GNUmakefile.in $(top_builddir)/config.status
 
 $(call recurse,oracle-pg-check-world,src/test,oracle-pg-check)
 #add oracle regression
-$(call recurse,oracle-check-world,src/oracle_test src/pl src/interfaces/ecpg contrib contrib/ivorysql_ora contrib/ora_btree_gist contrib/ora_btree_gin src/bin,oracle-check)
+$(call recurse,oracle-check-world,src/oracle_test src/pl src/interfaces/ecpg src/interfaces/libpq/ivytest contrib contrib/ivorysql_ora contrib/ora_btree_gist contrib/ora_btree_gin src/bin,oracle-check)
 $(call recurse,oracle-checkprep,  src/oracle_test src/pl src/interfaces/ecpg contrib src/bin)
 
 $(call recurse,oracle-installcheck-world,src/oracle_test src/pl src/interfaces/ecpg contrib src/bin,oracle-installcheck)

configure

@@ -18309,19 +18309,22 @@ $as_echo_n "checking which semaphore API to use... " >&6; }
 $as_echo "#define USE_NAMED_POSIX_SEMAPHORES 1" >>confdefs.h
 
     SEMA_IMPLEMENTATION="src/backend/port/posix_sema.c"
+        LIBPQ_SEMA_IMPLEMENTATION="src/interfaces/libpq/posix_ivysema.c"
     sematype="named POSIX"
   else
     if test x"$USE_UNNAMED_POSIX_SEMAPHORES" = x"1" ; then
 
 $as_echo "#define USE_UNNAMED_POSIX_SEMAPHORES 1" >>confdefs.h
 
       SEMA_IMPLEMENTATION="src/backend/port/posix_sema.c"
+          LIBPQ_SEMA_IMPLEMENTATION="src/interfaces/libpq/posix_ivysema.c"
       sematype="unnamed POSIX"
     else
 
 $as_echo "#define USE_SYSV_SEMAPHORES 1" >>confdefs.h
 
       SEMA_IMPLEMENTATION="src/backend/port/sysv_sema.c"
+          LIBPQ_SEMA_IMPLEMENTATION="src/interfaces/libpq/sysv_ivysema.c"
       sematype="System V"
     fi
   fi
@@ -18332,6 +18335,7 @@ else
 $as_echo "#define USE_WIN32_SEMAPHORES 1" >>confdefs.h
 
   SEMA_IMPLEMENTATION="src/backend/port/win32_sema.c"
+  LIBPQ_SEMA_IMPLEMENTATION="src/interfaces/libpq/win32_ivyxsema.c"
 fi
 
 
@@ -19407,7 +19411,7 @@ fi
 ac_config_files="$ac_config_files GNUmakefile src/Makefile.global"
 
 
-ac_config_links="$ac_config_links src/backend/port/pg_sema.c:${SEMA_IMPLEMENTATION} src/backend/port/pg_shmem.c:${SHMEM_IMPLEMENTATION} src/include/pg_config_os.h:src/include/port/${template}.h src/Makefile.port:src/makefiles/Makefile.${template}"
+ac_config_links="$ac_config_links src/backend/port/pg_sema.c:${SEMA_IMPLEMENTATION} src/interfaces/libpq/ivy_sema.c:${LIBPQ_SEMA_IMPLEMENTATION} src/backend/port/pg_shmem.c:${SHMEM_IMPLEMENTATION} src/include/pg_config_os.h:src/include/port/${template}.h src/Makefile.port:src/makefiles/Makefile.${template}"
 
 
 if test "$PORTNAME" = "win32"; then
@@ -20130,6 +20134,7 @@ do
     "GNUmakefile") CONFIG_FILES="$CONFIG_FILES GNUmakefile" ;;
     "src/Makefile.global") CONFIG_FILES="$CONFIG_FILES src/Makefile.global" ;;
     "src/backend/port/pg_sema.c") CONFIG_LINKS="$CONFIG_LINKS src/backend/port/pg_sema.c:${SEMA_IMPLEMENTATION}" ;;
+    "src/interfaces/libpq/ivy_sema.c") CONFIG_LINKS="$CONFIG_LINKS src/interfaces/libpq/ivy_sema.c:${LIBPQ_SEMA_IMPLEMENTATION}" ;;
     "src/backend/port/pg_shmem.c") CONFIG_LINKS="$CONFIG_LINKS src/backend/port/pg_shmem.c:${SHMEM_IMPLEMENTATION}" ;;
     "src/include/pg_config_os.h") CONFIG_LINKS="$CONFIG_LINKS src/include/pg_config_os.h:src/include/port/${template}.h" ;;
     "src/Makefile.port") CONFIG_LINKS="$CONFIG_LINKS src/Makefile.port:src/makefiles/Makefile.${template}" ;;

configure.ac

@@ -2336,22 +2336,26 @@ if test "$PORTNAME" != "win32"; then
   if test x"$USE_NAMED_POSIX_SEMAPHORES" = x"1" ; then
     AC_DEFINE(USE_NAMED_POSIX_SEMAPHORES, 1, [Define to select named POSIX semaphores.])
     SEMA_IMPLEMENTATION="src/backend/port/posix_sema.c"
+        LIBPQ_SEMA_IMPLEMENTATION="src/interfaces/libpq/posix_ivysema.c"
     sematype="named POSIX"
   else
     if test x"$USE_UNNAMED_POSIX_SEMAPHORES" = x"1" ; then
       AC_DEFINE(USE_UNNAMED_POSIX_SEMAPHORES, 1, [Define to select unnamed POSIX semaphores.])
       SEMA_IMPLEMENTATION="src/backend/port/posix_sema.c"
+          LIBPQ_SEMA_IMPLEMENTATION="src/interfaces/libpq/posix_ivysema.c"
       sematype="unnamed POSIX"
     else
       AC_DEFINE(USE_SYSV_SEMAPHORES, 1, [Define to select SysV-style semaphores.])
       SEMA_IMPLEMENTATION="src/backend/port/sysv_sema.c"
+          LIBPQ_SEMA_IMPLEMENTATION="src/interfaces/libpq/sysv_ivysema.c"
       sematype="System V"
     fi
   fi
   AC_MSG_RESULT([$sematype])
 else
   AC_DEFINE(USE_WIN32_SEMAPHORES, 1, [Define to select Win32-style semaphores.])
   SEMA_IMPLEMENTATION="src/backend/port/win32_sema.c"
+  LIBPQ_SEMA_IMPLEMENTATION="src/interfaces/libpq/win32_ivysema.c"
 fi
 
 
@@ -2580,6 +2584,7 @@ AC_CONFIG_FILES([GNUmakefile src/Makefile.global])
 
 AC_CONFIG_LINKS([
   src/backend/port/pg_sema.c:${SEMA_IMPLEMENTATION}
+  src/interfaces/libpq/ivy_sema.c:${LIBPQ_SEMA_IMPLEMENTATION}
   src/backend/port/pg_shmem.c:${SHMEM_IMPLEMENTATION}
   src/include/pg_config_os.h:src/include/port/${template}.h
   src/Makefile.port:src/makefiles/Makefile.${template}

contrib/hstore/expected/ivy_hstore.out

@@ -1608,7 +1608,9 @@ select f2['d'], f2['x'] is null as x_isnull from test_json_agg;
 select f2['d']['e'] from test_json_agg;  -- error
 ERROR:  hstore allows only one subscript
 select f2['d':'e'] from test_json_agg;  -- error
-ERROR:  hstore allows only one subscript
+ERROR:  syntax error at or near ":"
+LINE 1: select f2['d':'e'] from test_json_agg;
+                     ^
 update test_json_agg set f2['d'] = f2['e'], f2['x'] = 'xyzzy';
 select f2 from test_json_agg;
                                                          f2                                                          

contrib/ivorysql_ora/expected/datatype_and_func_bugs.out

@@ -51,7 +51,7 @@ begin
 return 1;
 end;
 /
-create function s1.f_alter(arg1 OUT number)
+create function s1.f_alter(arg1 OUT int)
 return number
 is
 begin
@@ -77,7 +77,7 @@ ERROR:  function name "s1.f_alter" is not unique
 HINT:  Specify the argument list to select the function unambiguously.
 alter function s1.f_alter(arg1 number) compile;
 alter function s1.f_alter(arg1 number, arg2 number) compile;
-alter function s1.f_alter(arg1 OUT number) compile;
+alter function s1.f_alter(arg1 OUT int) compile;
 alter function s1.f_alter(arg1 text) compile;
 alter function s1.f_alter(arg1 number, arg2 number, arg3 number default 10) compile;
 ERROR:  syntax error at or near "default"
@@ -91,6 +91,6 @@ drop table char_tb;
 drop function f_noparam();
 drop function s1.f_alter(arg1 number);
 drop function s1.f_alter(arg1 number, arg2 number);
-drop function s1.f_alter(arg1 OUT number);
+drop function s1.f_alter(arg1 OUT int);
 drop function s1.f_alter(arg1 text);
 drop function s1.f_alter(arg1 number, arg2 number, arg3 number);

contrib/ivorysql_ora/expected/ora_sysview.out

@@ -110,10 +110,10 @@ CREATE OR REPLACE FUNCTION FUNC_WITH_DEFAULT
 (
 	ARG1 IN INT DEFAULT 10,
 	ARG2 OUT INT,
-	ARG3 IN OUT INT DEFAULT 20,
+	ARG3 IN OUT INT,
 	ARG4 IN VARCHAR2(10) DEFAULT NULL
 )
-RETURN RECORD IS
+RETURN void IS
 BEGIN
 	ARG2 := ARG1 + 10;
 	ARG3 := ARG1 / 2;

contrib/ivorysql_ora/sql/datatype_and_func_bugs.sql

@@ -40,7 +40,7 @@ return 1;
 end;
 /
 
-create function s1.f_alter(arg1 OUT number)
+create function s1.f_alter(arg1 OUT int)
 return number
 is
 begin
@@ -67,7 +67,7 @@ end;
 alter function s1.f_alter compile;
 alter function s1.f_alter(arg1 number) compile;
 alter function s1.f_alter(arg1 number, arg2 number) compile;
-alter function s1.f_alter(arg1 OUT number) compile;
+alter function s1.f_alter(arg1 OUT int) compile;
 alter function s1.f_alter(arg1 text) compile;
 alter function s1.f_alter(arg1 number, arg2 number, arg3 number default 10) compile;
 alter function s1.f_alter(arg1 number, arg2 number, arg3 number) compile;
@@ -78,6 +78,6 @@ drop table char_tb;
 drop function f_noparam();
 drop function s1.f_alter(arg1 number);
 drop function s1.f_alter(arg1 number, arg2 number);
-drop function s1.f_alter(arg1 OUT number);
+drop function s1.f_alter(arg1 OUT int);
 drop function s1.f_alter(arg1 text);
 drop function s1.f_alter(arg1 number, arg2 number, arg3 number);

contrib/ivorysql_ora/sql/ora_sysview.sql

@@ -68,10 +68,10 @@ CREATE OR REPLACE FUNCTION FUNC_WITH_DEFAULT
 (
 	ARG1 IN INT DEFAULT 10,
 	ARG2 OUT INT,
-	ARG3 IN OUT INT DEFAULT 20,
+	ARG3 IN OUT INT,
 	ARG4 IN VARCHAR2(10) DEFAULT NULL
 )
-RETURN RECORD IS
+RETURN void IS
 BEGIN
 	ARG2 := ARG1 + 10;
 	ARG3 := ARG1 / 2;

src/backend/access/common/printtup.c

@@ -513,3 +513,35 @@ debugtup(TupleTableSlot *slot, DestReceiver *self)
 
 	return true;
 }
+
+/*
+ * ChangeDestSendDescription:
+ * During PBE executing a anonymous block which includes some out parameters,
+ * we should change it to send description
+ */
+void
+ChangeDestSendDescription(DestReceiver *dest)
+{
+	DR_printtup *myState = (DR_printtup *) dest;
+
+	Assert(dest->mydest == DestRemoteExecute);
+
+	myState->sendDescrip = true;
+}
+
+/*
+ * Set sendDescrip for a DestRemote (or DestRemoteExecute) receiver
+ */
+void
+SetRemoteDestReceiverSendDescr(DestReceiver *self, bool send_info)
+{
+	DR_printtup *myState = (DR_printtup *) self;
+
+	Assert(myState->pub.mydest == DestRemote ||
+		   myState->pub.mydest == DestRemoteExecute);
+
+	myState->sendDescrip = send_info;
+
+	return;
+}
+

src/backend/catalog/dependency.c

@@ -2338,6 +2338,8 @@ find_expr_references_walker(Node *node,
 						   context->addrs);
 		/* fall through to examine arguments */
 	}
+	else if (IsA(node, NonDefValNode))
+		return false;
 
 	return expression_tree_walker(node, find_expr_references_walker,
 								  (void *) context);