For CodeRabbitAI's comments.

Author: bigplaice

configure

@@ -18335,7 +18335,7 @@ else
 $as_echo "#define USE_WIN32_SEMAPHORES 1" >>confdefs.h
 
   SEMA_IMPLEMENTATION="src/backend/port/win32_sema.c"
-  LIBPQ_SEMA_IMPLEMENTATION="src/interfaces/libpq/win32_ivyxsema.c"
+  LIBPQ_SEMA_IMPLEMENTATION="src/interfaces/libpq/win32_ivysema.c"
 fi
 
 

src/backend/executor/execExpr.c

@@ -4591,7 +4591,7 @@ ExecInitFuncOutParams(Expr *node, ExprState *state,
 					if (!allow_out_parameter_const)
 						ereport(ERROR,
 							(errcode(ERRCODE_DATA_EXCEPTION),
-							errmsg("OUT or IN OUT arguments of the funtion %s musb be variables ",
+							errmsg("OUT or IN OUT arguments of the function %s must be variables",
 									funcname)));
 					return;
 				}

src/backend/parser/parse_clause.c

@@ -3934,7 +3934,7 @@ interpretRowidOption(List *defList, bool allowRowid)
 }
 
 /*
- * CheckRangeFunc
+ * check_funcexpr_outparams
  * If the function has out parameters,
  * can't call the function in SQL, such as 'from function(..)'
  */
@@ -3995,7 +3995,7 @@ check_funcexpr_outparams(List *funcexprs)
 						ReleaseSysCache(procTup);
 						ereport(ERROR,
 							(errcode(ERRCODE_DATA_EXCEPTION),
-							errmsg("OUT or IN OUT arguments of the funtion %s musb be variables ",
+							errmsg("OUT or IN OUT arguments of the funtion %s must be variables ",
 									proname)));
 					}
 				}

src/include/commands/defrem.h

@@ -19,7 +19,6 @@
 #include "parser/parse_node.h"
 #include "tcop/dest.h"
 #include "utils/array.h"
-#include "tcop/dest.h"
 
 /* commands/dropcmds.c */
 extern void RemoveObjects(DropStmt *stmt);

src/include/nodes/params.h

@@ -111,7 +111,7 @@ typedef void (*ParamCompileHook) (ParamListInfo params, struct Param *param,
 
 typedef void (*ParserSetupHook) (struct ParseState *pstate, void *arg);
 
-typedef void (*OutParamSepupHook) (void *scratch);
+typedef void (*OutParamSetupHook) (void *scratch);
 
 typedef struct ParamListInfoData
 {
@@ -123,7 +123,7 @@ typedef struct ParamListInfoData
 	void	   *parserSetupArg;
 	char	   *paramValuesStr; /* params as a single string for errors */
 	int			numParams;		/* nominal/maximum # of Params represented */
-	OutParamSepupHook	outparamSepup;	/* OUT parameters hook */
+	OutParamSetupHook	outparamSepup;	/* OUT parameters hook */
 	bool 		topLevelIsCall;	/* is top level call statement ? */
 	MemoryContext	outctext;		/* save out parameter memorycontext */
 	bool		haveout;		/* parameters have out parameters */

src/include/nodes/parsenodes.h

@@ -313,7 +313,7 @@ typedef struct OraParamRef
 {
 	NodeTag		type;
 	int			number;			/* the number of the parameter */
-	int			location;		/* token location, or -1 if unknown */	
+	ParseLoc		location;		/* token location, or -1 if unknown */	
 	char        *name;          /* placeholder name */	
 } OraParamRef;
 

src/interfaces/libpq/ivy_sema.h

@@ -13,7 +13,7 @@
  *
  * Portions Copyright (c) 2025, IvorySQL Global Development Team
  *
- * src/include/ivy_sema.h
+ * src/interfaces/libpq/ivy_sema.h
  *
  *-------------------------------------------------------------------------
  */

src/interfaces/libpq/ivytest/testlibpq_binary_float.c

@@ -17,7 +17,6 @@
 #include "libpq-ivy.h"
 #include <string.h>
 #include <stdint.h>
-#include <string.h>
 #include <netinet/in.h>
 #include <sys/types.h>
 

src/interfaces/libpq/sysv_ivysema.c

@@ -41,6 +41,9 @@ typedef int IpcSemaphoreId;		/* semaphore ID returned by semget(2) */
 #define IPCProtection	(0600)	/* access/modify by user only */
 
 #define PGSemaMagic		537		/* must be less than SEMVMX */
+#ifdef SEMVMX
+StaticAssertDecl(PGSemaMagic < SEMVMX, "PGSemaMagic must be less than SEMVMX");
+#endif
 
 static IpcSemaphoreKey nextSemaKey;		/* next key to try using */
 
@@ -121,7 +124,7 @@ IpcSemaphoreInitialize(IpcSemaphoreId semId, int semNum, int value)
 		if (saved_errno == ERANGE)
 			fprintf(stderr, "You possibly need to raise your kernel's SEMVMX value to be at least %d "
 					"Look into the PostgreSQL documentation for details.", value);
-		return;
+		exit(-1);
 	}
 }
 
@@ -318,7 +321,7 @@ PGSemaphoreLock(PGSemaphore sema)
 	if (errStatus < 0)
 	{
 		fprintf(stderr, "semop(id=%d) failed: %m", sema->semId);
-		return;
+		exit(-1);
 	}
 }
 

src/pl/plisql/src/pl_exec.c

@@ -4253,7 +4253,7 @@ plisql_estate_setup(PLiSQL_execstate *estate,
 	estate->paramLI->parserSetup = (ParserSetupHook) plisql_parser_setup;
 	estate->paramLI->parserSetupArg = NULL; /* filled during use */
 	estate->paramLI->numParams = estate->ndatums;
-	estate->paramLI->outparamSepup = (OutParamSepupHook) plisql_out_param_setup;
+	estate->paramLI->outparamSepup = (OutParamSetupHook) plisql_out_param_setup;
 	estate->paramLI->paramnames = NULL;