Skip to content
This repository was archived by the owner on Oct 30, 2023. It is now read-only.

Commit 0d47038

Browse files
committed
Merge branch 'master' of github.com:binance-exchange/binance-java-api
2 parents 5c4451c + 96bbbd1 commit 0d47038

2 files changed

Lines changed: 35 additions & 15 deletions

File tree

src/main/java/com/binance/api/client/domain/event/AllMarketTickersEvent.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,12 @@ public class AllMarketTickersEvent {
3737
@JsonProperty("Q")
3838
private String closeTradesQuantity;
3939

40+
@JsonProperty("b")
41+
private String bestBidPrice;
42+
43+
@JsonProperty("B")
44+
private String bestBidQuantity;
45+
4046
@JsonProperty("a")
4147
private String bestAskPrice;
4248

@@ -145,6 +151,22 @@ public void setCloseTradesQuantity(String closeTradesQuantity) {
145151
this.closeTradesQuantity = closeTradesQuantity;
146152
}
147153

154+
public String getBestBidPrice() {
155+
return bestBidPrice;
156+
}
157+
158+
public void setBestBidPrice(String bestBidPrice) {
159+
this.bestBidPrice = bestBidPrice;
160+
}
161+
162+
public String getBestBidQuantity() {
163+
return bestBidQuantity;
164+
}
165+
166+
public void setBestBidQuantity(String bestBidQuantity) {
167+
this.bestBidQuantity = bestBidQuantity;
168+
}
169+
148170
public String getBestAskPrice() {
149171
return bestAskPrice;
150172
}
@@ -253,6 +275,8 @@ public String toString() {
253275
.append("previousDaysClosePrice", previousDaysClosePrice)
254276
.append("currentDaysClosePrice", currentDaysClosePrice)
255277
.append("closeTradesQuantity", closeTradesQuantity)
278+
.append("bestBidPrice", bestBidPrice)
279+
.append("bestBidQuantity", bestBidQuantity)
256280
.append("bestAskPrice", bestAskPrice)
257281
.append("bestAskQuantity", bestAskQuantity)
258282
.append("openPrice", openPrice)

src/main/java/com/binance/api/client/impl/BinanceApiWebSocketListener.java

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
package com.binance.api.client.impl;
22

3-
import java.io.IOException;
4-
import okhttp3.Response;
5-
import okhttp3.WebSocket;
6-
import okhttp3.WebSocketListener;
73
import com.binance.api.client.BinanceApiCallback;
84
import com.binance.api.client.exception.BinanceApiException;
95
import com.fasterxml.jackson.core.type.TypeReference;
106
import com.fasterxml.jackson.databind.ObjectMapper;
7+
import com.fasterxml.jackson.databind.ObjectReader;
8+
import okhttp3.Response;
9+
import okhttp3.WebSocket;
10+
import okhttp3.WebSocketListener;
11+
12+
import java.io.IOException;
1113

1214
/**
1315
* Binance API WebSocket listener.
@@ -16,32 +18,26 @@ public class BinanceApiWebSocketListener<T> extends WebSocketListener {
1618

1719
private BinanceApiCallback<T> callback;
1820

19-
private Class<T> eventClass;
21+
private static final ObjectMapper mapper = new ObjectMapper();
2022

21-
private TypeReference<T> eventTypeReference;
23+
private final ObjectReader objectReader;
2224

2325
private boolean closing = false;
2426

2527
public BinanceApiWebSocketListener(BinanceApiCallback<T> callback, Class<T> eventClass) {
2628
this.callback = callback;
27-
this.eventClass = eventClass;
29+
this.objectReader = mapper.readerFor(eventClass);
2830
}
2931

3032
public BinanceApiWebSocketListener(BinanceApiCallback<T> callback, TypeReference<T> eventTypeReference) {
3133
this.callback = callback;
32-
this.eventTypeReference = eventTypeReference;
34+
this.objectReader = mapper.readerFor(eventTypeReference);
3335
}
3436

3537
@Override
3638
public void onMessage(WebSocket webSocket, String text) {
37-
ObjectMapper mapper = new ObjectMapper();
3839
try {
39-
T event = null;
40-
if (eventClass == null) {
41-
event = mapper.readValue(text, eventTypeReference);
42-
} else {
43-
event = mapper.readValue(text, eventClass);
44-
}
40+
T event = objectReader.readValue(text);
4541
callback.onResponse(event);
4642
} catch (IOException e) {
4743
throw new BinanceApiException(e);

0 commit comments

Comments
 (0)