feat(bitcoin): bump Bitcoin Core to 28.2 (#2329)

Author: bitcoin-tools

README.md

@@ -14,7 +14,7 @@ sh -c "$(curl -fsSL https://github.com/bitcoin-tools/nodebuilder/raw/v1.11.0/nod
 [![Suppprts: FreeBSD](https://img.shields.io/badge/supports-FreeBSD-blue.svg?logo=freebsd)](https://www.freebsd.org)
 [![Suppprts: OpenBSD](https://img.shields.io/badge/supports-OpenBSD-blue.svg?logo=openbsd)](https://www.openbsd.org)
 
-[![Run Bitcoin Core 28.0](https://img.shields.io/badge/run-Bitcoin%20Core%2028.0-F7931A.svg?logo=data:image/svg+xml;base64,PHN2ZyB2aWV3Qm94PSIwIDAgMjQgMjQiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+PHBhdGggZD0iTTIzLjYzNiAxNC45MDJjLTEuNjAyIDYuNDMtOC4xMTQgMTAuMzQyLTE0LjU0MyA4Ljc0QzIuNjY2IDIyLjAzNy0xLjI0NiAxNS41MjUuMzU3IDkuMDk4IDEuOTYgMi42NjkgOC40Ny0xLjI0NCAxNC44OTcuMzU5YzYuNDMgMS42MDIgMTAuMzQxIDguMTE1IDguNzM5IDE0LjU0NCIgZmlsbD0iI2Y3OTMxYSIvPjxwYXRoIGQ9Ik0xNC42ODYgMTAuMjY3Yy0uMzcxIDEuNDg3LTIuNjYzLjczMS0zLjQwNi41NDZsLjY1NS0yLjYyOWMuNzQzLjE4NiAzLjEzOC41MzEgMi43NSAyLjA4M20tLjQwNiA0LjI0MmMtLjQwNyAxLjYzNS0zLjE2Ljc1LTQuMDUzLjUzbC43MjQtMi45Yy44OTMuMjI0IDMuNzU0LjY2NCAzLjMzIDIuMzdtMy4wMDgtNC4yMTljLjIzOC0xLjU5Ni0uOTc3LTIuNDU1LTIuNjQtMy4wMjdsLjU0LTIuMTYzLTEuMzE4LS4zMy0uNTI1IDIuMTA3YTU0LjI5MiA1NC4yOTIgMCAwIDAtMS4wNTQtLjI0OWwuNTMtMi4xMi0xLjMxNy0uMzI4LS41NCAyLjE2MmMtLjI4Ni0uMDY1LS41NjctLjEzLS44NC0uMTk4bC4wMDEtLjAwNy0xLjgxNi0uNDUzLS4zNSAxLjQwNnMuOTc3LjIyNC45NTYuMjM4Yy41MzMuMTMzLjYzLjQ4Ni42MTMuNzY2bC0uNjE1IDIuNDYzYy4wMzguMDEuMDg1LjAyNC4xMzcuMDQ1bC0uMTM4LS4wMzUtLjg2MiAzLjQ1MmMtLjA2NS4xNjEtLjIzLjQwNS0uNjA0LjMxMi4wMTQuMDItLjk1Ny0uMjM5LS45NTctLjIzOUw1LjgzNiAxNS42bDEuNzE0LjQyN2MuMzE4LjA4LjYzLjE2NC45MzguMjQybC0uNTQ1IDIuMTkgMS4zMTUuMzI4LjU0LTIuMTY0Yy4zNi4wOTcuNzA4LjE4NyAxLjA1LjI3MWwtLjUzOCAyLjE1NiAxLjMxNi4zMjguNTQ2LTIuMTgzYzIuMjQ1LjQyNCAzLjkzMy4yNTMgNC42NDMtMS43NzcuNTc0LTEuNjM1LS4wMjctMi41NzgtMS4yMDgtMy4xOTQuODYtLjE5OCAxLjUwOC0uNzY1IDEuNjgxLTEuOTM0IiBmaWxsPSIjZmZmIi8+PC9zdmc+)](https://bitcoincore.org/en/releases/28.0/)
+[![Run Bitcoin Core 28.2](https://img.shields.io/badge/run-Bitcoin%20Core%2028.2-F7931A.svg?logo=data:image/svg+xml;base64,PHN2ZyB2aWV3Qm94PSIwIDAgMjQgMjQiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+PHBhdGggZD0iTTIzLjYzNiAxNC45MDJjLTEuNjAyIDYuNDMtOC4xMTQgMTAuMzQyLTE0LjU0MyA4Ljc0QzIuNjY2IDIyLjAzNy0xLjI0NiAxNS41MjUuMzU3IDkuMDk4IDEuOTYgMi42NjkgOC40Ny0xLjI0NCAxNC44OTcuMzU5YzYuNDMgMS42MDIgMTAuMzQxIDguMTE1IDguNzM5IDE0LjU0NCIgZmlsbD0iI2Y3OTMxYSIvPjxwYXRoIGQ9Ik0xNC42ODYgMTAuMjY3Yy0uMzcxIDEuNDg3LTIuNjYzLjczMS0zLjQwNi41NDZsLjY1NS0yLjYyOWMuNzQzLjE4NiAzLjEzOC41MzEgMi43NSAyLjA4M20tLjQwNiA0LjI0MmMtLjQwNyAxLjYzNS0zLjE2Ljc1LTQuMDUzLjUzbC43MjQtMi45Yy44OTMuMjI0IDMuNzU0LjY2NCAzLjMzIDIuMzdtMy4wMDgtNC4yMTljLjIzOC0xLjU5Ni0uOTc3LTIuNDU1LTIuNjQtMy4wMjdsLjU0LTIuMTYzLTEuMzE4LS4zMy0uNTI1IDIuMTA3YTU0LjI5MiA1NC4yOTIgMCAwIDAtMS4wNTQtLjI0OWwuNTMtMi4xMi0xLjMxNy0uMzI4LS41NCAyLjE2MmMtLjI4Ni0uMDY1LS41NjctLjEzLS44NC0uMTk4bC4wMDEtLjAwNy0xLjgxNi0uNDUzLS4zNSAxLjQwNnMuOTc3LjIyNC45NTYuMjM4Yy41MzMuMTMzLjYzLjQ4Ni42MTMuNzY2bC0uNjE1IDIuNDYzYy4wMzguMDEuMDg1LjAyNC4xMzcuMDQ1bC0uMTM4LS4wMzUtLjg2MiAzLjQ1MmMtLjA2NS4xNjEtLjIzLjQwNS0uNjA0LjMxMi4wMTQuMDItLjk1Ny0uMjM5LS45NTctLjIzOUw1LjgzNiAxNS42bDEuNzE0LjQyN2MuMzE4LjA4LjYzLjE2NC45MzguMjQybC0uNTQ1IDIuMTkgMS4zMTUuMzI4LjU0LTIuMTY0Yy4zNi4wOTcuNzA4LjE4NyAxLjA1LjI3MWwtLjUzOCAyLjE1NiAxLjMxNi4zMjguNTQ2LTIuMTgzYzIuMjQ1LjQyNCAzLjkzMy4yNTMgNC42NDMtMS43NzcuNTc0LTEuNjM1LS4wMjctMi41NzgtMS4yMDgtMy4xOTQuODYtLjE5OCAxLjUwOC0uNzY1IDEuNjgxLTEuOTM0IiBmaWxsPSIjZmZmIi8+PC9zdmc+)](https://bitcoincore.org/en/releases/28.2/)
 [![License: MIT-0](https://img.shields.io/badge/license-MIT--0-yellow.svg?logo=data:image/svg+xml;base64,PCFET0NUWVBFIHN2ZyBQVUJMSUMgIi0vL1czQy8vRFREIFNWRyAxLjEvL0VOIiAiaHR0cDovL3d3dy53My5vcmcvR3JhcGhpY3MvU1ZHLzEuMS9EVEQvc3ZnMTEuZHRkIj4KPCEtLSBVcGxvYWRlZCB0bzogU1ZHIFJlcG8sIHd3dy5zdmdyZXBvLmNvbSwgVHJhbnNmb3JtZWQgYnk6IFNWRyBSZXBvIE1peGVyIFRvb2xzIC0tPgo8c3ZnIGZpbGw9IiNmZmZmZmYiIHdpZHRoPSI4MDBweCIgaGVpZ2h0PSI4MDBweCIgdmlld0JveD0iMCAwIDMyIDMyIiB2ZXJzaW9uPSIxLjEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+Cg08ZyBpZD0iU1ZHUmVwb19iZ0NhcnJpZXIiIHN0cm9rZS13aWR0aD0iMCIvPgoNPGcgaWQ9IlNWR1JlcG9fdHJhY2VyQ2FycmllciIgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIiBzdHJva2UtbGluZWpvaW49InJvdW5kIi8+Cg08ZyBpZD0iU1ZHUmVwb19pY29uQ2FycmllciI+IDx0aXRsZT5qdXN0aWNlPC90aXRsZT4gPHBhdGggZD0iTTI0LjA2NCA2LjU4M2wtMy43NzMgOC4zNzVoLTEuMDk4bDQuMDI0LTguOTE2aC02LjIxM3YyMC43NzFjMS4yOCAwLjA0NyA3LjgxMyAyLjE2NyA3LjgxMyAyLjE2N3YxLjAyMGgtMTcuNTZ2LTEuMDg5YzAgMCA2LjY3OC0yLjA5OSA3LjY4NC0yLjA5OXYtMjAuNzdoLTYuMDE1bDQuMDI1IDguOTE2aC0xLjA5OGwtMy43NzMtOC4zNzUtMy43NzMgOC4zNzVoLTEuMDk4bDQuMDQ4LTguOTY2di0xLjAzNGg2Ljc1NGMwLTEuMzUzIDAuOTA3LTIuNDU4IDEuOTY1LTIuNDU4IDEuMTE5IDAgMS45NjUgMS4xNjggMS45NjUgMi40NThoNi44Nzh2MC44ODdsNC4xMTYgOS4xMTNoLTEuMDk4bC0zLjc3My04LjM3NXpNMTMuMDIwIDE1Ljk3OWMwIDIuNjkzLTEuODY4IDUuMjgyLTQuOTM5IDUuMjgyLTMuMDAyIDAtNC45MzktMi41ODktNC45MzktNS4yODItMC4wMDEgMC4wMDQgOS44NzggMC4wMDQgOS44NzggMHpNMTkuMjYyIDE1Ljk3OWMwIDAuMDA1IDkuODc5IDAuMDA1IDkuODc5IDAgMCAyLjY5My0xLjg2OCA1LjI4Mi00LjkzOSA1LjI4Mi0zLjAwMyAwLTQuOTQtMi41ODktNC45NC01LjI4MnoiLz4gPC9nPgoNPC9zdmc+)](https://opensource.org/licenses/MIT-0)
 [![Language: POSIX shell](https://img.shields.io/badge/language-POSIX%20shell-yellow.svg?logo=gnometerminal)](https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html)
 
@@ -58,7 +58,7 @@ chmod u+x nodebuilder
 
 | Short | Long Version | Description | Arguments |
 |:-----:|:-------------|:------------|:----------|
-| `-b` | `--bitcoin-version` | Specify the Bitcoin version. | One argument<br>E.g.: `-b 28.0` |
+| `-b` | `--bitcoin-version` | Specify the Bitcoin version. | One argument<br>E.g.: `-b 28.2` |
 | `-c` | `--compile` | Build Bitcoin from source. | No arguments |
 | `-h` | `--help` | Display the help message. | No arguments<br>_Supersedes other arguments._ |
 | `-j` | `--jobs` | Set the number of compile jobs. | One argument<br>E.g.: `-j 1` |
@@ -69,11 +69,11 @@ chmod u+x nodebuilder
 | `-t` | `--test` | Run unit tests on functions. | No arguments |
 | `-u` | `--unattended` | Run in non-interactive mode. | No arguments |
 
-You can set multiple options. Here are two ways to compile Bitcoin 28.0 unattended with a 50000 MiB prune:
+You can set multiple options. Here are two ways to compile Bitcoin 28.2 unattended with a 50000 MiB prune:
 
 ```sh
-./nodebuilder -b 28.0 -c -p 50000 -u
-./nodebuilder --bitcoin-version 28.0 --compile --prune 50000 --unattended
+./nodebuilder -b 28.2 -c -p 50000 -u
+./nodebuilder --bitcoin-version 28.2 --compile --prune 50000 --unattended
 ```
 
 ### (Optional) Docker Container

nodebuilder

@@ -347,8 +347,10 @@ bitcoin_tarball_install()
     sudo mkdir "${BITCOIN_INSTALL_BIN_DESTINATION}" ||
     throw_error "Unable to create directory ${BITCOIN_INSTALL_BIN_DESTINATION}."
   for bitcoin_executable in bitcoind bitcoin-qt bitcoin-cli bitcoin-tx bitcoin-util bitcoin-wallet; do
-    [ "${TARGET_KERNEL}" = 'Darwin' ] && [ "${TARGET_ARCHITECTURE}" = 'arm64' ] &&
+    if [ "${TARGET_KERNEL}" = 'Darwin' ] && [ "${TARGET_ARCHITECTURE}" = 'arm64' ] &&
+      ! is_arm64_test_bitcoin_signed "${target_bitcoin_version}"; then
       codesign -s - "${BITCOIN_INSTALL_BIN_SOURCE}/${bitcoin_executable}"
+    fi
     sudo install -c \
       "${BITCOIN_INSTALL_BIN_SOURCE}/${bitcoin_executable}" \
       "${BITCOIN_INSTALL_BIN_DESTINATION}/"
@@ -386,12 +388,12 @@ get_oldest_version()
 
 is_arm64_test_bitcoin_signed()
 {
-  readonly BITCOIN_VERSION_TO_CHECK="$1"
-  readonly ARM64_SIGNED_BINARY_VERSION='28.2'
+  BITCOIN_VERSION_TO_COMPARE="$1"
+  ARM64_SIGNED_BINARY_VERSION='28.2'
   [ "$#" -ne 1 ] &&
     throw_error "Invalid use of is_arm64_test_bitcoin_signed."
   # test_bitcoin binary is already signed on Bitcoin Core 28.2 and later
-  if [ "$(get_oldest_version "${BITCOIN_VERSION_TO_CHECK}" "${ARM64_SIGNED_BINARY_VERSION}")" \
+  if [ "$(get_oldest_version "${BITCOIN_VERSION_TO_COMPARE}" "${ARM64_SIGNED_BINARY_VERSION}")" \
     = "${ARM64_SIGNED_BINARY_VERSION}" ]; then
     return 0
   else
@@ -1532,10 +1534,11 @@ readonly VALID_BITCOIN_VERSION_LIST='0.9.5 0.10.0 0.10.1 0.10.2 0.10.3 0.10.4 \
     0.11.0 0.11.1 0.11.2 0.12.0 0.12.1 0.13.0 0.13.1 0.13.2 0.14.3 0.15.2 \
     0.16.3 0.17.0 0.17.0.1 0.17.1 0.17.2 0.18.0 0.18.1 0.19.0 0.19.0.1 0.19.1 \
     0.20.0 0.20.1 0.20.2 0.21.0 0.21.1 0.21.2 22.0 22.1 23.0 23.1 23.2 24.0 \
-    24.0.1 24.1 24.2 25.0 25.1 25.2 26.0 26.1 26.2 27.0 27.1 27.2 28.0 28.1'
+    24.0.1 24.1 24.2 25.0 25.1 25.2 26.0 26.1 26.2 27.0 27.1 27.2 28.0 28.1 \
+    28.2'
 
 # Bump this variable for new Bitcoin Core releases
-target_bitcoin_version='28.1'
+target_bitcoin_version='28.2'
 
 # Instantiate the parameter variables
 compile_bitcoin_flag='false'