Skip to content

The CI tests for submodule master are not doing what we expect #40

@thunderbiscuit

Description

@thunderbiscuit

I think they are currently running the committed hash of the submodule rather than testing the new commit pushed on master on bdk-ffi. This is due to the build scripts explicitly performing git submodule update --init. We should ensure we have the option of not doing this, so that the build script can actually build using a submodule checked out at a different commit.

In bdk-jvm, this is what we have in the scripts:

printf "\nSubmodule check...\n"
if [[ "$1" != "--skip-submodule-update" ]]; then
  git submodule update --init
  printf "Submodule is checked out at commit: $(git submodule status)\n\n"
else
  printf "Skipping submodule update, using local changes.\n"
  printf "Submodule is checked out at commit: $(git submodule status)\n\n"
fi

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions