[bitnami/common] ChartVersion not escaped in labels

[jouve]

Name and Version

bitnami/common 2.36.0

What steps will reproduce the bug?

when .Chart.AppVersion contains a +, it is not escaped as _ in "common.labels.standard" if it is used with customLabels

ref: https://github.com/bitnami/charts/blob/main/bitnami/common/templates/_labels.tpl#L16 and https://github.com/bitnami/charts/blob/main/bitnami/common/templates/_labels.tpl#L25

latest version is this repo is 2.31.8, but 2.36.0 on the docker.io oci registry, please advice if I should open the issue somewhere else.

Are you using any custom parameters or values?

No response

What is the expected behavior?

No response

What do you see instead?

metadata.labels: Invalid value: "9.4.1+v3.3.0": a valid label must be an empty string or consist of alphanumeric characters, '-', '' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9.]*)?[A-Za-z0-9])?')

Additional information

No response

[javsalgar]

Hi! Thanks for opening the ticket. As we do not use + in our version that's not something we came across. Would you like to submit a PR adding the escape?

[jouve]

how to handle the version bump in Chart.yaml : 2.31.9 (according to this repo) or 2.36.1 (according the oci registry) ?

[carrodher]

It's needed to bump it according to the code, then the published version will be automatically incremented

[github-actions]

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

[jouve]

up, I will submit a PR soon

[github-actions]

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.