separating build and tests

Author: JohnathanWhite

.github/workflows/e2e-ios.yml

@@ -9,10 +9,10 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  e2e-ios:
-    name: E2E iOS Smoke
+  build-ios:
+    name: Build iOS App
     runs-on: macos-latest
-    timeout-minutes: 60
+    timeout-minutes: 45
 
     steps:
       - name: Checkout
@@ -61,28 +61,16 @@ jobs:
           cd ios
           bundle exec pod install
 
-      - name: Cache Maestro
-        uses: actions/cache@v4
-        with:
-          path: ~/.maestro
-          key: maestro-${{ runner.os }}
-          restore-keys: maestro-${{ runner.os }}
-
-      - name: Install Maestro
-        run: |
-          curl -Ls "https://get.maestro.mobile.dev" | bash
-          echo "$HOME/.maestro/bin" >> $GITHUB_PATH
-
-      - name: Select Xcode
-        run: sudo xcode-select -switch /Applications/Xcode.app
-
       - name: Cache Xcode build products
         uses: actions/cache@v4
         with:
           path: ios/build/Build/Products
           key: xcode-products-${{ runner.os }}-${{ hashFiles('ios/Podfile.lock', 'yarn.lock') }}
           restore-keys: xcode-products-${{ runner.os }}-
 
+      - name: Select Xcode
+        run: sudo xcode-select -switch /Applications/Xcode.app
+
       - name: Build iOS app for simulator
         env:
           SENTRY_DISABLE_AUTO_UPLOAD: true
@@ -97,16 +85,51 @@ jobs:
             SWIFT_ACTIVE_COMPILATION_CONDITIONS="DEBUG MAESTRO" \
             build
 
+      - name: Upload app artifact
+        uses: actions/upload-artifact@v5
+        with:
+          name: ios-app-simulator
+          path: ios/build/Build/Products/Debug-iphonesimulator/BitPayApp.app
+          retention-days: 1
+
+  test-ios:
+    name: E2E iOS Smoke
+    needs: build-ios
+    runs-on: macos-latest
+    timeout-minutes: 30
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v5
+
+      - name: Download app artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: ios-app-simulator
+          path: BitPayApp.app
+
+      - name: Cache Maestro
+        uses: actions/cache@v4
+        with:
+          path: ~/.maestro
+          key: maestro-${{ runner.os }}
+          restore-keys: maestro-${{ runner.os }}
+
+      - name: Install Maestro
+        run: |
+          curl -Ls "https://get.maestro.mobile.dev" | bash
+          echo "$HOME/.maestro/bin" >> $GITHUB_PATH
+
       - name: Boot simulator
         run: |
           UDID=$(xcrun simctl list devices available | grep "iPhone 16" | head -1 | grep -E -o '\(([0-9A-F-]+)\)' | tr -d '()')
           xcrun simctl boot "$UDID"
+          # Wait until simulator is fully booted before proceeding
+          xcrun simctl bootstatus "$UDID" -b
           echo "SIMULATOR_UDID=$UDID" >> $GITHUB_ENV
 
       - name: Install app on simulator
-        run: |
-          APP_PATH=$(find ios/build -name "*.app" | head -1)
-          xcrun simctl install "$SIMULATOR_UDID" "$APP_PATH"
+        run: xcrun simctl install "$SIMULATOR_UDID" BitPayApp.app
 
       - name: Run Maestro smoke tests
         run: maestro test .maestro/flows/ --format junit --output maestro-results.xml
@@ -130,4 +153,3 @@ jobs:
           name: maestro-ios-screenshots
           path: ~/.maestro/tests/**/*.png
           retention-days: 7
-