Fix recording quality and usability issues

- Fix process cleanup: Use bg.terminate() instead of manual kill for proper tree termination
- Fix buffering: Add stdbuf -o0 to cat and tail commands for real-time output
- Fix cursor artifacts: Restore cursor position and visibility when switching panes
- Fix trailing newlines: Strip newlines from pane dumps to prevent unwanted scrolling
- Show recording path: Display cast file path when stopping recordings for easy playback

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: bitplane

.gitignore

@@ -6,4 +6,4 @@ dist
 coverage.json
 .cache
 CLAUDE.local.md
-docs/pydoc.md
+docs/pydoc

pyproject.toml

@@ -26,7 +26,8 @@ dev = [
     "pytest-cov",
     "build",
     "twine",
-    "ruff"
+    "ruff",
+    "pydoc-markdown"
 ]
 
 [build-system]

scripts/docs.sh

@@ -1,12 +1,58 @@
-#!/usr/bin/bash
-
-source .venv/bin/activate
+#!/bin/sh
 
 set -e
 
-pushd src
-pydoc-markdown -p "$1" > ../docs/pydoc.md
-popd
+# Variables
+PROJECT_NAME=$(basename "$(pwd)")
+REPO_URL="ssh://git@github.com/bitplane/bitplane.net.git"
+SRC_PATH="docs"
+DEST_PATH="dev/python/$PROJECT_NAME"
+COMMIT_MSG="Update $PROJECT_NAME docs"
+
+# Build the pydocs
+. .venv/bin/activate
+
+mkdir -p docs/pydoc
+cd src
+pydoc-markdown -p "$PROJECT_NAME" > ../docs/pydoc/index.md
+cd ..
+
+# Check out the main website repo
+TMP_DIR=$(mktemp -d)
+
+# Cleanup on exit
+cleanup() {
+    echo "Cleaning up..."
+    rm -rf "$TMP_DIR"
+}
+trap cleanup EXIT
+
+# Clone the repository
+echo "Cloning $REPO_URL into $TMP_DIR..."
+git clone --depth=1 "$REPO_URL" "$TMP_DIR"
+
+# Set up the destination path
+FULL_DEST_PATH="$TMP_DIR/$DEST_PATH"
+
+# Copy files from source to destination
+echo "Copying files from $SRC_PATH to $FULL_DEST_PATH..."
+mkdir -p "$FULL_DEST_PATH"
+cp -r "$SRC_PATH/." "$FULL_DEST_PATH/"
+
+# Remove symlinks in the destination
+echo "Removing symlinks in $FULL_DEST_PATH..."
+find "$FULL_DEST_PATH" -type l -exec rm {} +
+
+# Replace symlinks with file contents
+echo "Replacing symlinks with file contents..."
+cd "$SRC_PATH"
+find . -type l -exec sh -c 'cat "$1" > "$2/$1"' _ {} "$FULL_DEST_PATH" \;
+
+# Commit and push
+echo "Committing and pushing changes..."
+cd "$TMP_DIR"
+git add "$DEST_PATH"
+git commit -m "$COMMIT_MSG"
+git push
 
-mkdocs build
-mkdocs gh-deploy
+echo "Docs published!"

src/tvmux/cli/record.py

@@ -138,7 +138,10 @@ def stop(recording_id):
             response = api.delete(f"/recordings/{recording_id}", timeout=10.0)
 
             if response.status_code == 200:
+                data = response.json()
                 click.echo(f"Stopped recording '{recording_id}'")
+                if 'cast_path' in data and data['cast_path']:
+                    click.echo(f"Recording saved to: {data['cast_path']}")
             elif response.status_code == 404:
                 click.echo(f"Recording '{recording_id}' not found", err=True)
                 raise click.Abort()
@@ -167,7 +170,10 @@ def stop(recording_id):
                 response = api.delete(f"/recordings/{rec_id}", timeout=10.0)
                 if response.status_code == 200:
                     stopped_count += 1
+                    data = response.json()
                     click.echo(f"Stopped recording '{rec_id}'")
+                    if 'cast_path' in data and data['cast_path']:
+                        click.echo(f"Recording saved to: {data['cast_path']}")
                 else:
                     click.echo(f"Failed to stop recording '{rec_id}': {response.text}", err=True)
 

src/tvmux/models/recording.py

@@ -176,7 +176,7 @@ async def _start_asciinema(self):
         """Start asciinema process."""
         cmd = [
             "asciinema", "rec", "--stdin", "--quiet", "--overwrite",
-            str(self.cast_path), "--command", f"tail -f {self.fifo_path}"
+            str(self.cast_path), "--command", f"stdbuf -o0 tail -f {self.fifo_path}"
         ]
 
         proc = await run_bg(cmd)
@@ -192,17 +192,46 @@ async def _wait_for_reader(self) -> bool:
         return False
 
     def _dump_pane(self, pane_id: str):
-        """Dump current pane content and cursor position."""
+        """Dump current pane content and restore cursor position."""
         try:
+            pane_target = f"{self.session_id}:{self.window_id}.{pane_id}"
+
+            # Get cursor position and visibility
+            cursor_result = subprocess.run([
+                "tmux", "display-message", "-t", pane_target,
+                "-p", "#{cursor_x},#{cursor_y},#{cursor_flag}"
+            ], capture_output=True, text=True)
+
             # Get pane content
-            result = subprocess.run([
-                "tmux", "capture-pane", "-t", f"{self.session_id}:{self.window_id}.{pane_id}",
+            content_result = subprocess.run([
+                "tmux", "capture-pane", "-t", pane_target,
                 "-e", "-p"
             ], capture_output=True, text=True)
 
-            if result.returncode == 0:
+            if content_result.returncode == 0:
                 with open(self.fifo_path, "w") as f:
-                    f.write(result.stdout)
+                    # Write content without trailing newline
+                    content = content_result.stdout.rstrip('\n')
+                    f.write(content)
+
+                    # Restore cursor position and visibility if we got it
+                    if cursor_result.returncode == 0:
+                        try:
+                            cursor_x, cursor_y, cursor_flag = cursor_result.stdout.strip().split(',')
+                            # Convert to 1-based coordinates for ANSI escape
+                            row = int(cursor_y) + 1
+                            col = int(cursor_x) + 1
+                            f.write(f"\033[{row};{col}H")
+
+                            # Restore cursor visibility (1=visible, 0=hidden)
+                            if int(cursor_flag) == 1:
+                                f.write("\033[?25h")  # Show cursor
+                            else:
+                                f.write("\033[?25l")  # Hide cursor
+
+                        except (ValueError, IndexError):
+                            logger.warning(f"Failed to parse cursor info: {cursor_result.stdout}")
+
                     f.flush()
         except Exception as e:
             logger.warning(f"Failed to dump pane {pane_id}: {e}")
@@ -212,7 +241,7 @@ def _start_streaming(self, pane_id: str):
         try:
             subprocess.run([
                 "tmux", "pipe-pane", "-t", f"{self.session_id}:{self.window_id}.{pane_id}",
-                f"cat >> {self.fifo_path}"
+                f"stdbuf -o0 cat >> {self.fifo_path}"
             ], check=True)
         except subprocess.CalledProcessError as e:
             logger.error(f"Failed to start streaming for pane {pane_id}: {e}")

src/tvmux/server/routers/recording.py

@@ -123,6 +123,7 @@ async def delete_recording(recording_id: str) -> dict:
         raise HTTPException(status_code=404, detail="Recording not found")
 
     recording = recorders[recording_id]
+    cast_path = recording.cast_path  # Get path before stopping
     recording.stop()
 
     # Remove from active recorders
@@ -134,7 +135,7 @@ async def delete_recording(recording_id: str) -> dict:
         # Schedule shutdown after a brief delay to allow response to be sent
         asyncio.create_task(_shutdown_server_delayed())
 
-    return {"status": "stopped", "recording_id": recording_id}
+    return {"status": "stopped", "recording_id": recording_id, "cast_path": cast_path}
 
 
 async def _shutdown_server_delayed():