fix: update release workflow to use version input and improve tagging process

Author: jimzer

.github/workflows/release.yaml

@@ -1,28 +1,23 @@
 name: Build and Release
 
 on:
-  push:
-    tags: ["*"]
-  pull_request:
   workflow_dispatch:
+    inputs:
+      version:
+        description: "Version to release (e.g., 0.1.0)"
+        required: true
+        type: string
 
 permissions:
-  contents: read
-  id-token: write # For PyPI OIDC publishing
-  attestations: write # For artifact attestation
+  contents: write # Changed to write for tagging
+  id-token: write
+  attestations: write
 
 jobs:
   build-wheels-linux:
     runs-on: ${{ matrix.platform.runner }}
     steps:
       - uses: actions/checkout@v4
-      - name: Wait for tests to succeed
-        uses: lewagon/wait-on-check-action@v1.4.1
-        with:
-          ref: ${{ github.ref }}
-          check-name: test
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          wait-interval: 10
       - uses: actions/setup-python@v5
         with:
           python-version: 3.x
@@ -41,7 +36,7 @@ jobs:
           working-directory: kiru-py
           target: ${{ matrix.platform.target }}
           args: --release --out dist --find-interpreter
-          sccache: ${{ !startsWith(github.ref, 'refs/tags/') }}
+          sccache: "true"
           manylinux: auto
       - name: Upload wheels
         uses: actions/upload-artifact@v4
@@ -68,13 +63,6 @@ jobs:
     runs-on: ${{ matrix.platform.runner }}
     steps:
       - uses: actions/checkout@v4
-      - name: Wait for tests to succeed
-        uses: lewagon/wait-on-check-action@v1.4.1
-        with:
-          ref: ${{ github.ref }}
-          check-name: test
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          wait-interval: 10
       - uses: actions/setup-python@v5
         with:
           python-version: 3.x
@@ -93,7 +81,7 @@ jobs:
           working-directory: kiru-py
           target: ${{ matrix.platform.target }}
           args: --release --out dist --find-interpreter
-          sccache: ${{ !startsWith(github.ref, 'refs/tags/') }}
+          sccache: "true"
           manylinux: musllinux_1_2
       - name: Upload wheels
         uses: actions/upload-artifact@v4
@@ -116,13 +104,6 @@ jobs:
     runs-on: ${{ matrix.platform.runner }}
     steps:
       - uses: actions/checkout@v4
-      - name: Wait for tests to succeed
-        uses: lewagon/wait-on-check-action@v1.4.1
-        with:
-          ref: ${{ github.ref }}
-          check-name: test
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          wait-interval: 10
       - uses: actions/setup-python@v5
         with:
           python-version: 3.x
@@ -142,7 +123,7 @@ jobs:
           working-directory: kiru-py
           target: ${{ matrix.platform.target }}
           args: --release --out dist --find-interpreter
-          sccache: ${{ !startsWith(github.ref, 'refs/tags/') }}
+          sccache: "true"
       - name: Upload wheels
         uses: actions/upload-artifact@v4
         with:
@@ -160,13 +141,6 @@ jobs:
     runs-on: ${{ matrix.platform.runner }}
     steps:
       - uses: actions/checkout@v4
-      - name: Wait for tests to succeed
-        uses: lewagon/wait-on-check-action@v1.4.1
-        with:
-          ref: ${{ github.ref }}
-          check-name: test
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          wait-interval: 10
       - uses: actions/setup-python@v5
         with:
           python-version: 3.x
@@ -185,7 +159,7 @@ jobs:
           working-directory: kiru-py
           target: ${{ matrix.platform.target }}
           args: --release --out dist --find-interpreter
-          sccache: ${{ !startsWith(github.ref, 'refs/tags/') }}
+          sccache: "true"
       - name: Upload wheels
         uses: actions/upload-artifact@v4
         with:
@@ -203,13 +177,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Wait for tests to succeed
-        uses: lewagon/wait-on-check-action@v1.4.1
-        with:
-          ref: ${{ github.ref }}
-          check-name: test
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          wait-interval: 10
       - uses: actions/setup-python@v5
         with:
           python-version: 3.x
@@ -229,13 +196,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Wait for tests to succeed
-        uses: lewagon/wait-on-check-action@v1.4.1
-        with:
-          ref: ${{ github.ref }}
-          check-name: test
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          wait-interval: 10
       - name: Install Rust
         uses: dtolnay/rust-toolchain@stable
       - name: Package kiru-core
@@ -248,7 +208,6 @@ jobs:
 
   release:
     runs-on: ubuntu-latest
-    if: startsWith(github.ref, 'refs/tags/')
     needs:
       [
         build-wheels-linux,
@@ -264,18 +223,13 @@ jobs:
       attestations: write
     steps:
       - uses: actions/checkout@v4
-      - name: Wait for tests to succeed
-        uses: lewagon/wait-on-check-action@v1.4.1
         with:
-          ref: ${{ github.ref }}
-          check-name: test
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          wait-interval: 10
+          fetch-depth: 0 # Need full history for tagging
       - uses: actions/download-artifact@v4
       - name: Generate artifact attestation
         uses: actions/attest-build-provenance@v2
         with:
-          subject-path: "wheels-*/*"
+          subject-path: "wheels-*/*,crate-kiru-core/*"
       - name: Publish kiru-core to crates.io
         env:
           CARGO_REGISTRY_TOKEN: ${{ secrets.CRATES_IO_TOKEN }}
@@ -291,6 +245,14 @@ jobs:
       - name: Create GitHub Release
         uses: softprops/action-gh-release@v2
         with:
+          tag_name: v${{ inputs.version }}
+          name: Release v${{ inputs.version }}
           files: |
             wheels-*/*
             crate-kiru-core/*
+      - name: Create and push tag
+        run: |
+          git config user.name "github-actions[bot]"
+          git config user.email "github-actions[bot]@users.noreply.github.com"
+          git tag v${{ inputs.version }} -m "Release v${{ inputs.version }}"
+          git push origin v${{ inputs.version }}

.github/workflows/test.yaml

@@ -3,21 +3,27 @@ name: Test
 on:
   push:
     branches: [main]
-    tags: ["*"]
   pull_request:
   workflow_dispatch:
 
 jobs:
   check-version:
-    name: python
+    name: check-version
     runs-on: ubuntu-latest
+    outputs:
+      version: ${{ steps.get-version.outputs.version }}
     steps:
       - uses: actions/checkout@v5
       - name: Install uv
         uses: astral-sh/setup-uv@v6
-
-      - name: Run tests
+      - name: Run version checks
         run: uv run utils/check_version_sync.py && uv run utils/check_version_newer.py
+      - name: Get version
+        id: get-version
+        run: |
+          VERSION=$(uv run utils/get_version.py)
+          echo "version=$VERSION" >> $GITHUB_OUTPUT
+          echo "Version: $VERSION"
 
   test:
     name: test
@@ -38,37 +44,50 @@ jobs:
             target
           key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
           restore-keys: ${{ runner.os }}-cargo-
-
       - name: Format check
         run: cargo fmt --all -- --check
-
       - name: Clippy
         run: cargo clippy --workspace --all-targets -- -D warnings
-
       - name: Rust tests
         run: cargo test --workspace
-
       - name: Install uv
         run: curl -LsSf https://astral.sh/uv/install.sh | sh
-
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
           python-version: "3.13"
-
       - name: Install maturin
         run: uv tool install maturin
-
       - name: Build and install package
         working-directory: kiru-py
         run: |
           uv venv
           source .venv/bin/activate
           maturin develop --release
-
       - name: Run Python tests
         working-directory: kiru-py
         run: |
           source .venv/bin/activate
           uv sync --dev
           uv run pytest python/test.py
+
+  trigger-release:
+    name: trigger-release
+    runs-on: ubuntu-latest
+    needs: [check-version, test]
+    if: github.event_name == 'push' && github.ref == 'refs/heads/main'
+    steps:
+      - name: Trigger release workflow
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            await github.rest.actions.createWorkflowDispatch({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              workflow_id: 'release.yaml',
+              ref: 'main',
+              inputs: {
+                version: '${{ needs.check-version.outputs.version }}'
+              }
+            });

justfile

@@ -10,5 +10,3 @@ check-version:
 bump-version version:
     uv run utils/bump_version.py {{version}}
 
-tag-version *args:
-    uv run utils/tag_version.py {{args}}

utils/get_version.py

@@ -0,0 +1,20 @@
+# utils/tag_version.py
+# /// script
+# dependencies = [
+#   "tomlkit",
+# ]
+# ///
+from pathlib import Path
+
+import tomlkit
+
+
+def get_current_version() -> str:
+    """Get version from kiru-py/Cargo.toml"""
+    py_toml = Path("kiru-py/Cargo.toml")
+    with open(py_toml) as f:
+        return tomlkit.load(f)["package"]["version"]
+
+
+if __name__ == "__main__":
+    print(get_current_version())