From d3f8306c44b1fe3808f82e740b5c41f2b51641c7 Mon Sep 17 00:00:00 2001 From: Matt Bishop Date: Mon, 29 Jun 2026 14:59:16 -0400 Subject: [PATCH] llm: remove redundant repo-root Claude permission deny list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removes the permissions.deny list from the repo-root .claude/settings.json. The identical block in plugins/bitwarden-code-review/.claude/settings.json — the copy that ships with the plugin — is kept. The repo-root copy (added in #14 alongside the plugin copy, out of stated uncertainty about which layer enforces) only applies to interactive sessions whose CWD is this repo. The code-review agent runs in product repos, so this copy never constrained the agent; its actual hardening comes from the agent tools: allowlist and the plugin-level deny list, both unchanged. The repo-root copy's only effect was maintainer friction (e.g. gh pr edit), and it had drifted from the plugin copy refined in #22. A backstop for interactive sessions belongs at user-level or enterprise-managed settings, applied uniformly — not checked into one repo. --- .claude/settings.json | 44 ------------------------------------------- 1 file changed, 44 deletions(-) diff --git a/.claude/settings.json b/.claude/settings.json index d8f84640..671a0844 100644 --- a/.claude/settings.json +++ b/.claude/settings.json @@ -2,49 +2,5 @@ "attribution": { "commit": "", "pr": "" - }, - "permissions": { - "deny": [ - "Bash(gh pr merge:*)", - "Bash(gh pr close:*)", - "Bash(gh pr edit:*)", - "Bash(gh pr lock:*)", - "Bash(gh pr unlock:*)", - "Bash(gh pr reopen:*)", - "Bash(gh pr ready:*)", - "Bash(gh pr checkout:*)", - "Bash(gh issue create:*)", - "Bash(gh issue close:*)", - "Bash(gh issue reopen:*)", - "Bash(gh issue edit:*)", - "Bash(gh issue delete:*)", - "Bash(gh issue lock:*)", - "Bash(gh issue unlock:*)", - "Bash(gh issue transfer:*)", - "Bash(gh issue pin:*)", - "Bash(gh issue unpin:*)", - "Bash(gh repo edit:*)", - "Bash(gh repo archive:*)", - "Bash(gh repo delete:*)", - "Bash(gh repo rename:*)", - "Bash(gh repo sync:*)", - "Bash(gh repo create:*)", - "Bash(gh repo fork:*)", - "Bash(gh release:*)", - "Bash(gh secret:*)", - "Bash(gh org:*)", - "Bash(gh workflow:*)", - "Bash(gh run rerun:*)", - "Bash(gh run cancel:*)", - "Bash(gh run delete:*)", - "Bash(gh run watch:*)", - "Bash(gh api:*DELETE:*)", - "Bash(gh api:*PATCH:*)", - "Bash(gh api:*PUT:*)", - "Bash(gh api:*POST*/merge:*)", - "Bash(gh api graphql:*mutation:*)", - "Bash(gh api graphql:*Mutation:*)", - "Bash(gh api:*graphql* -f query=*mutation:*)" - ] } }