paddle bounce complete

Author: bitwes

TddAndPong/Episode3/scripts/paddle.gd

@@ -1,2 +1,4 @@
 func bounce(ball):
-	ball.set_direction(ball.get_direction() * Vector2(-1, 1))
+	var new_y = rand_range(-.5, .5)
+	var new_x = ball.get_direction().x * -1
+	ball.set_direction(Vector2(new_x, new_y))

TddAndPong/Episode3/test/unit/test_paddle.gd

@@ -12,18 +12,45 @@ func test_bounce_inverts_x():
 
 	stub(ball, 'get_direction').to_return(Vector2(1, 1))
 	paddle.bounce(ball)
-	assert_called(ball, 'set_direction', [Vector2(-1, 1)])	
+	var new_x =  get_call_parameters(ball, 'set_direction')[0].x
+	assert_eq(new_x, -1.0)
+
 
 func test_bounce_inverts_x_other_direction():
 	var ball = double(Ball).new()
 	var paddle = Paddle.new()
 
 	stub(ball, 'get_direction').to_return(Vector2(-1, 1))
 	paddle.bounce(ball)
-	assert_called(ball, 'set_direction', [Vector2(1, 1)])	
+	var new_x =  get_call_parameters(ball, 'set_direction')[0].x
+	assert_eq(new_x, 1.0)
 
 func test_bounce_changes_y_randomly():
 	var paddle = Paddle.new()
 	var ball = double(Ball).new()
 	stub(ball, 'get_direction').to_return(Vector2(1, 1))
-	
+	stub(ball, 'set_direction').to_do_nothing()
+	
+	for i in range(1000):
+		paddle.bounce(ball)
+		
+	var last_y = get_call_parameters(ball, 'set_direction', 0)[0].y
+	var current_y = 0
+	var num_equal = 0
+	var min_y = 3
+	var max_y = -3
+	for i in range(1, 1000):
+		current_y = get_call_parameters(ball, 'set_direction', i)[0].y
+		if(current_y == last_y):
+			num_equal += 1
+		last_y = current_y
+		
+		max_y = max(max_y, current_y)
+		min_y = min(min_y, current_y)
+		
+	assert_eq(num_equal, 0)
+	
+	assert_between(min_y, -.5, -.3)
+	assert_between(max_y, .3, .5)
+		
+