feat: make base URL more easily overridable in the generated reference client

Author: maxholman

__tests__/fixtures/openai/main.ts

@@ -3,7 +3,7 @@
  *
  * WARN: Do not edit directly.
  *
- * Generated on 2023-04-28T12:24:57.414Z
+ * Generated on 2023-04-29T03:20:30.391Z
  *
  */
 import {
@@ -122,9 +122,10 @@ export class OpenAiApiRestClient extends RestServiceClient<
   AllOutputs
 > {
   constructor(
+    baseUrl = new URL('https://api.openai.com/v1/'),
     fetcher = createIsomorphicFetcher(),
     config?: RestServiceClientConfig,
   ) {
-    super(new URL('https://api.openai.com/v1/'), fetcher, config);
+    super(baseUrl, fetcher, config);
   }
 }

__tests__/fixtures/petstore/main.ts

@@ -3,7 +3,7 @@
  *
  * WARN: Do not edit directly.
  *
- * Generated on 2023-04-28T12:24:51.108Z
+ * Generated on 2023-04-29T03:20:23.373Z
  *
  */
 import {
@@ -31,9 +31,10 @@ export class SwaggerPetstoreRestClient extends RestServiceClient<
   AllOutputs
 > {
   constructor(
+    baseUrl = new URL('http://petstore.swagger.io/api/'),
     fetcher = createIsomorphicFetcher(),
     config?: RestServiceClientConfig,
   ) {
-    super(new URL('http://petstore.swagger.io/api/'), fetcher, config);
+    super(baseUrl, fetcher, config);
   }
 }

__tests__/fixtures/test1/main.ts

@@ -3,7 +3,7 @@
  *
  * WARN: Do not edit directly.
  *
- * Generated on 2023-04-28T12:24:53.479Z
+ * Generated on 2023-04-29T03:20:25.967Z
  *
  */
 import {
@@ -78,9 +78,10 @@ export class BillingServiceRestApiRestClient extends RestServiceClient<
   AllOutputs
 > {
   constructor(
+    baseUrl = new URL('https://api.example.com/'),
     fetcher = createIsomorphicFetcher(),
     config?: RestServiceClientConfig,
   ) {
-    super(new URL('https://api.example.com/'), fetcher, config);
+    super(baseUrl, fetcher, config);
   }
 }

__tests__/index.test.ts

@@ -3,28 +3,29 @@ import { CreateModerationCommand } from './fixtures/openai/commands.js';
 import { OpenAiApiRestClient } from './fixtures/openai/main.js';
 import { FindPetsCommand } from './fixtures/petstore/commands.js';
 import { SwaggerPetstoreRestClient } from './fixtures/petstore/main.js';
-import { logger } from './logger.js';
-
-export const petStoreClient = new SwaggerPetstoreRestClient();
-export const openAiClient = new OpenAiApiRestClient();
 
 test('PetStore FindPets', async () => {
+  const petStoreClient = new SwaggerPetstoreRestClient(
+    new URL('http://invalid'),
+  );
   const command = new FindPetsCommand({
     limit: '10',
     tags: ['tag1', 'tag2'],
   });
 
-  const result = await petStoreClient.send(command).catch(logger.error);
+  const result = await petStoreClient.json(command).catch((err) => err);
 
   expect(result).toBeTruthy();
 });
 
-test('PetStore FindPets', async () => {
+test('OpenAI CreateModeration', async () => {
+  const openAiClient = new OpenAiApiRestClient(new URL('http://invalid'));
+
   const command = new CreateModerationCommand({
     input: 'This is a test',
   });
 
-  const result = await openAiClient.send(command).catch(logger.error);
+  const result = await openAiClient.json(command).catch((err) => err);
 
   expect(result).toBeTruthy();
 });

lib/process-document.ts

@@ -675,6 +675,13 @@ export async function processOpenApiDocument(
 
   const ctor = clientClassDeclaration.addConstructor();
 
+  const baseUrl = ctor.addParameter({
+    name: 'baseUrl',
+    initializer: `new URL('${new URL(
+      `${schema.servers?.[0]?.url || 'https://api.example.com'}/`,
+    )}')`,
+  });
+
   const fetcherParam = ctor.addParameter({
     name: 'fetcher',
     // type: fetcherMethodType,
@@ -694,9 +701,7 @@ export async function processOpenApiDocument(
     SyntaxKind.CallExpression,
   );
   callExpr?.addArguments([
-    `new URL('${new URL(
-      `${schema.servers?.[0]?.url || 'https://api.example.com'}/`,
-    )}')`,
+    baseUrl.getName(),
     fetcherParam.getName(),
     configParam.getName(),
   ]);