Merge pull request #71 from blocknotes/api/delete-return-if-file-gets-deleted

#delete returns if the file has been deleted

Author: blocknotes

lib/active_storage/service/db_service.rb

@@ -57,8 +57,10 @@ def download_chunk(key, range)
 
     def delete(key)
       instrument :delete, key: key do
-        ::ActiveStorageDB::File.find_by(ref: key)&.destroy
-        # Ignore files already deleted
+        record = ::ActiveStorageDB::File.find_by(ref: key)
+        record&.destroy
+        # NOTE: Ignore files already deleted
+        !record.nil?
       end
     end
 

spec/service/active_storage/service/db_service_spec.rb

@@ -85,9 +85,17 @@
 
     before { upload }
 
+    it { is_expected.to be_truthy }
+
     it 'deletes the file' do
       expect { delete }.to change(ActiveStorageDB::File, :count).from(1).to(0)
     end
+
+    context "when the attachment is not found" do
+      subject(:delete) { service.delete("#{key}!") }
+
+      it { is_expected.to be_falsey }
+    end
   end
 
   describe '.delete_prefixed' do