ci: Fix lints

We were missing the lint setup between the main kit crate
and the workspace. Fix up the resulting warnings.

Signed-off-by: Colin Walters <walters@verbum.org>

Author: cgwalters

.github/workflows/main.yml

@@ -48,7 +48,7 @@ jobs:
         uses: Swatinem/rust-cache@v2
 
       - name: Build
-        run: just check && just build
+        run: just validate && just build
 
       - name: Run unit tests
         run: just unit

Cargo.toml

@@ -21,6 +21,7 @@ unused_must_use = "forbid"
 missing_docs = "deny"
 missing_debug_implementations = "deny"
 # Feel free to comment this one out locally during development of a patch.
+unused_imports = "deny"
 dead_code = "deny"
 
 [workspace.lints.clippy]

Justfile

@@ -2,10 +2,9 @@
 build:
    make
 
-# Quick checks
-check:
-    cargo t --workspace --no-run
-    cargo fmt --check
+# Static checks
+validate:
+    make validate
 
 # Run unit tests (excludes integration tests)
 unit *ARGS:

Makefile

@@ -36,6 +36,19 @@ manpages: sync-cli-options $(MAN8_TARGETS)
 sync-cli-options:
 	@cargo xtask sync-manpages >/dev/null 2>&1 || true
 
+# This gates CI by default. Note that for clippy, we gate on
+# only the clippy correctness and suspicious lints, plus a select
+# set of default rustc warnings.
+# We intentionally don't gate on this for local builds in cargo.toml
+# because it impedes iteration speed.
+CLIPPY_CONFIG = -A clippy::all -D clippy::correctness -D clippy::suspicious -D clippy::disallowed-methods -Dunused_imports -Ddead_code
+validate:
+	cargo fmt -- --check -l
+	cargo test --no-run --workspace
+	cargo clippy -- $(CLIPPY_CONFIG)
+	env RUSTDOCFLAGS='-D warnings' cargo doc --lib
+.PHONY: validate
+
 install:
 	install -D -m 0755 -t $(DESTDIR)$(prefix)/bin target/release/bcvk
 	if [ -n "$(MAN8_TARGETS)" ]; then \

crates/integration-tests/Cargo.toml

@@ -33,3 +33,6 @@ uuid = { version = "1.18.1", features = ["v4"] }
 camino = "1.1.12"
 regex = "1"
 linkme = "0.3.30"
+
+[lints]
+workspace = true

crates/integration-tests/src/bin/cleanup.rs

@@ -1,3 +1,7 @@
+//! Cleanup utility for integration test resources
+//!
+//! This binary removes integration test containers and libvirt VMs that were created during testing.
+
 use std::process::Command;
 
 // Import shared constants from the library

crates/integration-tests/src/lib.rs

@@ -20,11 +20,14 @@ pub type TestFn = fn() -> color_eyre::Result<()>;
 /// Metadata for a registered integration test
 #[derive(Debug)]
 pub struct IntegrationTest {
+    /// Name of the integration test
     pub name: &'static str,
+    /// Test function to execute
     pub f: TestFn,
 }
 
 impl IntegrationTest {
+    /// Create a new integration test with the given name and function
     pub const fn new(name: &'static str, f: TestFn) -> Self {
         Self { name, f }
     }

crates/integration-tests/src/main.rs

@@ -1,3 +1,5 @@
+//! Integration tests for bcvk
+
 use camino::Utf8Path;
 use std::process::Output;
 

crates/kit/Cargo.toml

@@ -57,3 +57,5 @@ similar-asserts = "1.5"
 # Implementation detail of man page generation.
 docgen = ["clap_mangen"]
 
+[lints]
+workspace = true

crates/kit/src/libvirt/list_volumes.rs

@@ -344,8 +344,6 @@ impl LibvirtListVolumesOpts {
     }
 }
 
-/// Extract value from XML element (simple string parsing)
-
 /// Parse virsh size format (e.g., "5.00 GiB") to bytes
 fn parse_virsh_size(size_str: &str) -> Option<u64> {
     let parts: Vec<&str> = size_str.split_whitespace().collect();