Update workspace to Rust edition 2024

Migrate all crates from edition 2021 to 2024. This includes
updating Cargo.toml files and fixing code compatibility issues.

The MSRV is bumped to 1.85.0 to support edition 2024.

Note: global_init() requires #[allow(unsafe_code)] for
std::env::set_var which is now unsafe in edition 2024.
This is safe because the function is called early in main()
before any threads are spawned.

Closes: #1414

Signed-off-by: Daniele Guarascio <guarascio.daniele@gmail.com>

Author: Guara92

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 description = "Internal implementation component of bootc; do not use"
-edition = "2021"
+edition = "2024"
 license = "MIT OR Apache-2.0"
 name = "bootc-internal-blockdev"
 repository = "https://github.com/bootc-dev/bootc"
@@ -27,4 +27,4 @@ tracing = { workspace = true }
 indoc = { workspace = true }
 
 [lib]
-path = "src/blockdev.rs"
+path = "src/blockdev.rs"

crates/blockdev/Cargo.toml

@@ -4,7 +4,7 @@ use std::path::Path;
 use std::process::{Command, Stdio};
 use std::sync::OnceLock;
 
-use anyhow::{anyhow, Context, Result};
+use anyhow::{Context, Result, anyhow};
 use camino::{Utf8Path, Utf8PathBuf};
 use fn_error_context::context;
 use regex::Regex;

crates/blockdev/src/blockdev.rs

@@ -2,7 +2,7 @@
 name = "bootc"
 # This is a stub, the real version is from the lib crate
 version = "0.0.0"
-edition = "2021"
+edition = "2024"
 license = "MIT OR Apache-2.0"
 repository = "https://github.com/bootc-dev/bootc"
 publish = false

crates/cli/Cargo.toml

@@ -2,7 +2,7 @@
 name = "bootc-initramfs-setup"
 version = "0.1.0"
 license = "MIT OR Apache-2.0"
-edition = "2021"
+edition = "2024"
 publish = false
 
 [dependencies]

crates/initramfs/Cargo.toml

@@ -11,11 +11,11 @@ use std::{
 use anyhow::{Context, Result};
 use clap::Parser;
 use rustix::{
-    fs::{major, minor, mkdirat, openat, stat, symlink, Mode, OFlags, CWD},
+    fs::{CWD, Mode, OFlags, major, minor, mkdirat, openat, stat, symlink},
     io::Errno,
     mount::{
-        fsconfig_create, fsconfig_set_string, fsmount, open_tree, unmount, FsMountFlags,
-        MountAttrFlags, OpenTreeFlags, UnmountFlags,
+        FsMountFlags, MountAttrFlags, OpenTreeFlags, UnmountFlags, fsconfig_create,
+        fsconfig_set_string, fsmount, open_tree, unmount,
     },
     path,
 };

crates/initramfs/src/lib.rs

@@ -3,7 +3,7 @@
 
 use anyhow::Result;
 
-use bootc_initramfs_setup::{gpt_workaround, setup_root, Args};
+use bootc_initramfs_setup::{Args, gpt_workaround, setup_root};
 use clap::Parser;
 
 fn main() -> Result<()> {

crates/initramfs/src/main.rs

@@ -2,7 +2,7 @@
 name = "bootc-kernel-cmdline"
 description = "Kernel command line parsing utilities for bootc"
 version = "0.0.0"
-edition = "2021"
+edition = "2024"
 license = "MIT OR Apache-2.0"
 repository = "https://github.com/bootc-dev/bootc"
 
@@ -16,4 +16,4 @@ similar-asserts = { workspace = true }
 static_assertions = { workspace = true }
 
 [lints]
-workspace = true
+workspace = true

crates/kernel_cmdline/Cargo.toml

@@ -7,7 +7,7 @@ use std::borrow::Cow;
 use std::cmp::Ordering;
 use std::ops::Deref;
 
-use crate::{utf8, Action};
+use crate::{Action, utf8};
 
 use anyhow::Result;
 use serde::{Deserialize, Serialize};
@@ -842,15 +842,17 @@ mod tests {
 
         // Test key without value should fail
         let err = kargs.require_value_of("switch").unwrap_err();
-        assert!(err
-            .to_string()
-            .contains("Failed to find kernel argument 'switch'"));
+        assert!(
+            err.to_string()
+                .contains("Failed to find kernel argument 'switch'")
+        );
 
         // Test non-existent key should fail
         let err = kargs.require_value_of("missing").unwrap_err();
-        assert!(err
-            .to_string()
-            .contains("Failed to find kernel argument 'missing'"));
+        assert!(
+            err.to_string()
+                .contains("Failed to find kernel argument 'missing'")
+        );
 
         // Test dash/underscore equivalence
         let kargs = Cmdline::from(b"dash-key=value1 under_key=value2".as_slice());

crates/kernel_cmdline/src/bytes.rs

@@ -5,7 +5,7 @@
 
 use std::ops::Deref;
 
-use crate::{bytes, Action};
+use crate::{Action, bytes};
 
 use anyhow::Result;
 use serde::{Deserialize, Serialize};
@@ -697,15 +697,17 @@ mod tests {
 
         // Test key without value should fail
         let err = kargs.require_value_of("switch").unwrap_err();
-        assert!(err
-            .to_string()
-            .contains("Failed to find kernel argument 'switch'"));
+        assert!(
+            err.to_string()
+                .contains("Failed to find kernel argument 'switch'")
+        );
 
         // Test non-existent key should fail
         let err = kargs.require_value_of("missing").unwrap_err();
-        assert!(err
-            .to_string()
-            .contains("Failed to find kernel argument 'missing'"));
+        assert!(
+            err.to_string()
+                .contains("Failed to find kernel argument 'missing'")
+        );
 
         // Test dash/underscore equivalence
         let kargs = Cmdline::from("dash-key=value1 under_key=value2");