Use Rails' configuration options

Author: lcreid

lib/bootstrap_form.rb

@@ -3,6 +3,7 @@
 require "action_view"
 require "action_pack"
 require "bootstrap_form/action_view_extensions/form_helper"
+require "bootstrap_form/configuration"
 
 module BootstrapForm
   extend ActiveSupport::Autoload
@@ -32,6 +33,10 @@ def config
     def configure
       yield config
     end
+
+    def deprecator
+      @deprecator ||= ActiveSupport::Deprecation.new("a future release", "BootstrapForm")
+    end
   end
 
   mattr_accessor :field_error_proc

lib/bootstrap_form/configuration.rb

@@ -7,7 +7,12 @@ def default_form_attributes=(attributes)
       when nil
         @default_form_attributes = {}
       when Hash
+        BootstrapForm.deprecator.warn(<<~MESSAGE.squish)
+          BootstrapForm::Configuation#default_form_attributes will be removed in a future release.
+          Please use Rails.application.config.bootstrap_form.default_form_attributes instead.
+        MESSAGE
         @default_form_attributes = attributes
+        Rails.application.config.bootstrap_form.default_form_attributes = attributes
       else
         raise ArgumentError, "Unsupported default_form_attributes #{attributes.inspect}"
       end
@@ -19,4 +24,12 @@ def default_form_attributes
       {}
     end
   end
+
+  mattr_accessor :configuration, default: nil
+
+  class << self
+    def configure
+      yield(configuration) if block_given?
+    end
+  end
 end

lib/bootstrap_form/engine.rb

@@ -6,5 +6,16 @@ module BootstrapForm
   class Engine < Rails::Engine
     config.eager_load_namespaces << BootstrapForm
     config.autoload_paths << File.expand_path("lib", __dir__)
+
+    config.bootstrap_form = ActiveSupport::OrderedOptions.new
+    config.bootstrap_form.default_form_attributes = {}
+
+    initializer "bootstrap_form.configure" do |app|
+      BootstrapForm.configuration = app.config.bootstrap_form
+    end
+
+    initializer "bootstrap_form.deprecator" do |app|
+      app.deprecators[:bootstrap_form] = BootstrapForm.deprecator
+    end
   end
 end

test/bootstrap_configuration_test.rb

@@ -3,6 +3,13 @@
 require_relative "test_helper"
 
 class BootstrapConfigurationTest < ActionView::TestCase
+  teardown do
+    # Unfortunately, it seems we have to manually reset each of the configuration options
+    # that we change in our test cases.
+    Rails.application.config.bootstrap_form.default_form_attributes = {}
+    Rails.application.config.bootstrap_form.bogon = nil
+  end
+
   test "has default form attributes" do
     config = BootstrapForm::Configuration.new
 
@@ -11,7 +18,9 @@ class BootstrapConfigurationTest < ActionView::TestCase
 
   test "allows to set default_form_attributes with custom value" do
     config = BootstrapForm::Configuration.new
-    config.default_form_attributes = { foo: "bar" }
+    assert_deprecated(BootstrapForm.deprecator) do
+      config.default_form_attributes = { foo: "bar" }
+    end
 
     assert_equal({ foo: "bar" }, config.default_form_attributes)
   end
@@ -31,4 +40,21 @@ class BootstrapConfigurationTest < ActionView::TestCase
     end
     assert_equal("Unsupported default_form_attributes [1, 2, 3]", exception.message)
   end
+
+  test "Use Rails configuration" do
+    assert_nil Rails.application.config.bootstrap_form.bogon
+    Rails.application.config.bootstrap_form.bogon = true
+    assert Rails.application.config.bootstrap_form.bogon
+  end
+
+  test "Support legacy configuration from Rails configuration" do
+    assert_equal({}, Rails.application.config.bootstrap_form.default_form_attributes)
+
+    config = BootstrapForm::Configuration.new
+    assert_deprecated(BootstrapForm.deprecator) do
+      config.default_form_attributes = { foo: "bar" }
+    end
+
+    assert_equal({ foo: "bar" }, Rails.application.config.bootstrap_form.default_form_attributes)
+  end
 end