Cleanup Async signatures to be consistent

Author: bordoley

SQLitePCL.pretty.Orm/TableMapping.Delete.cs

@@ -54,20 +54,29 @@ public static IReadOnlyDictionary<long,T> DeleteAll<T>(this IDatabaseConnection
                             .ToDictionary(kvp => kvp.Key, kvp => kvp.Value));
         }
 
-        public static Task<IReadOnlyDictionary<long,T>> DeleteAllAsync<T>(this IAsyncDatabaseConnection This, ITableMapping<T> tableMapping, IEnumerable<T> objects, CancellationToken ct)
+        public static Task<IReadOnlyDictionary<long,T>> DeleteAllAsync<T>(this IAsyncDatabaseConnection This, ITableMapping<T> tableMapping, IEnumerable<long> primaryKeys, CancellationToken ct)
         {
-            var primaryKeys = objects.Select(tableMapping.GetPrimaryKey);
             return This.Use((db,_) => db.DeleteAll<T>(tableMapping, primaryKeys), ct);
         }
 
+        public static Task<IReadOnlyDictionary<long,T>> DeleteAllAsync<T>(this IAsyncDatabaseConnection This, ITableMapping<T> tableMapping, IEnumerable<long> primaryKeys)
+        {
+            return This.DeleteAllAsync(tableMapping, primaryKeys, CancellationToken.None);
+        }
+
         public static void DeleteAllRows<T>(this IDatabaseConnection This, ITableMapping<T> tableMapping)
         {
             This.DeleteAll(tableMapping.TableName);
         }
 
+        public static Task DeleteAllRowsAsync<T>(this IAsyncDatabaseConnection This, ITableMapping<T> tableMapping, CancellationToken ct)
+        {
+            return This.Use((db, _) => db.DeleteAllRows(tableMapping), ct);
+        }
+
         public static Task DeleteAllRowsAsync<T>(this IAsyncDatabaseConnection This, ITableMapping<T> tableMapping)
         {
-            return This.Use(db => db.DeleteAllRows(tableMapping));
+            return This.DeleteAllRowsAsync(tableMapping, CancellationToken.None);
         }
     }
 }

SQLitePCL.pretty.Orm/TableMapping.cs

@@ -112,22 +112,21 @@ private static string PrimaryKeyColumn(this ITableMapping This)
             return primaryKeyColumn.GetValue(This, mapping => 
                 // Intentionally throw if the column doesn't have a primary key
                 mapping.Columns.Where(x => x.Value.Metadata.IsPrimaryKeyPart).Select(x => x.Key).First());
-        }
-
-        private static long GetPrimaryKey<T>(this ITableMapping<T> This, T obj)
-        {
-            var primaryKeyPropery = This.Columns[This.PrimaryKeyColumn()].Property;
-            return (long) primaryKeyPropery.GetValue(obj);
         } 
 
         public static void DropTable<T>(this IDatabaseConnection This, ITableMapping<T> tableMapping)
         {
             This.DropTable(tableMapping.TableName);
         }
 
+        public static Task DropTableAsync<T>(this IAsyncDatabaseConnection This, ITableMapping<T> tableMapping, CancellationToken ct)
+        {
+            return This.Use((db, _) => db.DropTable(tableMapping), ct);
+        }
+
         public static Task DropTableAsync<T>(this IAsyncDatabaseConnection This, ITableMapping<T> tableMapping)
         {
-            return This.Use(db => db.DropTable(tableMapping));
+            return This.DropTableAsync(tableMapping, CancellationToken.None);
         }
 
         public static ITableMapping<T> Create<T>()