From 7c65106f2ed37c320d9d2c92be71f05f4ad672a1 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 25 Oct 2022 23:22:04 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- bothub_cli/utils.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/bothub_cli/utils.py b/bothub_cli/utils.py index 0ce6746..763412c 100644 --- a/bothub_cli/utils.py +++ b/bothub_cli/utils.py @@ -193,7 +193,26 @@ def extract_dist_package(dist_file_path, target_dir=None): _target_dir = target_dir or '.' with tarfile.open(dist_file_path, 'r:gz') as tin: - tin.extractall(_target_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tin, _target_dir) def make_event(message):