Skip to content

Commit db7c182

Browse files
committed
Remove Unnecessary Code
Signed-off-by: Muhammad Raisul Islam Evan <raisul@appscode.com>
1 parent e2d9da6 commit db7c182

1 file changed

Lines changed: 2 additions & 26 deletions

File tree

memcache/memcache.go

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import (
2424
"errors"
2525
"fmt"
2626
"io"
27-
"k8s.io/klog/v2"
2827
"net"
2928
"strconv"
3029
"strings"
@@ -328,17 +327,14 @@ func (c *Client) getConn(addr net.Addr) (*conn, error) {
328327
func (c *Client) onItem(item *Item, fn func(*Client, *bufio.ReadWriter, *Item) error) error {
329328
addr, err := c.selector.PickServer(item.Key)
330329
if err != nil {
331-
klog.Errorf(err.Error())
332330
return err
333331
}
334332
cn, err := c.getConn(addr)
335333
if err != nil {
336-
klog.Errorf(err.Error())
337334
return err
338335
}
339336
defer cn.condRelease(&err)
340337
if err := fn(c, cn.rw, item); err != nil {
341-
klog.Errorf(err.Error())
342338
return err
343339
}
344340
return nil
@@ -449,8 +445,6 @@ func (c *Client) ping(addr net.Addr) error {
449445
return err
450446
}
451447

452-
klog.Infoln(string(line))
453-
454448
switch {
455449
case bytes.HasPrefix(line, versionPrefix):
456450
break
@@ -813,49 +807,31 @@ func (c *Client) authFunc(rw *bufio.ReadWriter, verb string, item *Item) error {
813807
return ErrMalformedKey
814808
}
815809
var err error
816-
if verb == "set" {
817-
klog.Infoln(verb, item.Key, item.Flags, item.Expiration, len(item.User)+len(item.Pass)+1, item.User, item.Pass)
818-
819-
_, err = fmt.Fprintf(rw, "%s %s %d %d %d\r\n%s %s\r\n",
820-
verb, item.Key, item.Flags, item.Expiration, len(item.User)+len(item.Pass)+1, item.User, item.Pass)
821-
if err != nil {
822-
klog.Errorf(err.Error())
823-
}
824-
}
810+
_, err = fmt.Fprintf(rw, "%s %s %d %d %d\r\n%s %s\r\n",
811+
verb, item.Key, item.Flags, item.Expiration, len(item.User)+len(item.Pass)+1, item.User, item.Pass)
825812
if err != nil {
826-
klog.Errorf(err.Error())
827813
return err
828814
}
829815
if err := rw.Flush(); err != nil {
830-
klog.Errorf(err.Error())
831816
return err
832817
}
833818
line, err := rw.ReadSlice('\n')
834819

835-
klog.Infoln(string(line))
836-
837820
if err != nil {
838-
klog.Errorf(err.Error())
839821
return err
840822
}
841823
switch {
842824
case bytes.Equal(line, resultStored):
843-
klog.Infoln("Okay")
844825
return nil
845826
case bytes.Equal(line, resultUnauthenticatedError):
846-
klog.Infoln("ErrNotAuthenticated")
847827
return ErrNotAuthenticated
848828
case bytes.Equal(line, resultAuthenticationFailure):
849-
klog.Infoln("ErrNotAuthenticated")
850829
return ErrNotAuthenticated
851830
case bytes.Equal(line, resultBadCommandFormat):
852-
klog.Infoln("ErrNotAuthenticated")
853831
return ErrNotAuthenticated
854832
case bytes.Equal(line, resultBadCommandFormatTermination):
855-
klog.Infoln("ErrNotAuthenticated")
856833
return ErrNotAuthenticated
857834
case bytes.Equal(line, resultBadAuthenticationTokenFormat):
858-
klog.Infoln("ErrNotAuthenticated")
859835
return ErrNotAuthenticated
860836
}
861837
return fmt.Errorf("memcache: unexpected response line from %q: %q", verb, string(line))

0 commit comments

Comments
 (0)