Log rotation (#308)

* Merged main with the location changes

* no ubx yet

* Revert "no ubx yet"

This reverts commit c872394.

* Let the logger do the rollover

* Ecef fix (#307)

* Merged main with the location changes

* no ubx yet

* Revert "no ubx yet"

This reverts commit c872394.

* fix ecef errors

no ubx yet

Revert "no ubx yet"

This reverts commit c872394.

Let the logger do the rollover

Author: mrosseel

python/PiFinder/main.py

@@ -764,38 +764,12 @@ def main(
             exit()
 
 
-def rotate_logs() -> Path:
-    """
-    Rotates log files, returns the log file to use
-    """
-    log_index = list(range(5))
-    log_index.reverse()
-    for i in log_index:
-        try:
-            shutil.copyfile(
-                utils.data_dir / f"pifinder.{i}.log",
-                utils.data_dir / f"pifinder.{i+1}.log",
-            )
-        except FileNotFoundError:
-            pass
-
-    try:
-        shutil.move(
-            utils.data_dir / "pifinder.log",
-            utils.data_dir / "pifinder.0.log",
-        )
-    except FileNotFoundError:
-        pass
-
-    return utils.data_dir / "pifinder.log"
-
-
 if __name__ == "__main__":
     print("Bootstrap logging configuration ...")
     logging.basicConfig(format="%(asctime)s BASIC %(name)s: %(levelname)s %(message)s")
     rlogger = logging.getLogger()
     rlogger.setLevel(logging.INFO)
-    log_path = rotate_logs()
+    log_path = utils.data_dir / "pifinder.log"
     try:
         log_helper = MultiprocLogging(
             Path("pifinder_logconf.json"),

python/PiFinder/multiproclogging.py

@@ -121,8 +121,10 @@ def _run_sink(self, output: Path, queues: List[Queue]):
         for hdlr in hdlrs:
             rLogger.removeHandler(hdlr)
 
-        # configure logging to store everything in output
-        h = logging.handlers.WatchedFileHandler(output)
+        # Set maxBytes to 50MB (50 * 1024 * 1024 bytes) and keep 5 backup files
+        h = logging.handlers.RotatingFileHandler(
+            output, maxBytes=50*1024*1024, backupCount=5, encoding='utf-8'
+        )
         f = logging.Formatter(self._formatter)
         h.setFormatter(f)
         rLogger.addHandler(h)