security fixes

Author: Bhargavi-BS

bin/testObservability/crashReporter/index.js

@@ -27,9 +27,7 @@ let packages = {};
 
 exports.requireModule = (module, internal = false) => {
   let local_path = "";
-  if(process.env["browserStackCwd"]){
-   local_path = path.join(process.env["browserStackCwd"], 'node_modules', module);
-  } else if(internal) {
+  if(internal) {
     local_path = path.join(process.cwd(), 'node_modules', 'browserstack-cypress-cli', 'node_modules', module);
   } else {
     local_path = path.join(process.cwd(), 'node_modules', module);

bin/testObservability/helper/helper.js

@@ -928,9 +928,9 @@ exports.runCypressTestsLocally = (bsConfig, args, rawArgs) => {
     rawArgs = cleanupTestObservabilityFlags(rawArgs);
     logger.info(`Running npx cypress run ${getReRunSpecs(rawArgs.slice(1)).join(' ')} ${getLocalSessionReporter().join(' ')}`);
     const cypressProcess = spawn(
-      'npx',
+      /^win/.test(process.platform) ? 'npx.cmd' : 'npx',
       ['cypress', 'run', ...getReRunSpecs(rawArgs.slice(1)), ...getLocalSessionReporter()],
-      { stdio: 'inherit', cwd: process.cwd(), env: process.env, shell: true }
+      { stdio: 'inherit', cwd: process.cwd(), env: process.env, shell: false }
     );
     cypressProcess.on('close', async (code) => {
       logger.info(`Cypress process exited with code ${code}`);