Styles applied to edges are propagated to arrows #31.

Author: brunomnsilva

smartgraph.css

@@ -44,21 +44,40 @@ This should help you understand which styles you can apply.
     -fx-opacity: 0.8;
 }
 
+.edge:hover {
+    -fx-stroke-width: 3;
+}
+
 .edge-label {
     -fx-font: normal 5pt "sans-serif";
 }
 
+/* Since version 2.0.0-rc2 this style is cumulatively applied to arrows, after the "edge" class.
+ * Use to, e.g., to remove the dash effect (that will not look good in arrows).
+ * Afterwards, styles applied to the edges are propagated to the respective arrows. You can, however, apply
+ * specific styles to the arrows programmatically. See example programs.
+ */
 .arrow {
-    -fx-stroke-width: 2;
-    -fx-stroke: #FF6D66;  
-    -fx-opacity: 0.8;
+    -fx-stroke-dash-array: none;
 }
 
-/* Custom vertex. You should revert any unwanted styling in the default element, 
-   style, since custom styles will be appended to the default style */
+/* Custom vertex class. If you use node.setStyleClass("myVertex"), any previous styling
+ * will be overwritten. If you use node.addStyleClass("myVertex"), the styles are applied
+ * cumulatively; in the later case, any properties not wanted from the default "vertex" class
+ * must be overwritten.
+ */
 .myVertex {
     -fx-stroke-width: 4;
     -fx-stroke: green;
     -fx-stroke-type: inside; /* you should keep this if using arrows */
     -fx-fill: yellowgreen;
+}
+
+/* Custom edge class. The same above logic applies to edges.
+ */
+.myEdge {
+    -fx-stroke-width: 2;
+    -fx-stroke: red;
+    -fx-opacity: 1;
+    -fx-fill: transparent; /* important to keep for curved edges */
 }

src/main/java/com/brunomnsilva/smartgraph/Main.java

@@ -109,10 +109,11 @@ public void start(Stage ignored) {
 
         graphView.setEdgeDoubleClickAction(graphEdge -> {
             System.out.println("Edge contains element: " + graphEdge.getUnderlyingEdge().element());
-            //dynamically change the style when clicked
-            graphEdge.setStyleInline("-fx-stroke: black; -fx-stroke-width: 3;");
-            
-            graphEdge.getStylableArrow().setStyleInline("-fx-stroke: black; -fx-stroke-width: 3;");
+            //dynamically change the style when clicked; style propagated to the arrows
+            graphEdge.setStyleClass("myEdge");
+
+            // can apply different styling to the arrows programmatically.
+            // graphEdge.getStylableArrow().setStyleClass("arrow");
 
             //uncomment to see edges being removed after click
             //Edge<String, String> underlyingEdge = graphEdge.getUnderlyingEdge();

src/main/java/com/brunomnsilva/smartgraph/graphview/SmartArrow.java

@@ -52,7 +52,8 @@ public SmartArrow(double size) {
 
         /* Add the corresponding css class */
         styleProxy = new SmartStyleProxy(this);
-        styleProxy.addStyleClass("arrow");      
+        styleProxy.addStyleClass("edge");    // the same style as the edge
+        styleProxy.addStyleClass("arrow"); // it can initially be styled through this class
     }
 
     @Override

src/main/java/com/brunomnsilva/smartgraph/graphview/SmartGraphEdgeCurve.java

@@ -53,7 +53,11 @@ public class SmartGraphEdgeCurve<E, V> extends CubicCurve implements SmartGraphE
 
     private static final double MAX_EDGE_CURVE_ANGLE = 45;
     private static final double MIN_EDGE_CURVE_ANGLE = 3;
+
+    /** Distance (in pixels) that establishes the maximum curve threshold */
     public static final int DISTANCE_THRESHOLD = 400;
+
+    /** Radius applied to loop curves */
     public static final int LOOP_RADIUS_FACTOR = 4;
 
     private final Edge<E, V> underlyingEdge;
@@ -110,24 +114,36 @@ public SmartGraphEdgeCurve(Edge<E, V> edge, SmartGraphVertexNode<V> inbound, Sma
         enableListeners();
     }
 
-    @Override
     public void setStyleInline(String css) {
         styleProxy.setStyleInline(css);
+        if(attachedArrow != null) {
+            attachedArrow.setStyleInline(css);
+        }
     }
 
     @Override
     public void setStyleClass(String cssClass) {
         styleProxy.setStyleClass(cssClass);
+        if(attachedArrow != null) {
+            attachedArrow.setStyleClass(cssClass);
+        }
     }
 
     @Override
     public void addStyleClass(String cssClass) {
         styleProxy.addStyleClass(cssClass);
+        if(attachedArrow != null) {
+            attachedArrow.addStyleClass(cssClass);
+        }
     }
 
     @Override
     public boolean removeStyleClass(String cssClass) {
-        return styleProxy.removeStyleClass(cssClass);
+        boolean result = styleProxy.removeStyleClass(cssClass);
+        if(attachedArrow != null) {
+            attachedArrow.removeStyleClass(cssClass);
+        }
+        return result;
     }
 
     private void update() {                

src/main/java/com/brunomnsilva/smartgraph/graphview/SmartGraphEdgeLine.java

@@ -81,21 +81,34 @@ public SmartGraphEdgeLine(Edge<E, V> edge, SmartGraphVertexNode<V> inbound, Smar
     @Override
     public void setStyleInline(String css) {
         styleProxy.setStyleInline(css);
+        if(attachedArrow != null) {
+            attachedArrow.setStyleInline(css);
+        }
     }
 
     @Override
     public void setStyleClass(String cssClass) {
         styleProxy.setStyleClass(cssClass);
+        if(attachedArrow != null) {
+            attachedArrow.setStyleClass(cssClass);
+        }
     }
 
     @Override
     public void addStyleClass(String cssClass) {
         styleProxy.addStyleClass(cssClass);
+        if(attachedArrow != null) {
+            attachedArrow.addStyleClass(cssClass);
+        }
     }
 
     @Override
     public boolean removeStyleClass(String cssClass) {
-        return styleProxy.removeStyleClass(cssClass);
+        boolean result = styleProxy.removeStyleClass(cssClass);
+        if(attachedArrow != null) {
+            attachedArrow.removeStyleClass(cssClass);
+        }
+        return result;
     }