Skip to content

Commit f8fe5ec

Browse files
committed
Fix tests in item 21 where a real OverflowError exception was not being raised
1 parent 1908632 commit f8fe5ec

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

example_code/item_21.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ def safe_division(number, divisor, ignore_overflow,
3838

3939

4040
# Example 2
41-
result = safe_division(1, 10**500, True, False)
41+
result = safe_division(1.0, 10**500, True, False)
4242
print(result)
43-
assert result == 0
43+
assert result is 0
4444

4545

4646
# Example 3
47-
result = safe_division(1, 0, False, True)
47+
result = safe_division(1.0, 0, False, True)
4848
print(result)
4949
assert result == float('inf')
5050

@@ -68,12 +68,12 @@ def safe_division_b(number, divisor,
6868

6969

7070
# Example 5
71-
assert safe_division_b(1, 10**500, ignore_overflow=True) == 0
72-
assert safe_division_b(1, 0, ignore_zero_division=True) == float('inf')
71+
assert safe_division_b(1.0, 10**500, ignore_overflow=True) is 0
72+
assert safe_division_b(1.0, 0, ignore_zero_division=True) == float('inf')
7373

7474

7575
# Example 6
76-
assert safe_division_b(1, 10**500, True, False) == 0
76+
assert safe_division_b(1.0, 10**500, True, False) is 0
7777

7878

7979
# Example 7
@@ -96,17 +96,17 @@ def safe_division_c(number, divisor, *,
9696

9797
# Example 8
9898
try:
99-
safe_division_c(1, 10**500, True, False)
99+
safe_division_c(1.0, 10**500, True, False)
100100
except:
101101
logging.exception('Expected')
102102
else:
103103
assert False
104104

105105

106106
# Example 9
107-
safe_division_c(1, 0, ignore_zero_division=True) # No exception
107+
safe_division_c(1.0, 0, ignore_zero_division=True) # No exception
108108
try:
109-
safe_division_c(1, 0)
109+
safe_division_c(1.0, 0)
110110
assert False
111111
except ZeroDivisionError:
112112
pass # Expected

example_code/item_21_example_11.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def safe_division_d(number, divisor, **kwargs):
4141

4242
assert safe_division_d(1.0, 10) == 0.1
4343
assert safe_division_d(1.0, 0, ignore_zero_division=True) == float('inf')
44-
assert safe_division_d(1.0, 10**500, ignore_overflow=True) == 0.0
44+
assert safe_division_d(1.0, 10**500, ignore_overflow=True) is 0
4545

4646
# Example 12
4747
try:

0 commit comments

Comments
 (0)