weird pkey issue with seeding

btholt · btholt · commit 6464c5dc1355 · 2025-10-29T01:08:09.000-05:00
diff --git a/04-database/src/db/seed.ts b/04-database/src/db/seed.ts
@@ -25,7 +25,7 @@ async function main() {
 
     if (users.length === 0) {
       console.error(
-        "❌ No users found in the database. Seed cannot assign authorId without existing users.",
+        "❌ No users found in the database. Seed cannot assign authorId without existing users."
       );
       process.exit(1);
     }
@@ -79,7 +79,17 @@ async function main() {
 
     console.log(`✅ Inserted ${SEED_COUNT} article(s) into the database\n`);
 
-    // Sequence is reset by TRUNCATE ... RESTART IDENTITY above, so no setval needed.
+    // Ensure the articles sequence is synced to the current MAX(id). This is a
+    // safety measure in case the DB was imported or mutated in a way that left
+    // the sequence behind the table's max value.
+    try {
+      await sql.query(
+        `SELECT setval(pg_get_serial_sequence('articles','id'), COALESCE((SELECT MAX(id) FROM articles), 1), true);`
+      );
+      console.log("✅ Sequence synced after seeding");
+    } catch (err) {
+      console.warn("⚠️ Failed to sync articles sequence after seeding:", err);
+    }
   } catch (err) {
     console.error("💥 Seed failed:", err);
     process.exit(1);
diff --git a/05-object-storage/src/db/seed.ts b/05-object-storage/src/db/seed.ts
@@ -25,7 +25,7 @@ async function main() {
 
     if (users.length === 0) {
       console.error(
-        "❌ No users found in the database. Seed cannot assign authorId without existing users.",
+        "❌ No users found in the database. Seed cannot assign authorId without existing users."
       );
       process.exit(1);
     }
@@ -79,7 +79,17 @@ async function main() {
 
     console.log(`✅ Inserted ${SEED_COUNT} article(s) into the database\n`);
 
-    // Sequence is reset by TRUNCATE ... RESTART IDENTITY above, so no setval needed.
+    // Ensure the articles sequence is synced to the current MAX(id). This is a
+    // safety measure in case the DB was imported or mutated in a way that left
+    // the sequence behind the table's max value.
+    try {
+      await sql.query(
+        `SELECT setval(pg_get_serial_sequence('articles','id'), COALESCE((SELECT MAX(id) FROM articles), 1), true);`
+      );
+      console.log("✅ Sequence synced after seeding");
+    } catch (err) {
+      console.warn("⚠️ Failed to sync articles sequence after seeding:", err);
+    }
   } catch (err) {
     console.error("💥 Seed failed:", err);
     process.exit(1);
diff --git a/06-caching/src/db/seed.ts b/06-caching/src/db/seed.ts
@@ -79,7 +79,17 @@ async function main() {
 
     console.log(`✅ Inserted ${SEED_COUNT} article(s) into the database\n`);
 
-    // Sequence is reset by TRUNCATE ... RESTART IDENTITY above, so no setval needed.
+    // Ensure the articles sequence is synced to the current MAX(id). This is a
+    // safety measure in case the DB was imported or mutated in a way that left
+    // the sequence behind the table's max value.
+    try {
+      await sql.query(
+        `SELECT setval(pg_get_serial_sequence('articles','id'), COALESCE((SELECT MAX(id) FROM articles), 1), true);`,
+      );
+      console.log("✅ Sequence synced after seeding");
+    } catch (err) {
+      console.warn("⚠️ Failed to sync articles sequence after seeding:", err);
+    }
   } catch (err) {
     console.error("💥 Seed failed:", err);
     process.exit(1);
diff --git a/06-caching/src/lib/data/articles.ts b/06-caching/src/lib/data/articles.ts
@@ -31,7 +31,7 @@ export async function getArticles(): Promise<ArticleList[]> {
     .from(articles)
     .leftJoin(usersSync, eq(articles.authorId, usersSync.id));
 
-  console.log("🙅‍♂️ Get Articles Cache Miss!");
+  console.log("🏹 Get Articles Cache Miss!");
   try {
     await redis.set("articles:all", JSON.stringify(response), {
       ex: 60,
diff --git a/07-email/src/db/seed.ts b/07-email/src/db/seed.ts
@@ -25,7 +25,7 @@ async function main() {
 
     if (users.length === 0) {
       console.error(
-        "❌ No users found in the database. Seed cannot assign authorId without existing users.",
+        "❌ No users found in the database. Seed cannot assign authorId without existing users."
       );
       process.exit(1);
     }
@@ -79,7 +79,17 @@ async function main() {
 
     console.log(`✅ Inserted ${SEED_COUNT} article(s) into the database\n`);
 
-    // Sequence is reset by TRUNCATE ... RESTART IDENTITY above, so no setval needed.
+    // Ensure the articles sequence is synced to the current MAX(id). This is a
+    // safety measure in case the DB was imported or mutated in a way that left
+    // the sequence behind the table's max value.
+    try {
+      await sql.query(
+        `SELECT setval(pg_get_serial_sequence('articles','id'), COALESCE((SELECT MAX(id) FROM articles), 1), true);`
+      );
+      console.log("✅ Sequence synced after seeding");
+    } catch (err) {
+      console.warn("⚠️ Failed to sync articles sequence after seeding:", err);
+    }
   } catch (err) {
     console.error("💥 Seed failed:", err);
     process.exit(1);
diff --git a/07-email/src/lib/data/articles.ts b/07-email/src/lib/data/articles.ts
@@ -31,7 +31,7 @@ export async function getArticles(): Promise<ArticleList[]> {
     .from(articles)
     .leftJoin(usersSync, eq(articles.authorId, usersSync.id));
 
-  console.log("🙅‍♂️ Get Articles Cache Miss!");
+  console.log("🏹 Get Articles Cache Miss!");
   try {
     await redis.set("articles:all", JSON.stringify(response), {
       ex: 60,
diff --git a/08-ai/src/db/seed.ts b/08-ai/src/db/seed.ts
@@ -25,7 +25,7 @@ async function main() {
 
     if (users.length === 0) {
       console.error(
-        "❌ No users found in the database. Seed cannot assign authorId without existing users.",
+        "❌ No users found in the database. Seed cannot assign authorId without existing users."
       );
       process.exit(1);
     }
@@ -79,7 +79,17 @@ async function main() {
 
     console.log(`✅ Inserted ${SEED_COUNT} article(s) into the database\n`);
 
-    // Sequence is reset by TRUNCATE ... RESTART IDENTITY above, so no setval needed.
+    // Ensure the articles sequence is synced to the current MAX(id). This is a
+    // safety measure in case the DB was imported or mutated in a way that left
+    // the sequence behind the table's max value.
+    try {
+      await sql.query(
+        `SELECT setval(pg_get_serial_sequence('articles','id'), COALESCE((SELECT MAX(id) FROM articles), 1), true);`
+      );
+      console.log("✅ Sequence synced after seeding");
+    } catch (err) {
+      console.warn("⚠️ Failed to sync articles sequence after seeding:", err);
+    }
   } catch (err) {
     console.error("💥 Seed failed:", err);
     process.exit(1);
diff --git a/08-ai/src/lib/data/articles.ts b/08-ai/src/lib/data/articles.ts
@@ -35,7 +35,7 @@ export async function getArticles(): Promise<ArticleList[]> {
     .from(articles)
     .leftJoin(usersSync, eq(articles.authorId, usersSync.id));
 
-  console.log("🙅‍♂️ Get Articles Cache Miss!");
+  console.log("🏹 Get Articles Cache Miss!");
   // Store cache as JSON so we can retrieve a typed array later
   try {
     await redis.set("articles:all", JSON.stringify(response), {
diff --git a/09-with-tests/src/db/seed.ts b/09-with-tests/src/db/seed.ts
@@ -25,7 +25,7 @@ async function main() {
 
     if (users.length === 0) {
       console.error(
-        "❌ No users found in the database. Seed cannot assign authorId without existing users.",
+        "❌ No users found in the database. Seed cannot assign authorId without existing users."
       );
       process.exit(1);
     }
@@ -70,7 +70,17 @@ async function main() {
 
     console.log(`✅ Inserted ${SEED_COUNT} article(s) into the database\n`);
 
-    // Sequence is reset by TRUNCATE ... RESTART IDENTITY above, so no setval needed.
+    // Ensure the articles sequence is synced to the current MAX(id). This is a
+    // safety measure in case the DB was imported or mutated in a way that left
+    // the sequence behind the table's max value.
+    try {
+      await sql.query(
+        `SELECT setval(pg_get_serial_sequence('articles','id'), COALESCE((SELECT MAX(id) FROM articles), 1), true);`
+      );
+      console.log("✅ Sequence synced after seeding");
+    } catch (err) {
+      console.warn("⚠️ Failed to sync articles sequence after seeding:", err);
+    }
   } catch (err) {
     console.error("💥 Seed failed:", err);
     process.exit(1);
diff --git a/09-with-tests/src/lib/data/articles.ts b/09-with-tests/src/lib/data/articles.ts
@@ -35,7 +35,7 @@ export async function getArticles(): Promise<ArticleList[]> {
     .from(articles)
     .leftJoin(usersSync, eq(articles.authorId, usersSync.id));
 
-  console.log("🙅‍♂️ Get Articles Cache Miss!");
+  console.log("🏹 Get Articles Cache Miss!");
   // Store cache as JSON so we can retrieve a typed array later
   try {
     await redis.set("articles:all", JSON.stringify(response), {
@@ -57,7 +57,7 @@ export type ArticleWithAuthor = {
 };
 
 export async function getArticleById(
-  id: number,
+  id: number
 ): Promise<ArticleWithAuthor | null> {
   const response = await db
     .select({
diff --git a/09-with-tests/test/e2e/global-setup.ts b/09-with-tests/test/e2e/global-setup.ts
@@ -37,10 +37,30 @@ async function globalSetup() {
   await waitForServer("http://localhost:3000", 120000);
   console.log("✅ Dev server is ready");
 
+  // Ensure Postgres sequences are at or above the current max(id) to avoid
+  // duplicate-key errors when tests create rows. Some Neon branch operations
+  // or inherited data can leave sequences behind the table max value.
+  try {
+    // Import the Neon client dynamically to avoid alias/resolution issues.
+    // Use the DATABASE_URL already loaded into process.env by the dotenv calls above.
+    // eslint-disable-next-line @typescript-eslint/no-var-requires
+    const { neon } = await import("@neondatabase/serverless");
+    const sql = neon(process.env.DATABASE_URL || "");
+    console.log(
+      "🔁 Syncing articles sequence to MAX(id) to avoid PK collisions..."
+    );
+    await sql.query(
+      `SELECT setval(pg_get_serial_sequence('articles','id'), COALESCE((SELECT MAX(id) FROM articles), 1), true);`
+    );
+    console.log("✅ Sequence sync complete");
+  } catch (err) {
+    console.warn("⚠️ Failed to sync articles sequence:", err);
+  }
+
   // Store the server process ID for teardown
   writeFileSync(
     join(process.cwd(), ".test-server-pid.json"),
-    JSON.stringify({ pid: devServer.pid }, null, 2),
+    JSON.stringify({ pid: devServer.pid }, null, 2)
   );
 }
 
