allow filter_bubble_uids to safely handle mixed-type iterables

Author: purificant

src/bubble_data_api_client/validation.py

@@ -8,12 +8,10 @@
 
 
 def is_bubble_uid(value: Any) -> bool:
-    """Check if a string matches the Bubble UID format (e.g., '1767090310181x452059685440531200')."""
-    if not isinstance(value, str):
-        return False
-    return _BUBBLE_UID_PATTERN.fullmatch(value) is not None
+    """Check if a value is a valid Bubble UID (e.g., '1767090310181x452059685440531200')."""
+    return isinstance(value, str) and _BUBBLE_UID_PATTERN.fullmatch(value) is not None
 
 
-def filter_bubble_uids(values: Iterable[str]) -> list[str]:
-    """Return only valid Bubble UIDs from an iterable, filtering out invalid ones."""
+def filter_bubble_uids(values: Iterable[Any]) -> list[str]:
+    """Return only valid Bubble UIDs from an iterable, filtering out invalid values."""
     return [v for v in values if is_bubble_uid(v)]

src/tests/unit/test_validation.py

@@ -100,3 +100,9 @@ def test_filter_bubble_uids_accepts_iterator() -> None:
     """Should work with any iterable, not just lists."""
     values = iter(["1x2", "invalid", "3x4"])
     assert filter_bubble_uids(values) == ["1x2", "3x4"]
+
+
+def test_filter_bubble_uids_non_string_values() -> None:
+    """Non-string values should be filtered out."""
+    values = ["1x2", None, 123, "3x4", {"uid": "5x6"}, True, "7x8"]
+    assert filter_bubble_uids(values) == ["1x2", "3x4", "7x8"]