Skip to content

Commit a3a0406

Browse files
paddymulclaude
andcommitted
fix: use polars for parquet test data in server Playwright tests
writeTempParquet() was using pandas via `uv run python`, but in CI the server Playwright tests run in a clean [mcp] venv where `uv run` doesn't resolve to a python with pandas. Switch to polars (which is in the [mcp] extras) and use BUCKAROO_SERVER_PYTHON when available. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent b178ddb commit a3a0406

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

.github/workflows/checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ jobs:
402402
name: Server Playwright Tests
403403
needs: [BuildWheel]
404404
runs-on: depot-ubuntu-latest
405-
timeout-minutes: 10
405+
timeout-minutes: 15
406406
steps:
407407
- uses: actions/checkout@v6
408408
- name: Install uv

packages/buckaroo-js-core/pw-tests/server.spec.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,11 @@ function writeTempJson(): string {
4949

5050
function writeTempParquet(): string {
5151
const parquetPath = path.join(os.tmpdir(), `buckaroo_e2e_${Date.now()}.parquet`);
52+
// Use polars (available in [mcp] extras) instead of pandas to write the test parquet.
53+
// Use BUCKAROO_SERVER_PYTHON if set (CI), otherwise fall back to uv run python.
54+
const python = process.env.BUCKAROO_SERVER_PYTHON ?? 'uv run python';
5255
execSync(
53-
`uv run python -c "import pandas as pd; pd.DataFrame({'x':[1,2,3],'y':[4,5,6]}).to_parquet('${parquetPath}')"`,
56+
`${python} -c "import polars as pl; pl.DataFrame({'x':[1,2,3],'y':[4,5,6]}).write_parquet('${parquetPath}')"`,
5457
{ cwd: PROJECT_ROOT },
5558
);
5659
return parquetPath;

0 commit comments

Comments
 (0)