Skip to content

Commit 2334a0d

Browse files
committed
Merge pull request #61 from mikesouthron/master
Fixes #60 Handle whitelist AccessModels
2 parents e36d711 + b74fa8a commit 2334a0d

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

src/main/java/org/buddycloud/channelserver/pubsub/accessmodel/AccessModels.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public static AccessModels createFromString(String asString) {
1717
} else if ("whitelist".equals(asString)) {
1818
return whitelist;
1919
}
20-
return whitelist;
20+
return authorize;
2121
}
2222

2323
}

src/main/java/org/buddycloud/channelserver/utils/node/NodeViewAcl.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,18 @@ public boolean canViewNode(String node, Affiliations affilliation,
3535
return openChannelAcl(node, subscription, affilliation);
3636
} else if (accessModel.toString().equals(AccessModels.authorize.toString())) {
3737
return privateChannelAcl(node, subscription, affilliation);
38-
}
38+
} else if (accessModel.toString().equals(AccessModels.whitelist.toString())) {
39+
return whitelistAcl(node, subscription, affilliation);
40+
}
3941
throw new InvalidParameterException(INVALID_ACCESS_MODEL);
4042
}
4143

42-
private boolean privateChannelAcl(String node, Subscriptions subscription,
44+
private boolean whitelistAcl(String node, Subscriptions subscription, Affiliations affilliation) {
45+
LOGGER.trace("Whitelist not implemented, returning equivalent of authorized");
46+
return privateChannelAcl(node, subscription, affilliation);
47+
}
48+
49+
private boolean privateChannelAcl(String node, Subscriptions subscription,
4350
Affiliations affilliation) {
4451
if (Subscriptions.none.toString().equals(subscription.toString())) {
4552
reasonForRefusal = new NodeAclRefuseReason(PacketError.Type.auth,

0 commit comments

Comments
 (0)