Skip to content

Commit 723dad6

Browse files
author
Lloyd Watkin
committed
Formatting updates
1 parent e29c533 commit 723dad6

1 file changed

Lines changed: 65 additions & 61 deletions

File tree

src/main/java/org/buddycloud/channelserver/queue/FederatedQueueManager.java

Lines changed: 65 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class FederatedQueueManager {
3737
public static final String IDENTITY_TYPE_CHANNELS = "channels";
3838
public static final String BUDDYCLOUD_SERVER = "buddycloud-server";
3939

40-
public static final String SRV_PREFIX = "_buddycloud-server._tcp.";
40+
public static final String SRV_PREFIX = "_buddycloud-server._tcp.";
4141

4242
private int id = 1;
4343

@@ -113,7 +113,7 @@ public void process(Packet packet) throws ComponentException {
113113
waitingStanzas.get(to).add(packet);
114114
logger.debug("Adding packet to waiting stanza list for " + to
115115
+ " (size " + waitingStanzas.get(to).size() + ")");
116-
attemptDnsDiscovery(to);
116+
attemptDnsDiscovery(to);
117117
} catch (Exception e) {
118118
logger.error(e);
119119
}
@@ -137,10 +137,8 @@ private void extractNodeDetails(Packet packet) {
137137
if (!packetXml.contains("node=")) {
138138
return;
139139
}
140-
nodeMap.put(
141-
packet.getID(),
142-
packetXml.split("node=\"")[1].split("\"")[0]
143-
);
140+
nodeMap.put(packet.getID(),
141+
packetXml.split("node=\"")[1].split("\"")[0]);
144142
} catch (NullPointerException e) {
145143
logger.info("No node details found in federated packet");
146144
logger.error(e);
@@ -172,8 +170,7 @@ public void processDiscoItemsResponse(JID from, List<Element> items)
172170

173171
for (Element item : items) {
174172
Attribute name = item.attribute("name");
175-
if (name != null
176-
&& name.getStringValue().equals(BUDDYCLOUD_SERVER)) {
173+
if (name != null && name.getStringValue().equals(BUDDYCLOUD_SERVER)) {
177174
remoteChannelDiscoveryStatus.put(from.toString(), DISCOVERED);
178175
setDiscoveredServer(from.toString(), item.attributeValue("jid"));
179176
sendFederatedRequests(from.toString());
@@ -227,50 +224,54 @@ public void processDiscoInfoResponse(JID from, String id,
227224

228225
if (remoteServerItemsToProcess.get(originatingServer) < 1) {
229226
if (!discoveredServers.containsKey(originatingServer)) {
230-
sendRemoteChannelServerNotFoundErrorResponses(originatingServer);
231-
remoteChannelDiscoveryStatus.put(originatingServer,
232-
NO_CHANNEL_SERVER);
233-
waitingStanzas.remove(originatingServer);
227+
sendRemoteChannelServerNotFoundErrorResponses(originatingServer);
228+
remoteChannelDiscoveryStatus.put(originatingServer,
229+
NO_CHANNEL_SERVER);
230+
waitingStanzas.remove(originatingServer);
234231
} else {
235232
remoteChannelDiscoveryStatus.put(originatingServer, DISCOVERED);
236233
}
237234
}
238235
}
239236

240-
private boolean attemptDnsDiscovery(String originatingServer) throws ComponentException {
241-
try {
242-
String query = SRV_PREFIX + originatingServer;
243-
Record[] records = new Lookup(query, Type.SRV).run();
244-
if ((null == records) || (0 == records.length)) {
245-
logger.debug("No appropriate DNS entry found for " + originatingServer);
246-
return false;
247-
}
248-
SRVRecord record = (SRVRecord) records[0];
249-
String targetServer = record.getTarget().toString(true);
250-
setDiscoveredServer(originatingServer, targetServer);
251-
logger.info("DNS discovery complete for buddycloud server @ "
252-
+ originatingServer + " (" + targetServer + ")");
253-
remoteChannelDiscoveryStatus.put(originatingServer, DISCOVERED);
254-
sendFederatedRequests(originatingServer);
255-
return true;
256-
} catch (TextParseException e) {
257-
logger.error(e);
258-
return false;
259-
}
260-
}
237+
private boolean attemptDnsDiscovery(String originatingServer)
238+
throws ComponentException {
239+
try {
240+
String query = SRV_PREFIX + originatingServer;
241+
Record[] records = new Lookup(query, Type.SRV).run();
242+
if ((null == records) || (0 == records.length)) {
243+
logger.debug("No appropriate DNS entry found for "
244+
+ originatingServer);
245+
return false;
246+
}
247+
SRVRecord record = (SRVRecord) records[0];
248+
String targetServer = record.getTarget().toString(true);
249+
setDiscoveredServer(originatingServer, targetServer);
250+
logger.info("DNS discovery complete for buddycloud server @ "
251+
+ originatingServer + " (" + targetServer + ")");
252+
remoteChannelDiscoveryStatus.put(originatingServer, DISCOVERED);
253+
sendFederatedRequests(originatingServer);
254+
return true;
255+
} catch (TextParseException e) {
256+
logger.error(e);
257+
return false;
258+
}
259+
}
261260

262261
private void sendFederatedRequests(String originatingServer)
263262
throws ComponentException {
264263
String remoteServer = discoveredServers.get(originatingServer);
265264
List<Packet> packetsToSend = waitingStanzas.get(originatingServer);
266265
if (packetsToSend == null) {
267-
logger.trace("No queued federated packets to send to " + originatingServer);
266+
logger.trace("No queued federated packets to send to "
267+
+ originatingServer);
268268
return;
269269
}
270-
logger.trace("Catching up on federated packet sending to " + originatingServer);
270+
logger.trace("Catching up on federated packet sending to "
271+
+ originatingServer);
271272
for (Packet packet : packetsToSend) {
272273
packet.setTo(remoteServer);
273-
logger.trace(packet.toString());
274+
logger.trace(packet.toString());
274275
sendPacket(packet.createCopy());
275276
}
276277
waitingStanzas.remove(originatingServer);
@@ -311,9 +312,11 @@ public void passResponseToRequester(IQ packet) throws Exception {
311312
+ packet.getID() + ")");
312313
}
313314

314-
if (packet.getType().equals(IQ.Type.error) && !remoteChannelDiscoveryStatus.get(packet.getFrom()).equals(DISCOVERED)) {
315-
return;
316-
}
315+
if (packet.getType().equals(IQ.Type.error)
316+
&& !remoteChannelDiscoveryStatus.get(packet.getFrom()).equals(
317+
DISCOVERED)) {
318+
return;
319+
}
317320

318321
String uniqueId = packet.getID();
319322
packet.setID(idMap.get(uniqueId));
@@ -347,10 +350,10 @@ public void addChannelMap(JID server) {
347350

348351
/**
349352
* Generate a unique ID for a packet
350-
*
353+
*
351354
* Supplied packet IDs might not be unique so we use the ID and the FROM
352355
* values to create a hash which we map back to the original packet ID.
353-
*
356+
*
354357
* @param packet
355358
* @return unique ID for the packet
356359
*/
@@ -360,30 +363,31 @@ private String generateUniqueId(Packet packet) {
360363

361364
/**
362365
* Generates an MD5 hash of a supplied String
363-
*
364-
* @param message to encode
366+
*
367+
* @param message
368+
* to encode
365369
* @return MD5 Hash of supplied string
366370
*/
367-
private String generateMd5(String message) {
368-
String digest = null;
369-
try {
370-
MessageDigest md = MessageDigest.getInstance("MD5");
371-
byte[] hash = md.digest(message.getBytes("UTF-8"));
372-
373-
//converting byte array to Hexadecimal String
374-
StringBuilder sb = new StringBuilder(2*hash.length);
375-
for(byte b : hash) {
376-
sb.append(String.format("%02x", b&0xff));
377-
}
378-
379-
digest = sb.toString();
380-
} catch (UnsupportedEncodingException e) {
371+
private String generateMd5(String message) {
372+
String digest = null;
373+
try {
374+
MessageDigest md = MessageDigest.getInstance("MD5");
375+
byte[] hash = md.digest(message.getBytes("UTF-8"));
376+
377+
// converting byte array to Hexadecimal String
378+
StringBuilder sb = new StringBuilder(2 * hash.length);
379+
for (byte b : hash) {
380+
sb.append(String.format("%02x", b & 0xff));
381+
}
382+
383+
digest = sb.toString();
384+
} catch (UnsupportedEncodingException e) {
381385
logger.info("Error generating unique packet ID");
382386
logger.error(e);
383-
} catch (NoSuchAlgorithmException e) {
387+
} catch (NoSuchAlgorithmException e) {
384388
logger.info("Error generating unique packet ID");
385389
logger.error(e);
386-
}
387-
return digest;
388-
}
390+
}
391+
return digest;
392+
}
389393
}

0 commit comments

Comments
 (0)