Finish node config result parsing code

Author: Lloyd Watkin

src/main/java/org/buddycloud/channelserver/packetprocessor/iq/namespace/pubsub/result/Configuration.java

@@ -1,9 +1,12 @@
 package org.buddycloud.channelserver.packetprocessor.iq.namespace.pubsub.result;
 
+import java.util.HashMap;
 import java.util.List;
 
 import org.apache.log4j.Logger;
 import org.buddycloud.channelserver.channel.ChannelManager;
+import org.buddycloud.channelserver.channel.node.configuration.NodeConfigurationException;
+import org.buddycloud.channelserver.channel.node.configuration.field.Owner;
 import org.buddycloud.channelserver.db.exception.NodeStoreException;
 import org.buddycloud.channelserver.packetprocessor.iq.namespace.pubsub.PubSubElementProcessorAbstract;
 import org.buddycloud.channelserver.pubsub.model.NodeSubscription;
@@ -12,12 +15,12 @@
 import org.dom4j.Element;
 import org.xmpp.packet.IQ;
 import org.xmpp.packet.JID;
+import org.xmpp.packet.PacketError;
 
 public class Configuration extends PubSubElementProcessorAbstract {
 
 	private IQ request;
-	private boolean ownerRequest;
-	private String lastNode = "";
+	Element configure;
 
 	private static final Logger logger = Logger
 			.getLogger(Configuration.class);
@@ -36,7 +39,32 @@ public void process(Element elm, JID actorJID, IQ reqIQ, Element rsm)
 					+ "from other buddycloud servers");
 			return;
 		}
+		
+		configure = request.getChildElement().element("configure");
+        node = configure.attributeValue("node");
+        if (0 == node.length()) return;
+        
+        if (false == channelManager.nodeExists(node)) {
+        	channelManager.addRemoteNode(node);
+        }
+        setNodeConfiguration();
+	}
+	
+	private void setNodeConfiguration() throws Exception {
+		try {
+			getNodeConfigurationHelper().parse(request);
+			updateNodeConfiguration(getNodeConfigurationHelper()
+					.getValues());
+		} catch (NodeConfigurationException e) {
+			logger.error("Node configuration exception", e);
+		} catch (NodeStoreException e) {
+			logger.error("Data Store Exception", e);
+		}
+	}
 
+	private void updateNodeConfiguration(HashMap<String, String> configuration)
+			throws Exception {
+		channelManager.setNodeConf(node, configuration);
 	}
 
 	@Override

src/test/java/org/buddycloud/channelserver/packetprocessor/iq/namespace/pubsub/result/ConfigurationTest.java

@@ -50,4 +50,47 @@ public void testPassingNotConfigureAsElementNameReturnsFalse() {
 		Element element = new BaseElement("not-configure");
 		Assert.assertFalse(confResult.accept(element));
 	}
+	
+	@Test(expected = NullPointerException.class)
+	public void testInvalidStanzaThrowsException() throws Exception {
+
+		IQ result = toIq("<iq type=\"result\" id=\"subscriptions1\" "
+				+ "from=\"channels.shakespeare.lit\" "
+				+ "to=\"channels.denmark.lit\">"
+				+ "<pubsub xmlns=\"http://jabber.org/protocol/pubsub#owner\" />"
+				+ "</iq>");
+
+		confResult.process(element, jid, result, null);
+	}
+	
+	@Test
+	public void testEmptyNodeValueCausesNoAction() throws Exception {
+		IQ result = toIq("<iq type=\"result\" id=\"subscriptions1\" "
+				+ "from=\"channels.shakespeare.lit\" "
+				+ "to=\"channels.denmark.lit\">"
+				+ "<pubsub xmlns=\"http://jabber.org/protocol/pubsub#owner\">"
+				+ "<configure node=\"\" />" + "</pubsub>" + "</iq>");
+
+		confResult.process(element, jid, result, null);
+
+		Mockito.verify(channelManager, Mockito.times(0)).nodeExists(
+				Mockito.anyString());
+	}
+	
+	@Test
+	public void testIfNodeIsUnknownThenItIsAddedToDatabase() throws Exception {
+		IQ result = toIq("<iq type=\"result\" id=\"subscriptions1\" "
+				+ "from=\"channels.shakespeare.lit\" "
+				+ "to=\"channels.denmark.lit\">"
+				+ "<pubsub xmlns=\"http://jabber.org/protocol/pubsub#owner\">"
+				+ "<configure node=\"some-node\" />" + "</pubsub>" + "</iq>");
+
+		confResult.process(element, jid, result, null);
+
+		Mockito.when(channelManager.nodeExists(Mockito.anyString())).thenReturn(false);
+		Mockito.verify(channelManager, Mockito.times(1)).nodeExists(
+				Mockito.anyString());
+		Mockito.verify(channelManager, Mockito.times(1)).addRemoteNode(
+				Mockito.anyString());
+	}
 }