Skip to content

Commit 7c759fd

Browse files
committed
Merge branch 'main' into fixed-libs
2 parents a1bb1ab + 8819976 commit 7c759fd

3 files changed

Lines changed: 3 additions & 13 deletions

File tree

brood/resources/actions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ def acl_auth(
4141
.filter(models.ResourceHolderPermission.resource_id == resource_id)
4242
.filter(
4343
or_(
44-
models.ResourceHolderPermission.holder_id == user_id,
45-
models.ResourceHolderPermission.holder_id.in_(user_group_id_list),
44+
models.ResourceHolderPermission.user_id == user_id,
45+
models.ResourceHolderPermission.group_id.in_(user_group_id_list),
4646
)
4747
)
4848
.all()

brood/resources/api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ async def update_resource_handler(
220220
db_session,
221221
current_user.id,
222222
resource_id,
223-
{data.ResourcePermissions.ADMIN},
223+
{data.ResourcePermissions.UPDATE},
224224
)
225225
try:
226226
updated_resource = actions.update_resource_data(

brood/resources/models.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
)
1212
from sqlalchemy.orm import relationship
1313
from sqlalchemy.dialects.postgresql import JSONB, UUID
14-
from sqlalchemy.ext.hybrid import hybrid_property
1514

1615
from ..models import utcnow, User, Group, Application
1716

@@ -128,12 +127,3 @@ class ResourceHolderPermission(Base): # type: ignore
128127
onupdate=utcnow(),
129128
nullable=False,
130129
)
131-
132-
@hybrid_property
133-
def holder_id(self):
134-
if self.user_id is not None:
135-
return self.user_id
136-
elif self.group_id is not None:
137-
return self.group_id
138-
else:
139-
return None

0 commit comments

Comments
 (0)