Merge pull request #18 from bugout-dev/fix-resources-list

GET /resources should not 404 if no resources

Author: kompotkot

brood/resources/actions.py

@@ -137,7 +137,7 @@ def get_list_of_resources(
     application_id: Optional[str] = None,
 ) -> List[models.Resource]:
     """
-    Return list of available resource to user. 
+    Return list of available resource to user.
     """
     query = (
         db_session.query(models.Resource)
@@ -158,10 +158,6 @@ def get_list_of_resources(
         query = query.filter(models.Resource.resource_data[key].astext == value)
 
     resources = query.all()
-    if len(resources) == 0:
-        raise exceptions.ResourceNotFound(
-            f"Did not found resources for user with id: {user_id}"
-        )
 
     return resources
 

brood/resources/api.py

@@ -105,7 +105,7 @@ async def create_resource_handler(
     Create the resource.
     Current user will inherit all permissions to the resource.
 
-    - **data** (dict): 
+    - **data** (dict):
         - **application_id** (uuid)
         - **resource_data** (dict)
     """
@@ -150,8 +150,6 @@ async def get_resources_list_handler(
         resources = actions.get_list_of_resources(
             db_session, current_user.id, user_groups_ids, params, application_id
         )
-    except exceptions.ResourceNotFound:
-        raise HTTPException(status_code=404, detail="Resources not found")
     except Exception as err:
         logger.error(f"Unhandled error in get_resources_list_handler: {str(err)}")
         raise HTTPException(status_code=500)