fix empty plist update

Author: StephenHodgson

dist/index.js

@@ -58047,10 +58047,10 @@ async function GetProjectDetails(credential, xcodeVersion) {
     finally {
         await infoPlistHandle.close();
     }
-    const infoPlistJson = plist.parse(infoPlistContent);
-    const cFBundleShortVersionString = infoPlistJson['CFBundleShortVersionString'];
+    const infoPlist = plist.parse(infoPlistContent);
+    const cFBundleShortVersionString = infoPlist['CFBundleShortVersionString'];
     core.info(`CFBundleShortVersionString: ${cFBundleShortVersionString}`);
-    const cFBundleVersion = infoPlistJson['CFBundleVersion'];
+    const cFBundleVersion = infoPlist['CFBundleVersion'];
     core.info(`CFBundleVersion: ${cFBundleVersion}`);
     const projectRef = new XcodeProject_1.XcodeProject(projectPath, projectName, platform, bundleId, projectDirectory, cFBundleShortVersionString, cFBundleVersion, scheme, credential, xcodeVersion);
     await getExportOptions(projectRef);
@@ -58071,10 +58071,15 @@ async function GetProjectDetails(credential, xcodeVersion) {
         if (projectRef.bundleVersion <= bundleVersion) {
             projectRef.bundleVersion = bundleVersion + 1;
             core.debug(`Auto Incremented bundle version ==> ${projectRef.bundleVersion}`);
-            infoPlistJson['CFBundleVersion'] = projectRef.bundleVersion;
-            const plistHandle = await fs.promises.open(infoPlistPath, fs.constants.O_RDWR);
+            infoPlist['CFBundleVersion'] = projectRef.bundleVersion;
+            try {
+                await fs.promises.writeFile(infoPlistPath, plist.build(infoPlist));
+            }
+            catch (error) {
+                (0, utilities_1.log)(`Failed to update Info.plist!\n${error}`, 'error');
+            }
+            const plistHandle = await fs.promises.open(infoPlistPath, fs.constants.O_RDONLY);
             try {
-                await fs.promises.writeFile(plistHandle, plist.build(infoPlistJson));
                 core.info(`Updated Info.plist with CFBundleVersion: ${projectRef.bundleVersion}`);
                 const updatedInfoPlistContent = await fs.promises.readFile(plistHandle, 'utf8');
                 core.info(`----- Updated Info.plist content: -----\n${updatedInfoPlistContent}\n--------------------------------`);

dist/index.js.map

@@ -70,10 +70,10 @@ export async function GetProjectDetails(credential: AppleCredential, xcodeVersio
     } finally {
         await infoPlistHandle.close();
     }
-    const infoPlistJson = plist.parse(infoPlistContent);
-    const cFBundleShortVersionString = infoPlistJson['CFBundleShortVersionString'];
+    const infoPlist = plist.parse(infoPlistContent) as any;
+    const cFBundleShortVersionString = infoPlist['CFBundleShortVersionString'];
     core.info(`CFBundleShortVersionString: ${cFBundleShortVersionString}`);
-    const cFBundleVersion = infoPlistJson['CFBundleVersion'] as number;
+    const cFBundleVersion = infoPlist['CFBundleVersion'] as number;
     core.info(`CFBundleVersion: ${cFBundleVersion}`);
     const projectRef = new XcodeProject(
         projectPath,
@@ -103,11 +103,14 @@ export async function GetProjectDetails(credential: AppleCredential, xcodeVersio
         if (projectRef.bundleVersion <= bundleVersion) {
             projectRef.bundleVersion = bundleVersion + 1;
             core.debug(`Auto Incremented bundle version ==> ${projectRef.bundleVersion}`);
-            infoPlistJson['CFBundleVersion'] = projectRef.bundleVersion;
-            // read and write handle
-            const plistHandle = await fs.promises.open(infoPlistPath, fs.constants.O_RDWR);
+            infoPlist['CFBundleVersion'] = projectRef.bundleVersion;
+            try {
+                await fs.promises.writeFile(infoPlistPath, plist.build(infoPlist));
+            } catch (error) {
+                log(`Failed to update Info.plist!\n${error}`, 'error');
+            }
+            const plistHandle = await fs.promises.open(infoPlistPath, fs.constants.O_RDONLY);
             try {
-                await fs.promises.writeFile(plistHandle, plist.build(infoPlistJson));
                 core.info(`Updated Info.plist with CFBundleVersion: ${projectRef.bundleVersion}`);
                 const updatedInfoPlistContent = await fs.promises.readFile(plistHandle, 'utf8');
                 core.info(`----- Updated Info.plist content: -----\n${updatedInfoPlistContent}\n--------------------------------`);