Electrum plugin: allow specifying additional custom CLI arguments using the GUI

Author: shesek

CHANGELOG.md

@@ -5,6 +5,8 @@
 - Electrum plugin: Restore the previous `oneserver` setting when the plugin is disabled,
   to prevent users from inadvertently connecting to public Electrum servers with this setting still on.
 
+- Electrum plugin: allow specifying additional custom CLI arguments using the GUI
+
 ## 0.1.1 - 2020-05-27
 
 - Make bwt available as an Electrum plugin! 💥

contrib/electrum-plugin/bwt.py

@@ -32,8 +32,8 @@ def __init__(self, parent, config, name):
         self.bitcoind_wallet = config.get('bwt_bitcoind_wallet')
         self.bitcoind_cred = config.get('bwt_bitcoind_cred')
         self.rescan_since = config.get('bwt_rescan_since', 'all')
+        self.custom_opt = config.get('bwt_custom_opt')
         self.socket_path = config.get('bwt_socket_path', default_socket_path())
-        self.poll_interval = config.get('bwt_poll_interval', 5)
         self.verbose = config.get('bwt_verbose', 0)
 
         if config.get('bwt_was_oneserver') is None:
@@ -70,6 +70,10 @@ def start(self):
         for i in range(self.verbose):
             args.append('-v')
 
+        if self.custom_opt:
+            # XXX this doesn't support arguments with spaces. thankfully bwt doesn't currently have any.
+            args.extend(self.custom_opt.split(' '))
+
         self.stop()
         _logger.info('Starting bwt daemon')
         _logger.debug('bwt options: %s' % ' '.join(args))

contrib/electrum-plugin/qt.py

@@ -85,6 +85,11 @@ def settings_dialog(self, window):
         form.addRow(_('Scan:'), rescan_l)
         form.addRow('', helptext(_('Set to the wallet creation date to reduce scanning time.'), False))
 
+        custom_opt_e = input(self.custom_opt)
+        custom_opt_e.setPlaceholderText('e.g. --gap-limit 50 --poll-interval 1')
+        form.addRow('Options', custom_opt_e)
+        form.addRow('', helptext(_('Additional custom options. Optional.'), False))
+
         verbose_c = QComboBox()
         verbose_c.addItems([ _('info'), _('debug'), _('trace') ])
         verbose_c.setCurrentIndex(self.verbose)
@@ -111,6 +116,7 @@ def save_config_and_run():
             self.bitcoind_cred = str(cred_e.text())
             self.bitcoind_wallet = str(wallet_e.text())
             self.rescan_since = get_rescan_value(rescan_c, rescan_e)
+            self.custom_opt = str(custom_opt_e.text())
             self.verbose = verbose_c.currentIndex()
 
             self.config.set_key('bwt_enabled', self.enabled)
@@ -119,6 +125,7 @@ def save_config_and_run():
             self.config.set_key('bwt_bitcoind_cred', self.bitcoind_cred)
             self.config.set_key('bwt_bitcoind_wallet', self.bitcoind_wallet)
             self.config.set_key('bwt_rescan_since', self.rescan_since)
+            self.config.set_key('bwt_custom_opt', self.custom_opt)
             self.config.set_key('bwt_verbose', self.verbose)
 
             log_t.clear()