Skip to content

Commit 4c9f5dc

Browse files
author
Lalit Sharma
committed
feat: update Photography Guide landscape composite to center MAX framing; adjust related tests and documentation
1 parent 930b17a commit 4c9f5dc

5 files changed

Lines changed: 15 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,15 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [1.1.35] — 2026-02-26
9+
10+
### Fixed
11+
- Updated `Photography Guide` landscape composite framing so `MAX` is anchored at the center of the frame (horizontal + vertical), preventing MAX placement from being cut off in the modal.
12+
13+
### Changed
14+
- Updated landscape composite helper expectations/docs to reflect centered `MAX` framing.
15+
- Bumped `apps/mobile` version to `1.1.35`.
16+
817
## [1.1.34] — 2026-02-26
918

1019
### Added

apps/mobile/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@eclipse-timer/mobile",
3-
"version": "1.1.34",
3+
"version": "1.1.35",
44
"private": true,
55
"main": "index.js",
66
"scripts": {

apps/mobile/src/screens/PhotographyGuideScreen.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ export default function PhotographyGuideScreen({
507507
) : null}
508508
</View>
509509
<Text style={styles.compositeModalBody}>
510-
24mm framing simulation with MAX anchored at center / 2/3 vertical in frame.
510+
24mm framing simulation with MAX anchored at frame center.
511511
</Text>
512512
<Text style={styles.compositeLegendText}>
513513
Numbers are shot indices. Amber dots mark edge-clamped shots.

apps/mobile/src/utils/photographyGuide.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ type BuildPhotographyGuideScheduleInput = {
5151
const PHASE_MAX_TOLERANCE_MS = 500;
5252
const LANDSCAPE_HORIZONTAL_FOV_DEG_24MM = 74;
5353
const LANDSCAPE_VERTICAL_FOV_DEG_24MM = 53;
54-
const LANDSCAPE_MAX_ANCHOR_Y_RATIO = 2 / 3;
54+
const LANDSCAPE_MAX_ANCHOR_Y_RATIO = 1 / 2;
5555
const LANDSCAPE_HORIZON_FALLBACK_Y_RATIO = 0.7;
5656
const LANDSCAPE_MIN_BODY_RADIUS_PX = 1.5;
5757
const LANDSCAPE_MAX_BODY_RADIUS_PX = 8;

apps/mobile/tests/photography-guide.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ describe("photography guide schedule", () => {
123123
expect(result.reason).toBe("Must be within eclipse area.");
124124
});
125125

126-
it("anchors MAX at horizontal center and 2/3 vertical in landscape composite", () => {
126+
it("anchors MAX at frame center in landscape composite", () => {
127127
const scheduleResult = buildPhotographyGuideSchedule({
128128
visible: true,
129129
totalPictures: 5,
@@ -146,7 +146,7 @@ describe("photography guide schedule", () => {
146146
const maxPlacement = layout.placements.find((placement) => placement.phaseBucket === "MAX");
147147

148148
expect(layout.anchorX).toBeCloseTo(180, 6);
149-
expect(layout.anchorY).toBeCloseTo(144, 6);
149+
expect(layout.anchorY).toBeCloseTo(108, 6);
150150
expect(maxPlacement).toBeDefined();
151151
expect(maxPlacement?.x).toBeCloseTo(layout.anchorX, 6);
152152
expect(maxPlacement?.y).toBeCloseTo(layout.anchorY, 6);
@@ -242,7 +242,7 @@ describe("photography guide schedule", () => {
242242
});
243243

244244
expect(layout.anchorX).toBeCloseTo(180, 6);
245-
expect(layout.anchorY).toBeCloseTo(144, 6);
245+
expect(layout.anchorY).toBeCloseTo(108, 6);
246246
expect(layout.horizonY).toBeCloseTo(216, 1);
247247

248248
const ys = layout.placements.map((placement) => placement.y);

0 commit comments

Comments
 (0)