Skip to content
This repository was archived by the owner on Aug 16, 2023. It is now read-only.

Commit 438c145

Browse files
committed
Little bit of cleanup.
1 parent 4e49086 commit 438c145

5 files changed

Lines changed: 4 additions & 201 deletions

File tree

CMDQueryStringSerialization.xcodeproj/project.pbxproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
93832CBD18957BCD005D5744 /* CMDQueryStringMultipleKeysArrayTransformer.m in Sources */ = {isa = PBXBuildFile; fileRef = 93832CBC18957BCD005D5744 /* CMDQueryStringMultipleKeysArrayTransformer.m */; };
2020
93832CC618957F4A005D5744 /* CMDQueryStringMultipleKeysWithBracketsArrayTransformer.m in Sources */ = {isa = PBXBuildFile; fileRef = 93832CC518957F4A005D5744 /* CMDQueryStringMultipleKeysWithBracketsArrayTransformer.m */; };
2121
93832CC918957F8F005D5744 /* CMDQueryStringCommaSeparatedArrayTransformer.m in Sources */ = {isa = PBXBuildFile; fileRef = 93832CC818957F8F005D5744 /* CMDQueryStringCommaSeparatedArrayTransformer.m */; };
22-
93832CCC189582EF005D5744 /* CMDKeyValuePairString.m in Sources */ = {isa = PBXBuildFile; fileRef = 93832CCB189582EF005D5744 /* CMDKeyValuePairString.m */; };
2322
93832CCF18958BAF005D5744 /* NSString+CMDQueryStringSerialization.m in Sources */ = {isa = PBXBuildFile; fileRef = 93832CCE18958BAF005D5744 /* NSString+CMDQueryStringSerialization.m */; };
2423
93832CD018958D56005D5744 /* NSString+CMDQueryStringSerialization.m in Sources */ = {isa = PBXBuildFile; fileRef = 93832CCE18958BAF005D5744 /* NSString+CMDQueryStringSerialization.m */; };
2524
/* End PBXBuildFile section */
@@ -68,8 +67,6 @@
6867
93832CC518957F4A005D5744 /* CMDQueryStringMultipleKeysWithBracketsArrayTransformer.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CMDQueryStringMultipleKeysWithBracketsArrayTransformer.m; sourceTree = "<group>"; };
6968
93832CC718957F8F005D5744 /* CMDQueryStringCommaSeparatedArrayTransformer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CMDQueryStringCommaSeparatedArrayTransformer.h; sourceTree = "<group>"; };
7069
93832CC818957F8F005D5744 /* CMDQueryStringCommaSeparatedArrayTransformer.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CMDQueryStringCommaSeparatedArrayTransformer.m; sourceTree = "<group>"; };
71-
93832CCA189582EF005D5744 /* CMDKeyValuePairString.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CMDKeyValuePairString.h; sourceTree = "<group>"; };
72-
93832CCB189582EF005D5744 /* CMDKeyValuePairString.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CMDKeyValuePairString.m; sourceTree = "<group>"; };
7370
93832CCD18958BAF005D5744 /* NSString+CMDQueryStringSerialization.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "NSString+CMDQueryStringSerialization.h"; sourceTree = "<group>"; };
7471
93832CCE18958BAF005D5744 /* NSString+CMDQueryStringSerialization.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "NSString+CMDQueryStringSerialization.m"; sourceTree = "<group>"; };
7572
/* End PBXFileReference section */
@@ -140,8 +137,6 @@
140137
3BF7142318B3FAD300D596B6 /* CMDQueryStringReader.m */,
141138
3BF7142618B3FB3200D596B6 /* CMDQueryStringWriter.h */,
142139
3BF7142718B3FB3200D596B6 /* CMDQueryStringWriter.m */,
143-
93832CCA189582EF005D5744 /* CMDKeyValuePairString.h */,
144-
93832CCB189582EF005D5744 /* CMDKeyValuePairString.m */,
145140
93832CC218957E89005D5744 /* Arrays */,
146141
3B63E2C418B40367002812A5 /* Categories */,
147142
3B6EAFA0188F5D78005D2EB4 /* Supporting Files */,
@@ -275,7 +270,6 @@
275270
93832CCF18958BAF005D5744 /* NSString+CMDQueryStringSerialization.m in Sources */,
276271
93832CC918957F8F005D5744 /* CMDQueryStringCommaSeparatedArrayTransformer.m in Sources */,
277272
3BF7142418B3FAD300D596B6 /* CMDQueryStringReader.m in Sources */,
278-
93832CCC189582EF005D5744 /* CMDKeyValuePairString.m in Sources */,
279273
93832CC618957F4A005D5744 /* CMDQueryStringMultipleKeysWithBracketsArrayTransformer.m in Sources */,
280274
93832CBD18957BCD005D5744 /* CMDQueryStringMultipleKeysArrayTransformer.m in Sources */,
281275
3BF7142818B3FB3200D596B6 /* CMDQueryStringWriter.m in Sources */,

CMDQueryStringSerialization/CMDKeyValuePairString.h

Lines changed: 0 additions & 30 deletions
This file was deleted.

CMDQueryStringSerialization/CMDKeyValuePairString.m

Lines changed: 0 additions & 42 deletions
This file was deleted.

CMDQueryStringSerialization/CMDQueryStringSerialization.m

Lines changed: 1 addition & 120 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ + (NSDictionary *)dictionaryWithQueryString:(NSString *)string {
1919

2020

2121
+ (NSString *)queryStringWithDictionary:(NSDictionary *)dictionary {
22-
return [self queryStringWithDictionary:dictionary options:kNilOptions];
22+
return [self queryStringWithDictionary:dictionary options:CMDQueryStringWritingOptionArrayRepeatKeysWithBrackets];
2323
}
2424

2525

@@ -29,122 +29,3 @@ + (NSString *)queryStringWithDictionary:(NSDictionary *)dictionary options:(CMDQ
2929
}
3030

3131
@end
32-
33-
//@interface NSMutableDictionary (CMDQueryStringSerialization)
34-
//
35-
//- (void)cmd_addObject:(id)object forKey:(NSString *)key;
36-
//
37-
//@end
38-
//
39-
//@interface NSNumber (CMDQueryStringSerialization)
40-
//
41-
//-(NSString *)cmd_stringByAddingEscapes;
42-
//
43-
//@end
44-
//
45-
//@implementation CMDQueryStringSerialization
46-
//
47-
//#pragma mark - Deserialization
48-
//
49-
//+ (NSDictionary *)dictionaryWithQueryString:(NSString *)string {
50-
// return [self dictionaryWithQueryString:string arrayOption:CMDQueryStringArraySerializationOptionMultipleKeys];
51-
//}
52-
//
53-
//<<<<<<< HEAD
54-
//
55-
//+ (NSString *)queryStringWithDictionary:(NSDictionary *)dictionary {
56-
// if (!dictionary) {
57-
// return nil;
58-
// }
59-
// NSMutableArray *pairs = [NSMutableArray arrayWithCapacity:[dictionary count]];
60-
// [dictionary enumerateKeysAndObjectsUsingBlock:^(NSString *key, id value, BOOL *stop) {
61-
// void (^addPair)(NSString *key, NSString *value) = ^(NSString *key, NSString *value) {
62-
// [pairs addObject:[NSString stringWithFormat:@"%@=%@",
63-
// [key cmd_stringByAddingEscapes],
64-
// [value cmd_stringByAddingEscapes]]];
65-
// };
66-
//
67-
// if ([value isKindOfClass:[NSArray class]]) {
68-
// for (NSString *valueFromArray in (NSArray *)value) {
69-
// addPair(key, valueFromArray);
70-
//=======
71-
//+ (NSDictionary *)dictionaryWithQueryString:(NSString *)string arrayOption:(CMDQueryStringArraySerializationOption)arrayOption {
72-
// NSMutableDictionary *result = [NSMutableDictionary new];
73-
//
74-
// [CMDKeyValuePairString enumeratePairsInString:string block:^(NSString *key, NSString *value) {
75-
// if (arrayOption == CMDQueryStringArraySerializationOptionCommaSeparated) {
76-
// NSArray *values = [value componentsSeparatedByString:@","];
77-
//
78-
// [values enumerateObjectsUsingBlock:^(NSString *commaSeparatedValue, NSUInteger index, BOOL *stop) {
79-
// [result cmd_addObject:commaSeparatedValue forKey:key];
80-
// }];
81-
// }
82-
// else {
83-
// if (arrayOption == CMDQueryStringArraySerializationOptionMultipleBracketedKeys) {
84-
// key = [key stringByReplacingOccurrencesOfString:@"[]" withString:@""];
85-
//>>>>>>> b1b6e17d5230b90e6590fa22976ff3b8be5fdef5
86-
// }
87-
//
88-
// [result cmd_addObject:value forKey:key];
89-
// }
90-
// }];
91-
//
92-
// return [result copy];
93-
//}
94-
//
95-
//#pragma mark - Serialization
96-
//
97-
//- (void)cmd_enumeratePairs:(void (^) (NSString *key, NSString *value))block {
98-
// if ([self length] == 0) {
99-
// return;
100-
// }
101-
// NSArray *pairs = [self componentsSeparatedByString:@"&"];
102-
// [pairs enumerateObjectsUsingBlock:^(NSString *pair, NSUInteger index, BOOL *stop) {
103-
// NSRange range = [pair rangeOfString:@"="];
104-
// NSString *key, *value;
105-
// if (range.location == NSNotFound) {
106-
// key = [pair cmd_stringByRemovingEscapes];
107-
// value = @"";
108-
//=======
109-
//+ (NSString *)queryStringWithDictionary:(NSDictionary *)dictionary {
110-
// return [self queryStringWithDictionary:dictionary arrayOption:CMDQueryStringArraySerializationOptionMultipleKeys];
111-
//}
112-
//
113-
//+ (NSString *)queryStringWithDictionary:(NSDictionary *)dictionary arrayOption:(CMDQueryStringArraySerializationOption)arrayOption {
114-
// NSMutableArray *pairs = [NSMutableArray arrayWithCapacity:[dictionary count]];
115-
//
116-
// [dictionary enumerateKeysAndObjectsUsingBlock:^(NSString *key, id value, BOOL *stop) {
117-
// if ([value isKindOfClass:[NSArray class]]) {
118-
// id <CMDQueryStringArrayTransformer> transformer = [self arrayTransformerForOption:arrayOption];
119-
// [pairs addObjectsFromArray:[transformer keyValuePairStringsFromKey:key values:value]];
120-
//>>>>>>> b1b6e17d5230b90e6590fa22976ff3b8be5fdef5
121-
// }
122-
// else {
123-
// NSString *escapedKey = [key cmd_stringByAddingEscapes];
124-
// NSString *escapedValue = [value cmd_stringByAddingEscapes];
125-
//
126-
// [pairs addObject:[CMDKeyValuePairString pairStringWithKey:escapedKey value:escapedValue]];
127-
// }
128-
// }];
129-
//
130-
// return [pairs componentsJoinedByString:@"&"];
131-
//}
132-
//
133-
//#pragma mark - Private
134-
//
135-
//+ (id <CMDQueryStringArrayTransformer>)arrayTransformerForOption:(CMDQueryStringArraySerializationOption)option {
136-
// static NSDictionary *arraySerializationOptionsToTransformers;
137-
//
138-
// static dispatch_once_t onceToken;
139-
// dispatch_once(&onceToken, ^{
140-
// arraySerializationOptionsToTransformers = @{
141-
// @(CMDQueryStringArraySerializationOptionMultipleKeys) : [CMDQueryStringMultipleKeysArrayTransformer class],
142-
// @(CMDQueryStringArraySerializationOptionMultipleBracketedKeys) : [CMDQueryStringMultipleBracketedKeysArrayTransformer class],
143-
// @(CMDQueryStringArraySerializationOptionCommaSeparated) : [CMDQueryStringCommaSeparatedArrayTransformer class]
144-
// };
145-
// });
146-
//
147-
// return arraySerializationOptionsToTransformers[@(option)];
148-
//}
149-
//
150-
//@end

Readme.markdown

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Easily convert between dictionaries and query strings in iOS. The API is similar
44

55
## Usage
66

7-
```objectivec
7+
```objc
88
NSString *queryString = [CMDQueryStringSerialization queryStringWithDictionary:dictionary];
99
```
1010
@@ -14,8 +14,8 @@ NSString *queryString = [CMDQueryStringSerialization queryStringWithDictionary:d
1414
* `key[]=value1&key[]=value2`
1515
* `key=value1,value2`
1616
17-
The `CMDQueryStringArraySerializationOption` enum contains options that map to each of these formats, with `CMDQueryStringArraySerializationOptionMultipleKeys` being the default if no option is passed.
17+
`CMDQueryStringWritingOptions` contains options that map to each of these formats, with `CMDQueryStringWritingOptionArrayRepeatKeysWithBrackets` being the default if no option is passed.
1818
1919
## License
2020
21-
MIT
21+
`CMDQueryStringSerialization` is released under the MIT License.

0 commit comments

Comments
 (0)