Add analyzers

Author: calledude

.editorconfig

@@ -42,7 +42,7 @@ dotnet_style_null_propagation = true:suggestion
 dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
 dotnet_style_prefer_auto_properties = true:silent
 dotnet_style_object_initializer = true:suggestion
-dotnet_style_prefer_collection_expression = true:suggestion
+dotnet_style_prefer_collection_expression = when_types_exactly_match:suggestion
 dotnet_style_collection_initializer = true:suggestion
 dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
 dotnet_style_prefer_conditional_expression_over_assignment = true:silent
@@ -156,3 +156,288 @@ dotnet_style_qualification_for_method = false:silent
 dotnet_style_qualification_for_property = false:silent
 dotnet_style_qualification_for_event = false:silent
 indent_style = tab
+
+roslynator_refactorings.enabled = true
+roslynator_compiler_diagnostic_fixes.enabled = true
+roslynator_refactoring.remove_all_comments.enabled = true
+
+
+
+# Roslynator settings
+
+roslynator_accessibility_modifiers = explicit
+# Applicable to: rcs1018
+
+roslynator_accessor_braces_style = single_line_when_expression_is_on_single_line
+# Default: multi_line
+# Applicable to: rcs0020
+
+roslynator_array_creation_type_style = implicit
+# Applicable to: rcs1014
+
+roslynator_arrow_token_new_line = before
+# Applicable to: rcs0032
+
+roslynator_binary_operator_new_line = before
+# Applicable to: rcs0027
+
+roslynator_blank_line_after_file_scoped_namespace_declaration = true
+# Applicable to: rcs0060
+
+roslynator_blank_line_between_closing_brace_and_switch_section = false
+# Applicable to: rcs0014, rcs1036
+
+roslynator_conditional_operator_condition_parentheses_style = omit
+# Applicable to: rcs1051
+
+roslynator_conditional_operator_new_line = before
+# Applicable to: rcs0028
+
+roslynator_configure_await = true
+# Applicable to: rcs1090
+
+roslynator_doc_comment_summary_style = multi_line
+# Applicable to: rcs1253
+
+roslynator_empty_string_style = field
+# Applicable to: rcs1078
+
+roslynator_enum_flag_value_style = shift_operator
+# Applicable to: rcs1254
+
+roslynator_enum_has_flag_style = method
+# Applicable to: rcs1096
+
+roslynator_infinite_loop_style = while
+# Applicable to: rcs1252
+
+roslynator_null_check_style = pattern_matching
+# Applicable to: rcs1248
+
+roslynator_null_conditional_operator_new_line = before
+# Applicable to: rcs0059
+
+roslynator_object_creation_parentheses_style = omit
+# Applicable to: rcs1050
+
+roslynator_object_creation_type_style = implicit
+# Applicable to: rcs1250
+
+roslynator_prefix_field_identifier_with_underscore = true
+
+roslynator_trailing_comma_style = include
+# Applicable to: rcs1260
+
+roslynator_use_anonymous_function_or_method_group = method_group
+# Applicable to: rcs1207
+
+roslynator_use_block_body_when_declaration_spans_over_multiple_lines = true
+# Applicable to: rcs1016
+
+roslynator_use_block_body_when_expression_spans_over_multiple_lines = true
+# Applicable to: rcs1016
+
+roslynator_use_collection_expression = true
+# Applicable to: rcs1014, rcs1250
+
+roslynator_use_var = always
+# Applicable to: rcs1264
+
+roslynator_use_var_instead_of_implicit_object_creation = true
+# Applicable to: rcs1250
+
+
+# Analyzers
+
+# Add blank line after embedded statement
+dotnet_diagnostic.rcs0001.severity = warning
+
+# Add blank line after using directive list
+dotnet_diagnostic.rcs0003.severity = suggestion
+
+# Add blank line between closing brace and next statement
+dotnet_diagnostic.rcs0008.severity = suggestion
+
+# Add blank line between declaration and documentation comment
+dotnet_diagnostic.rcs0009.severity = suggestion
+
+# Format accessor's braces on a single line or multiple lines
+dotnet_diagnostic.rcs0020.severity = suggestion
+# Options: roslynator_accessor_braces_style
+
+# Format block's braces on a single line or multiple lines
+dotnet_diagnostic.rcs0021.severity = suggestion
+# Options: roslynator_block_braces_style
+
+# Put full accessor on its own line
+dotnet_diagnostic.rcs0025.severity = warning
+
+# Place new line after/before binary operator
+dotnet_diagnostic.rcs0027.severity = suggestion
+# Options: roslynator_binary_operator_new_line
+
+# Place new line after/before '?:' operator
+dotnet_diagnostic.rcs0028.severity = suggestion
+# Options: roslynator_conditional_operator_new_line
+
+# Put enum member on its own line
+dotnet_diagnostic.rcs0031.severity = suggestion
+
+# Place new line after/before arrow token
+dotnet_diagnostic.rcs0032.severity = suggestion
+# Options: roslynator_arrow_token_new_line
+
+# Put statement on its own line
+dotnet_diagnostic.rcs0033.severity = error
+
+# Put type parameter constraint on its own line
+dotnet_diagnostic.rcs0034.severity = suggestion
+
+# Remove new line between 'if' keyword and 'else' keyword
+dotnet_diagnostic.rcs0041.severity = warning
+
+# Put auto-accessors on a single line
+dotnet_diagnostic.rcs0042.severity = suggestion
+
+# Fix formatting of a binary expression chain
+dotnet_diagnostic.rcs0055.severity = suggestion
+
+# Place new line after/before null-conditional operator
+dotnet_diagnostic.rcs0059.severity = suggestion
+# Options: roslynator_null_conditional_operator_new_line
+
+# Add/remove line after file scoped namespace declaration
+dotnet_diagnostic.rcs0060.severity = suggestion
+# Options: roslynator_blank_line_after_file_scoped_namespace_declaration
+
+# Simplify nested using statement
+dotnet_diagnostic.rcs1005.severity = suggestion
+
+# Use predefined type
+dotnet_diagnostic.rcs1013.severity = suggestion
+
+# Use explicitly/implicitly typed array
+dotnet_diagnostic.rcs1014.severity = suggestion
+# Options: roslynator_array_creation_type_style, roslynator_use_collection_expression
+
+# Use block body or expression body
+dotnet_diagnostic.rcs1016.severity = suggestion
+# Options: roslynator_body_style, roslynator_use_block_body_when_declaration_spans_over_multiple_lines, roslynator_use_block_body_when_expression_spans_over_multiple_lines
+
+# Add/remove accessibility modifiers
+dotnet_diagnostic.rcs1018.severity = suggestion
+# Options: roslynator_accessibility_modifiers
+
+# Order modifiers
+dotnet_diagnostic.rcs1019.severity = suggestion
+
+# Remove 'partial' modifier from type with a single part
+dotnet_diagnostic.rcs1043.severity = warning
+
+# Include/omit parentheses when creating new object
+dotnet_diagnostic.rcs1050.severity = suggestion
+# Options: roslynator_object_creation_parentheses_style
+
+# Add/remove parentheses from condition in conditional operator
+dotnet_diagnostic.rcs1051.severity = suggestion
+# Options: roslynator_conditional_operator_condition_parentheses_style
+
+# Unnecessary semicolon at the end of declaration
+dotnet_diagnostic.rcs1055.severity = suggestion
+
+# Remove redundant constructor
+dotnet_diagnostic.rcs1074.severity = suggestion
+
+# Use "" or 'string.Empty'
+dotnet_diagnostic.rcs1078.severity = suggestion
+# Options: roslynator_empty_string_style
+
+# Use 'Count/Length' property instead of 'Any' method
+dotnet_diagnostic.rcs1080.severity = suggestion
+
+# Split variable declaration
+dotnet_diagnostic.rcs1081.severity = suggestion
+
+# Add/remove 'ConfigureAwait(false)' call
+dotnet_diagnostic.rcs1090.severity = suggestion
+# Options: roslynator_configure_await
+
+# Declare using directive on top level
+dotnet_diagnostic.rcs1094.severity = suggestion
+
+# Use 'HasFlag' method or bitwise operator
+dotnet_diagnostic.rcs1096.severity = suggestion
+# Options: roslynator_enum_has_flag_style
+
+# Declare type inside namespace
+dotnet_diagnostic.rcs1110.severity = warning
+
+# Add braces to if-else
+dotnet_diagnostic.rcs1126.severity = suggestion
+
+# Bitwise operation on enum without Flags attribute
+dotnet_diagnostic.rcs1130.severity = warning
+
+# Remove redundant Dispose/Close call
+dotnet_diagnostic.rcs1133.severity = warning
+
+# Remove redundant statement
+dotnet_diagnostic.rcs1134.severity = suggestion
+
+# Add exception to documentation comment
+dotnet_diagnostic.rcs1140.severity = warning
+
+# Value type object is never equal to null
+dotnet_diagnostic.rcs1166.severity = warning
+
+# Parameter name differs from base name
+dotnet_diagnostic.rcs1168.severity = suggestion
+
+# Remove redundant auto-property initialization
+dotnet_diagnostic.rcs1188.severity = suggestion
+
+# Avoid unnecessary boxing of value type
+dotnet_diagnostic.rcs1198.severity = suggestion
+
+# Avoid NullReferenceException
+dotnet_diagnostic.rcs1202.severity = warning
+
+# Use anonymous function or method group
+dotnet_diagnostic.rcs1207.severity = suggestion
+# Options: roslynator_use_anonymous_function_or_method_group
+
+# Reduce 'if' nesting
+dotnet_diagnostic.rcs1208.severity = suggestion
+
+# Use async/await when necessary
+dotnet_diagnostic.rcs1229.severity = warning
+
+# Duplicate enum value
+dotnet_diagnostic.rcs1234.severity = warning
+
+# Avoid nested ?: operators
+dotnet_diagnostic.rcs1238.severity = warning
+
+# Normalize null check
+dotnet_diagnostic.rcs1248.severity = suggestion
+# Options: roslynator_null_check_style
+
+# Use implicit/explicit object creation
+dotnet_diagnostic.rcs1250.severity = suggestion
+# Options: roslynator_object_creation_type_style, roslynator_use_collection_expression, roslynator_use_var_instead_of_implicit_object_creation
+
+# Simplify argument null check
+dotnet_diagnostic.rcs1255.severity = suggestion
+
+# Add/remove trailing comma
+dotnet_diagnostic.rcs1260.severity = suggestion
+# Options: roslynator_trailing_comma_style
+
+# Use 'var' or explicit type
+dotnet_diagnostic.rcs1264.severity = suggestion
+# Options: roslynator_use_var
+
+# Refactorings
+
+roslynator_refactoring.replace_method_with_property.enabled = true
+roslynator_refactoring.use_string_empty_instead_of_empty_string_literal.enabled = true

AsyncMemoryCache.Tests/AsyncMemoryCache.Tests.csproj

@@ -19,17 +19,21 @@
 
 	<ItemGroup>
 		<PackageReference Include="coverlet.msbuild" Version="6.0.0">
-		  <PrivateAssets>all</PrivateAssets>
-		  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>
 		<PackageReference Include="GitHubActionsTestLogger" Version="2.3.3">
-		  <PrivateAssets>all</PrivateAssets>
-		  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>
 		<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
 		<PackageReference Include="Microsoft.Extensions.TimeProvider.Testing" Version="8.1.0" />
 		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
 		<PackageReference Include="NSubstitute" Version="5.1.0" />
+		<PackageReference Include="NSubstitute.Analyzers.CSharp" Version="1.0.16">
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+		</PackageReference>
 		<PackageReference Include="xunit" Version="2.6.6" />
 		<PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

AsyncMemoryCache/AsyncMemoryCache.csproj

@@ -3,14 +3,14 @@
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
 		<Nullable>enable</Nullable>
-		
+
 		<EnableNETAnalyzers>true</EnableNETAnalyzers>
 		<AnalysisLevel>preview</AnalysisLevel>
-		
+
 		<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
 		<CodeAnalysisTreatWarningsAsErrors>true</CodeAnalysisTreatWarningsAsErrors>
 	</PropertyGroup>
-	
+
 	<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
 		<EmbedUntrackedSources>true</EmbedUntrackedSources>
 		<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
@@ -24,7 +24,7 @@
 		<Authors>calledude</Authors>
 
 		<PublishRepositoryUrl>true</PublishRepositoryUrl>
-		
+
 		<PackageLicenseExpression>MIT</PackageLicenseExpression>
 		<PackageReadmeFile>README.md</PackageReadmeFile>
 		<PackageTags>asyncmemorycache async cache lazy dispose</PackageTags>
@@ -37,6 +37,16 @@
 	<ItemGroup>
 		<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
 		<PackageReference Include="Nito.AsyncEx.Coordination" Version="5.1.2" />
+
+		<PackageReference Include="Roslynator.Analyzers" Version="4.10.0">
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+		</PackageReference>
+		<PackageReference Include="Roslynator.Formatting.Analyzers" Version="4.10.0">
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+		</PackageReference>
+
 	</ItemGroup>
 
 	<ItemGroup>

AsyncMemoryCache/CacheEntity.cs

@@ -12,11 +12,10 @@ public sealed class CacheEntity<TKey, TValue>
 	public CacheEntity(TKey key, Func<Task<TValue>> objectFactory, AsyncLazyFlags lazyFlags)
 	{
 		Key = key;
-		ObjectFactory = new AsyncLazy<TValue>(objectFactory, lazyFlags);
+		ObjectFactory = new(objectFactory, lazyFlags);
 	}
 
 	public TKey Key { get; }
-
 	public AsyncLazy<TValue> ObjectFactory { get; }
 
 	private int _references;