From 62315c60890e5125966db15b54cdd349e21272b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Thu, 11 Jun 2026 13:25:46 +0200 Subject: [PATCH] docs: add agent PR readiness checklist --- AGENTS.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/AGENTS.md b/AGENTS.md index 2fc54248c..5e28451e9 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -237,6 +237,15 @@ Command-only flags (like `find --first`) that do not flow to the platform layer - Cross-platform behavior change: run `pnpm test:integration`. - Any change in: `src/`, `test/`, `skills/`: `pnpm format`. +## PR Readiness Checklist +- Static gates first: required checks from **Testing Matrix** pass, `pnpm check:fallow --base origin/main` is clean when code quality/dead-code risk is relevant, CI guards are green, and no conflict markers or unmerged paths remain. +- Command-surface changes preserve CLI, Node.js, daemon, MCP, help, docs, and SkillGym coverage where that surface is affected. Do not duplicate command contracts across layers. +- Device-facing behavior is not merge-ready until it has real simulator/emulator/device evidence for the changed path. Fixture-backed tests can prove contracts, but they do not replace a live run that creates or observes the artifact/state the feature claims to handle. +- If live verification is blocked, state the blocker, exact command or device needed, and downgrade the PR to residual risk instead of calling it ready. +- Runtime output must stay agent-friendly: compact defaults, top offenders first for diagnostics/perf, bounded arrays in JSON, artifact paths for large raw data, and progressive lookup for deeper detail. +- Before final response or PR handoff, close every manual `agent-device` session opened during verification and report any cleanup that could not be completed. +- Reviewers should check sibling PR ordering, hidden behavior changes, docs/help impact, and whether the tightening pass removed obsolete code/tests introduced or made unnecessary by the change. + ## Token Guardrails - Do not read unrelated files once owning module is identified. - Do not run integration tests by default.