Skip to content

Commit a2230d7

Browse files
authored
Merge pull request #134 from callstack/migrate-to-typescript
Migrate to Typescript
2 parents 1a1b220 + 75473e0 commit a2230d7

30 files changed

Lines changed: 890 additions & 6021 deletions

.eslintignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

.eslintrc

Lines changed: 0 additions & 14 deletions
This file was deleted.

.flowconfig

Lines changed: 0 additions & 54 deletions
This file was deleted.

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# Typescript generated files
2+
dist/
3+
14
# OSX
25
#
36
.vscode

AdIconViewManager.js

Lines changed: 0 additions & 40 deletions
This file was deleted.

BannerViewManager.js

Lines changed: 0 additions & 48 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
Pull requests are always welcome!
44
Before opening a PR, please:
55

6+
- Ensure Typescript compiles without errors
7+
- Run TSLint and fix any outstanding issues
68
- Ensure you've formatted your code with Prettier
7-
- Run ESLint and fix any outstanding issues
8-
- Run Flow and ensure no errors were introduced
99

10-
Thanks for contributing!
10+
Thanks for contributing!

MediaViewManager.js

Lines changed: 0 additions & 40 deletions
This file was deleted.

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ InterstitialAdManager.showAd(placementId)
8989
.catch(error => {});
9090
```
9191

92-
The `showAd` method returns a promise that will be resolves once the ad has been either dismissed or clicked by the user. The promise will reject if an erros occurs before displaying the ad, such as a network error.
92+
The `showAd` method returns a promise that will be resolves once the ad has been either dismissed or clicked by the user. The promise will reject if an error occurs before displaying the ad, such as a network error.
9393

9494
### Native Ads
9595

@@ -179,7 +179,7 @@ import { AdChoicesView } from 'react-native-fbads'
179179
| expandable | false | false | (iOS only) makes the native AdChoices expandable |
180180
| location | topLeft | false | (iOS only) controls the location of the AdChoices icon |
181181

182-
#### 3. Showing the ad
182+
#### 5. Showing the ad
183183

184184
Finally, wrap your component with the `withNativeAd` HOC and pass it the `adsManager` you've previously created.
185185

TriggerableView.js

Lines changed: 0 additions & 40 deletions
This file was deleted.

0 commit comments

Comments
 (0)