Commit b035b5d
Fix main CI: commit ferric Cargo.lock and pin macOS CMake (#374)
* ferric-example: commit Cargo.lock to pin the Rust toolchain deps
CI resolved Rust dependencies fresh on every run because Cargo.lock was
gitignored (a leftover from the initial `cargo new --lib` scaffolding in
#43 — the stock library-crate convention). That let `napi-derive-backend`
float to 5.1.2, which expands the `#[napi]` attribute macro into a broken
`ctor` `unify_features` invocation ("expected `(`, found `]`"), failing the
bootstrap build of every CI job that compiles ferric-example.
ferric-example is a `crate-type = ["cdylib"]` that builds a final `.node`
artifact, not a library published to crates.io, so committing Cargo.lock is
the recommended practice — the direct analogue of package-lock.json. The
committed lock pins napi-derive-backend 5.0.2 (last known-good). Verified
with `cargo build --locked`.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* ci: pin CMake on macOS unit tests
The macos-latest runner now ships CMake 4.2.x, but the project pins
CMAKE_VERSION 4.1.2 (matching the React Native template and the version
used by the test-macos / Android SDK jobs). The unit-tests job did not
pin CMake, so macOS builds picked up the incompatible runner default.
Install the pinned version via jwlawson/actions-setup-cmake, mirroring
the test-macos job, gated to macOS runners.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UCN2h9xbyn4yhxfVZyMzAm
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 8421e88 commit b035b5d
3 files changed
Lines changed: 202 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
95 | 101 | | |
96 | 102 | | |
97 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments