Skip to content

Commit e87569a

Browse files
kraenhansenclaude
andauthored
ci: pin CMake on macOS test-ios and test-ferric-apple-triplets (#377)
These two jobs build the weak-node-api Apple framework via cmake-rn on macos-latest but never pinned CMake, so they hit the same 4.2.x FRAMEWORK-vs-HEADERS-file-set error that broke unit-tests (#374) and weak-node-api-tests (#375): CMake Error: The file set "HEADERS" is incompatible with the "FRAMEWORK" target "weak-node-api". test-ios fails downstream ("Expected an XCFramework at weak-node-api/build/Release/weak-node-api.xcframework") because the framework never builds. Both run on pushes to main, so they keep main red. Pin CMake to the project's 4.1.2 on both, matching the other jobs. Interim workaround; proper CMakeLists fix tracked in #376. Claude-Session: https://claude.ai/code/session_01UCN2h9xbyn4yhxfVZyMzAm Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 9e596c8 commit e87569a

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

.github/workflows/check.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,11 @@ jobs:
168168
with:
169169
packages: tools platform-tools ndk;${{ env.NDK_VERSION }}
170170
- run: rustup target add x86_64-linux-android aarch64-linux-android armv7-linux-androideabi i686-linux-android aarch64-apple-ios-sim
171+
# macOS runners ship a newer CMake than the project supports; pin it to match the version used elsewhere in CI
172+
- name: Install compatible CMake version
173+
uses: jwlawson/actions-setup-cmake@v2
174+
with:
175+
cmake-version: ${{ env.CMAKE_VERSION }}
171176
- run: npm ci
172177
- run: npm run bootstrap
173178
env:
@@ -340,6 +345,11 @@ jobs:
340345
distribution: "temurin"
341346
- run: rustup target add x86_64-apple-darwin x86_64-apple-ios aarch64-apple-ios aarch64-apple-ios-sim
342347
- run: rustup toolchain install nightly --component rust-src
348+
# macOS runners ship a newer CMake than the project supports; pin it to match the version used elsewhere in CI
349+
- name: Install compatible CMake version
350+
uses: jwlawson/actions-setup-cmake@v2
351+
with:
352+
cmake-version: ${{ env.CMAKE_VERSION }}
343353
- run: npm ci
344354
- run: npm run build
345355
- name: Build weak-node-api for all Apple architectures

0 commit comments

Comments
 (0)